Fixes coreference results, updates jar directory #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated the CR_PATTERN regex to correctly extract the coreference set notation - cleaned up the code in the STATE_COREFERENCE if/else branch in parse_parser_results to be clearer and actually add the coreference results to the result dict.
Author
|
this is because when I tried to use your code off the shelf I never got any coreference results back in the result dict, but the output in the server console showed results. so this fixes that problem. |
fixed the terrible bug I left in my previous commit
relwell
added a commit
that referenced
this pull request
Jan 22, 2014
Fixes coreference results, updates jar directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notation