fix(router): remove dead debug code from SemanticRouter

Removed unused debug aggregation code that was creating a SpotBugs
violation (DLS: Dead store to rawResult).

The debug code at lines 539-547 was used during development to inspect
raw aggregation results but is no longer needed in production code.

Fixes:
- SpotBugs DLS violation in getRouteMatches()
- Dead local store warning

Author: bsbodden

core/src/main/java/com/redis/vl/extensions/router/SemanticRouter.java

@@ -537,24 +537,6 @@ private List<RouteMatch> getRouteMatches(
     }
 
     // Build aggregation request (Python: _build_aggregate_request, line 308-320)
-    System.out.println("DEBUG: Filter expression: " + filterBuilder.toString());
-    System.out.println("DEBUG: Reduced field: " + reducedField);
-    System.out.println("DEBUG: Aggregation method: " + aggregationMethod);
-
-    // First check what VECTOR_RANGE returns without aggregation
-    redis.clients.jedis.search.aggr.AggregationBuilder noAggregate =
-        new redis.clients.jedis.search.aggr.AggregationBuilder(vectorQuery.toQueryString())
-            .params(vectorQuery.toParams())
-            .load("route_name", "vector_distance")
-            .dialect(2);
-
-    redis.clients.jedis.search.aggr.AggregationResult rawResult =
-        unifiedJedis.ftAggregate(index.getName(), noAggregate);
-    System.out.println("DEBUG: Raw results before grouping: " + rawResult.getResults().size());
-    for (java.util.Map<String, Object> row : rawResult.getResults()) {
-      System.out.println("DEBUG: Raw row: " + row);
-    }
-
     redis.clients.jedis.search.aggr.AggregationBuilder aggregation =
         new redis.clients.jedis.search.aggr.AggregationBuilder(vectorQuery.toQueryString())
             .params(vectorQuery.toParams())
@@ -569,14 +551,6 @@ private List<RouteMatch> getRouteMatches(
     redis.clients.jedis.search.aggr.AggregationResult result =
         unifiedJedis.ftAggregate(index.getName(), aggregation);
 
-    System.out.println(
-        "DEBUG getRouteMatches: Aggregation returned "
-            + result.getResults().size()
-            + " results after filtering");
-    for (java.util.Map<String, Object> row : result.getResults()) {
-      System.out.println("DEBUG getRouteMatches: Row after filter: " + row);
-    }
-
     // Convert results to RouteMatch list
     java.util.List<RouteMatch> matches = new java.util.ArrayList<>();
     for (java.util.Map<String, Object> row : result.getResults()) {

core/src/test/java/com/redis/vl/extensions/cache/NotebookSemanticCacheTest.java

@@ -150,12 +150,6 @@ public void testCacheStatistics() {
     llmcache.check("Question 5"); // Miss
     llmcache.check("Question 1"); // Hit again
 
-    // Cell 28: Check statistics
-    System.out.println("\nCache Statistics:");
-    System.out.println("Hit count: " + llmcache.getHitCount());
-    System.out.println("Miss count: " + llmcache.getMissCount());
-    System.out.println("Hit rate: " + String.format("%.2f%%", llmcache.getHitRate() * 100));
-
     assertEquals(3, llmcache.getHitCount());
     assertEquals(2, llmcache.getMissCount());
     assertEquals(0.6f, llmcache.getHitRate(), 0.01f);

core/src/test/java/com/redis/vl/extensions/cache/SemanticCacheIntegrationTest.java

@@ -314,19 +314,6 @@ void testTopKResults() {
 
     assertEquals(3, topResults.size());
 
-    // Debug: print distances
-    System.out.println("DEBUG: Top K results:");
-    for (int i = 0; i < topResults.size(); i++) {
-      System.out.println(
-          "  "
-              + i
-              + ": "
-              + topResults.get(i).getPrompt()
-              + " (distance: "
-              + topResults.get(i).getDistance()
-              + ")");
-    }
-
     // Results should be sorted by distance (most similar first)
     for (int i = 1; i < topResults.size(); i++) {
       assertTrue(

core/src/test/java/com/redis/vl/extensions/router/SemanticRouterIntegrationTest.java

@@ -215,18 +215,9 @@ void testNotebookQuery() {
     // Test no-match query from Python notebook cell 9
     // Python output: RouteMatch(name=None, distance=None)
     RouteMatch noMatch = router.route("are aliens real?");
-    System.out.println(
-        "DEBUG: aliens query - name=" + noMatch.getName() + ", distance=" + noMatch.getDistance());
-    System.out.println(
-        "DEBUG: technology threshold=" + notebookRoutes.get(0).getDistanceThreshold());
 
     assertThat(noMatch).isNotNull();
-    // NOTE: Java ONNX embeddings differ from Python, this query may match with distance near
-    // threshold
-    // Python: None, Java: may match technology with distance ~0.33
-    // Accept either outcome as embedding implementations differ
     if (noMatch.getName() != null) {
-      System.out.println("WARN: Java matched where Python didn't - embedding variance");
       assertThat(noMatch.getDistance()).isLessThan(0.75);
     }
   }

core/src/test/java/com/redis/vl/utils/rerank/CrossEncoderTokenizationTest.java

@@ -66,12 +66,6 @@ void testTokenizationMatchesPython() throws Exception {
           .isEqualTo(0);
     }
 
-    System.out.println("\n✓ Tokenization matches Python transformers");
-    System.out.println("  Query: " + query.substring(0, Math.min(50, query.length())));
-    System.out.println("  Document: " + doc.substring(0, Math.min(50, doc.length())));
-    System.out.println("  Token IDs (first 20): " + Arrays.toString(actualFirst20));
-    System.out.println("  Total tokens: " + inputIds.length);
-
     reranker.close();
   }
 }

notebooks/08_semantic_router.ipynb

@@ -599,16 +599,16 @@
       "  Reference ID: 149a9c9919c58534\n",
       "  Route: technology\n",
       "\n",
-      "  Reference: what are the latest advancements in AI?\n",
-      "  Reference ID: 851f51cce5a9ccfb\n",
+      "  Reference: new tech gadgets\n",
+      "  Reference ID: 7e4bca5853c1c329\n",
       "  Route: technology\n",
       "\n",
       "  Reference: tell me about the newest gadgets\n",
       "  Reference ID: 85cc73a1437df27c\n",
       "  Route: technology\n",
       "\n",
-      "  Reference: new tech gadgets\n",
-      "  Reference ID: 7e4bca5853c1c329\n",
+      "  Reference: what are the latest advancements in AI?\n",
+      "  Reference ID: 851f51cce5a9ccfb\n",
       "  Route: technology\n",
       "\n",
       "  Reference: latest AI trends\n",