Skip to content

Conversation

@utkarshgupta137
Copy link
Contributor

@utkarshgupta137 utkarshgupta137 commented May 8, 2022

Pull Request check-list

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

@codecov-commenter
Copy link

codecov-commenter commented May 8, 2022

Codecov Report

Merging #2171 (338438f) into master (f704281) will not change coverage.
The diff coverage is 91.66%.

@@           Coverage Diff           @@
##           master    #2171   +/-   ##
=======================================
  Coverage   92.00%   92.00%           
=======================================
  Files         108      108           
  Lines       27390    27390           
=======================================
  Hits        25199    25199           
  Misses       2191     2191           
Impacted Files Coverage Δ
redis/asyncio/cluster.py 89.24% <ø> (ø)
redis/backoff.py 59.57% <0.00%> (ø)
redis/commands/json/__init__.py 97.56% <ø> (ø)
redis/commands/search/field.py 98.57% <ø> (ø)
tests/test_asyncio/test_sentinel.py 99.32% <ø> (ø)
tests/test_command_parser.py 94.33% <0.00%> (ø)
tests/test_function.py 27.58% <ø> (ø)
tests/test_sentinel.py 99.31% <ø> (ø)
tests/test_commands.py 89.92% <87.50%> (ø)
redis/asyncio/connection.py 83.85% <100.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f704281...338438f. Read the comment docs.

@chayim chayim self-requested a review May 8, 2022 13:50
@WisdomPill
Copy link
Contributor

@chayim I supposed this can be merged :)

@utkarshgupta137
Copy link
Contributor Author

@dvora-h

@dvora-h dvora-h merged commit c54dfa4 into redis:master May 30, 2022
@utkarshgupta137 utkarshgupta137 deleted the black branch June 2, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants