Skip to content

Conversation

@nosammai
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Fix typo in argument that causes the dump command to fail with an exception using the asyncio client.

@dvora-h
Copy link
Collaborator

dvora-h commented Apr 3, 2022

@nosammai Nice catch, thanks for this! I just merge in the latest master to make sure all the tests pass and we can merge this PR.

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2022

Codecov Report

Merging #2070 (1d3d6f0) into master (876cafc) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2070      +/-   ##
==========================================
- Coverage   91.23%   91.22%   -0.01%     
==========================================
  Files         100      100              
  Lines       21361    21361              
==========================================
- Hits        19489    19487       -2     
- Misses       1872     1874       +2     
Impacted Files Coverage Δ
redis/asyncio/client.py 90.45% <0.00%> (-0.18%) ⬇️
redis/asyncio/connection.py 82.63% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 876cafc...1d3d6f0. Read the comment docs.

@dvora-h dvora-h added the bug Bug label Apr 3, 2022
@dvora-h dvora-h merged commit 51a4dd9 into redis:master Apr 4, 2022
@nosammai nosammai deleted the fix-disable-decode-aio branch April 4, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants