Skip to content

Conversation

@simonprickett
Copy link
Contributor

@simonprickett simonprickett commented Apr 12, 2022

Closes #201

Also added a test for all_pks() for HashModel as there wasn't one before.

@simonprickett simonprickett self-assigned this Apr 12, 2022
@simonprickett simonprickett added the bug Something isn't working label Apr 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2022

Codecov Report

Merging #202 (eefa5a9) into main (6453867) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
+ Coverage   77.30%   77.37%   +0.07%     
==========================================
  Files          12       12              
  Lines        1163     1167       +4     
==========================================
+ Hits          899      903       +4     
  Misses        264      264              
Flag Coverage Δ
unit 77.37% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aredis_om/model/model.py 86.38% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6453867...eefa5a9. Read the comment docs.

@simonprickett
Copy link
Contributor Author

The following example code now works:

from redis_om import JsonModel

class Entity(JsonModel):
    entity_id: str

for n in range(200):
    entity = Entity(
        entity_id = f"entity-{str(n)}"
    )

    entity.save()

print(list(Entity.all_pks()))

Output:

$ python testapp.py
['01G0H5VD1H33FRC7Q2494KECAZ', '01G0H5VD1Y28F8SGYHNP1YR2RC', '01G0H5VD2Q1ETQWYA6F7B9KR2P', '01G0H5VD0FQB6B6HPD3ZZNMCPE', '01G0H5VCZV369S7B3GQFZXTP16', '01G0H5VD2N0A233P5HAMDDA8NN', '01G0H5VD3X8NQZNMTJ6MHMFW16', '01G0H5VCYYG7QFQ7JMKNTXHMN6', '01G0H5VD5DKJ252A4F4JS2T43J', '01G0H5VCYK52V56PAC7HX5AMCB', '01G0H5VD3YWRWN570VN1QN52Y8', '01G0H5VCYTCV1SKMEW1R3E2JTM', '01G0H5VD5Y0AC46H37TQSPFZFQ', '01G0H5VCZBM6FY2KHCBQVHTPCR', '01G0H5VD3T8SN17VWM2RBHGV9T', '01G0H5VD0YT7N2HC3XDW6HWKVX', '01G0H5VD2HPHZBCBH5HABTZJCZ', '01G0H5VD16DNZJX4FT90HTD3SY', '01G0H5VD0B6NY52GRDPA7ZXGXC', '01G0H5VD4TVPZ7ZMDBAXXZFMY3', '01G0H5VD3QNTZR49FYYE0QFFAD', '01G0H5VD2R00Y6JTN3YK7Z7CHR', '01G0H5VD5PGEK02JAV2NSPM8YN', '01G0H5VD0NF564G4HNCQDAF3K2', '01G0H5VD4GPK095FJKNR4MNNC5', '01G0H5VD54SFNPQKGN9N7CBVGS', '01G0H5VD4XMQYXXV0MJJH5G66W', '01G0H5VD26ZTQ3CM9BK5JKBN7Y', '01G0H5VD4HPW6JQ7DSQKBD9FGD', '01G0H5VD47WEP8QRN3337NQE0D', '01G0H5VCZFDVY97QEGERK4FREN', '01G0H5VD2BGDEZRAGKRM9BS7NW', '01G0H5VD305WY6YDCDXDAKPER3', '01G0H5VD0VFFFM9CS5T378EFH6', '01G0H5VD5JDA6714FX12WP46N7', '01G0H5VD5QN9HBK71V6Z5AMXBX', '01G0H5VD1WZWPS7901CR412KAJ', '01G0H5VD17H11TFRMD6B3KRE09', '01G0H5VD00HGJQRM0BATDFQ4FQ', '01G0H5VD224ZXTR33JFQJ02G61', '01G0H5VD28Y70PS5MTDWX9ZC77', '01G0H5VCZNH7XF75CY8GX9CXV5', '01G0H5VCZH2MEVWNPFSN9M331N', '01G0H5VD45FFWTZN5SD3CGDYGZ', '01G0H5VD424970FGHCDFZ61B1M', '01G0H5VCYSRX114CH1DM3EPQY7', '01G0H5VCZ8QSFYBY4YY4E5H76P', '01G0H5VD2JHRRSWYFZYFH6P0FJ', '01G0H5VD1R46E695CQVBHP8AH1', '01G0H5VD254QBQWS28QWRZG6CN', '01G0H5VCZWWHEEAXGT6JN0GCTV', '01G0H5VD4JYYR4FMWTKR39H32Z', '01G0H5VCZ6WH2ZDKQ4GQC0WGMG', '01G0H5VCZ7XGJC70TJWWSJTKQ3', '01G0H5VD4NAWYMB1PB153PREWK', '01G0H5VD15FS7BPC0RV7XRVMMP', '01G0H5VD1K9TANCS6E9CRVK6E1', '01G0H5VD0AZXFM1DBDGZCW10T2', '01G0H5VD1ZZ69NQYK3M4VFSCC0', '01G0H5VD3V6RB1XMEPH95TE7AQ', '01G0H5VD0M0A787N8R4HGFMBXE', '01G0H5VD35T1BRSQRCE3JQEJ71', '01G0H5VD04A6RRW396XCVTNJTD', '01G0H5VD2CVHCEFMSQ058ASED8', '01G0H5VD4CN567RQESPK634EYC', '01G0H5VD13TPNWJPWZNHP3MCP9', '01G0H5VD4SJPNBQ8BAHBERBAHR', '01G0H5VD5777TRQTC416FXZ7ZS', '01G0H5VD5N1HHX2S2ZC000W7D6', '01G0H5VD103VJ9EB88RDZYREV8', '01G0H5VD5BR6DWEJD9N3GCJGN8', '01G0H5VCYJG8G31JE9Z5QHAEJ0', '01G0H5VD386J65QDNWMBMWGCE8', '01G0H5VD553Q6A5REP2R6F2Z5Z', '01G0H5VD1ADX2K7HAHR1PH967V', '01G0H5VD408S1AYE4QMCHSPQPZ', '01G0H5VD1G66XBBSVEZXM57QE7', '01G0H5VD2FGSK9HSF9QBFKN9M1', '01G0H5VD0J7KQGC6XE6H4705VR', '01G0H5VCZ199WFB09M326VJSHJ', '01G0H5VD5KMGZ0AP3MP4ZQBN4P', '01G0H5VD4FVP7FJQCZ475AQGJV', '01G0H5VD3493G134J4VPWYVB0V', '01G0H5VD2G3HTBYS4SWS3WJYCB', '01G0H5VD11P6N7DQTDQWQGF1WP', '01G0H5VCZ9GXDRAWJQAGXXPPGE', '01G0H5VCZYCG26N1BQB035E47N', '01G0H5VCZNQEPT53J3819FX458', '01G0H5VD0PE2FWJ7HZA10003ER', '01G0H5VD5XZHXY7T6RJV25C487', '01G0H5VD4A3TDZXRD687X31KXD', '01G0H5VD4YQSET32SBHYKKGZM7', '01G0H5VCZR7E1ZBSBNBB0SB4NQ', '01G0H5VD5P4J73VQ9VZGP7Z2B2', '01G0H5VCYQRTXQYNNT0T82MF6B', '01G0H5VD4EW10SS39GMCDXP4AP', '01G0H5VCZP12G9HA0PQHY9J89N', '01G0H5VCZMNFVS8094JQ3DSY03', '01G0H5VD0TSWN997AP9YJ8XP92', '01G0H5VCYPDBW85WK5MXS1FWTX', '01G0H5VD3MWBZY3CZXDEV70TQK', '01G0H5VD3JVWS7VEPT3HBZHVVQ', '01G0H5VD2E3E6YKH1AVX9Z1277', '01G0H5VD414BNEG2VP3SADJB1J', '01G0H5VD2XRAVAN3WMJRVAE27S', '01G0H5VD3F20SDFCBV0HDCYZ04', '01G0H5VD4VK8F3WDPWYPQEJ0PF', '01G0H5VCZG4C3S2ZAWFHW6NRR1', '01G0H5VCZAW3Y0S2RP5JP5GHC4', '01G0H5VD52A1TSH3H3A608CG7G', '01G0H5VD0XKTJAHDNG6B5T86ZV', '01G0H5VD3A162QWP29Y9CPR4PP', '01G0H5VCYWZS99035J14P9X9K8', '01G0H5VD5MPP2686APA8YWJFNX', '01G0H5VD195YCF2YT4M25NFJPG', '01G0H5VD24N07JHNNBJT7NT2WS', '01G0H5VD2ZCR09K92P9419NZGE', '01G0H5VD5TNWV168T95FQN3FPQ', '01G0H5VD2YBBYZZCJPX0FQ0R0C', '01G0H5VD430ZNY6NHJC1M5KCXG', '01G0H5VD1NVPJ03EZMEMH580A7', '01G0H5VCZD7W59T6N03W3PSN8E', '01G0H5VD51PRGQR6VRW1Q6F00G', '01G0H5VCZ42E4EJJ4TFB870K06', '01G0H5VD4PYASAVRVG741RWSJT', '01G0H5VD0CCY5V33H42YTWEMCQ', '01G0H5VD36P2HHR1MNZKARQ6Z3', '01G0H5VD1DX5MMNQYZ53CENHKF', '01G0H5VD2TYHESZFKPREXKMYMD', '01G0H5VD595G6Z6JMDHF2PFE0Q', '01G0H5VD1FXZ8NHFE1W7XBD8AY', '01G0H5VD06J0X5HEH542BNPC1Z', '01G0H5VD3W18VME7X1KX1AYCN4', '01G0H5VD07SHTX19PKWWQ66TA7', '01G0H5VD147SB37WRA3AHSRB92', '01G0H5VD3DEP6R75TCN643Q9G2', '01G0H5VCZEC1D4P7ADCK0GXGDE', '01G0H5VD12E7YHW49EZSXAEATW', '01G0H5VD0VTNC5SHHW6RXFFW8D', '01G0H5VD4ZEB2PFSSBNR744AH4', '01G0H5VD5WN5HFBAHGB38EHN15', '01G0H5VD08YG5Y8JH12R25QJ58', '01G0H5VD01E3636TWQ8GWQ50JS', '01G0H5VD1S0V78ABHNRSGBPNKA', '01G0H5VD48A973S705B1TXF0R7', '01G0H5VD3NNMD8YR2R4MAKPBWA', '01G0H5VD2SCMA78Y6HY08M8E7R', '01G0H5VCYFKFDD3EBBWK1A5GAG', '01G0H5VCZCWB1ZFB3E3FKH4JTX', '01G0H5VD4K44YDJX5V3HETD3AJ', '01G0H5VCZ2T9XT4NVGSN0D7RJ5', '01G0H5VCZXNM0CJV6MMJKSK89X', '01G0H5VCZQVNBHAQ49KZ05G3GC', '01G0H5VCYAJAQ7MZ1QMPKX821X', '01G0H5VD0W40T80QSC52W4Q1Y3', '01G0H5VD2MC4FADQB5P58RXF1R', '01G0H5VCZJJ495J9KNYTRXRD0F', '01G0H5VD5EXA3TDSBVV0WDB3HS', '01G0H5VD0HQY46QN739KVRAVK6', '01G0H5VCZHMX9DVZ3EAAJAPWFD', '01G0H5VD46GXZASQ9FAZW6PP4N', '01G0H5VD2D37454BGX22VBKGXS', '01G0H5VCYGCHRZY27F89J2KN21', '01G0H5VD3H0NGJPEQCSRX4V1T8', '01G0H5VD4QW94WA81QFHSJX1N8', '01G0H5VD0ZF257T4AZR6EXC798', '01G0H5VD3SKC73JQ3CBSKF2G0Q', '01G0H5VD5FFTQ7E0C0FVVNQ6VG', '01G0H5VD2N83H44FT5CT7HT57D', '01G0H5VD2KZX3ZYREE41SYKBY0', '01G0H5VD0SWB4XC1Z0P3PTKHTJ', '01G0H5VCYMB5103PSRJAZPFVW9', '01G0H5VD5RQTEKX8N0ST60X8F1', '01G0H5VD1VV93G53J9J3RVXCPR', '01G0H5VCYX11QDH0AKHBA4ZC0W', '01G0H5VCYBCT0KX557CE92AWFA', '01G0H5VD5H5BFW70D437GMN6XH', '01G0H5VD449DF68TS366Z1CGWJ', '01G0H5VD03QHJDG99X5YY4CJEC', '01G0H5VD2VKW54ATEBVWEZB8RQ', '01G0H5VD0EXPYS9P0S9ZD4NC9C', '01G0H5VD21527THBBY4GKV4KYB', '01G0H5VCYD3SENGSH0J1STK1JM', '01G0H5VD48X09VMTWCGXJ4R0QM', '01G0H5VCZ5Z6T2HCG8KNNNE23Z', '01G0H5VD29FDSJ1V90061DA19Q', '01G0H5VD5VMGRNSFMW7TEJ0KB8', '01G0H5VD4959YHN3NKNZYZV74S', '01G0H5VD1QBMR5MZTMN8ZAKRGR', '01G0H5VD3CV5KC1Q91Y46AHP89', '01G0H5VD32G31TX3JT10WG4K5Y', '01G0H5VD0R40QJPDHSB0GACP9M', '01G0H5VD4D38Q5HDY080J9PXY0', '01G0H5VCZTNM09FTGTZ474PJP8', '01G0H5VCZK36YPKPJNKT3W6S5H', '01G0H5VD58H2SQXBV7YAA0SB25', '01G0H5VCZ074MXEVJZZGKW6P6J', '01G0H5VD5ST2673S5QZAAAZRYR', '01G0H5VCZDTB7TAK6CHDJH330C', '01G0H5VD1C2CC1CM255B93AT04']
```

@simonprickett simonprickett merged commit dc00777 into main Apr 13, 2022
@simonprickett simonprickett deleted the add-all-pks-for-json-model branch April 13, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JsonModel should have an all_pks() method.

3 participants