ACL DELUSER does not work correctly with UTF-8 Japanese characters #3178 (#3179) (#3188)

* Parse strings as UTF-8

* Chores : Reduce stale issues time, fix benchmark code, remove debug messages for testcontainers

* Change method name

* Update src/test/java/io/lettuce/core/commands/AclCommandIntegrationTests.java



* Remove unneeded imports

---------

Co-authored-by: ggivo <[email protected]>

Author: tishun

.github/workflows/stale-issues.yml

@@ -17,8 +17,8 @@ jobs:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
           stale-issue-message: 'If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 30 days this issue will be closed.'
           stale-pr-message: 'Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.'
-          days-before-stale: 365
-          days-before-close: 30
+          days-before-stale: 30
+          days-before-close: 14
           stale-issue-label: "status: feedback-reminder"
           stale-pr-label: "status: feedback-reminder"
           operations-per-run: 10

src/main/java/io/lettuce/core/output/ClaimedMessagesOutput.java

@@ -70,12 +70,12 @@ public ClaimedMessagesOutput(RedisCodec<K, V> codec, K stream, boolean justId) {
     @Override
     public void set(ByteBuffer bytes) {
         if (startId == null) {
-            startId = decodeAscii(bytes);
+            startId = decodeString(bytes);
             return;
         }
 
         if (id == null) {
-            id = decodeAscii(bytes);
+            id = decodeString(bytes);
             return;
         }
 

src/main/java/io/lettuce/core/output/CommandOutput.java

@@ -20,6 +20,7 @@
 package io.lettuce.core.output;
 
 import java.nio.ByteBuffer;
+import java.nio.charset.StandardCharsets;
 
 import io.lettuce.core.codec.RedisCodec;
 import io.lettuce.core.internal.LettuceAssert;
@@ -139,7 +140,7 @@ public void set(boolean value) {
      * @param error Error message.
      */
     public void setError(ByteBuffer error) {
-        this.error = decodeAscii(error);
+        this.error = decodeString(error);
     }
 
     /**
@@ -179,16 +180,8 @@ public void complete(int depth) {
         // nothing to do by default
     }
 
-    protected String decodeAscii(ByteBuffer bytes) {
-        if (bytes == null) {
-            return null;
-        }
-
-        char[] chars = new char[bytes.remaining()];
-        for (int i = 0; i < chars.length; i++) {
-            chars[i] = (char) bytes.get();
-        }
-        return new String(chars);
+    protected String decodeString(ByteBuffer bytes) {
+        return bytes == null ? null : StandardCharsets.UTF_8.decode(bytes).toString();
     }
 
     @Override

src/main/java/io/lettuce/core/output/DoubleListOutput.java

@@ -46,7 +46,7 @@ public DoubleListOutput(RedisCodec<K, V> codec) {
 
     @Override
     public void set(ByteBuffer bytes) {
-        output.add(bytes != null ? parseDouble(decodeAscii(bytes)) : null);
+        output.add(bytes != null ? parseDouble(decodeString(bytes)) : null);
     }
 
     @Override

src/main/java/io/lettuce/core/output/DoubleOutput.java

@@ -40,7 +40,7 @@ public DoubleOutput(RedisCodec<K, V> codec) {
 
     @Override
     public void set(ByteBuffer bytes) {
-        output = (bytes == null) ? null : parseDouble(decodeAscii(bytes));
+        output = (bytes == null) ? null : parseDouble(decodeString(bytes));
     }
 
     @Override

src/main/java/io/lettuce/core/output/EnumSetOutput.java

@@ -51,7 +51,7 @@ public void set(ByteBuffer bytes) {
             return;
         }
 
-        E enumConstant = resolve(enumValuePreprocessor.apply(decodeAscii(bytes)));
+        E enumConstant = resolve(enumValuePreprocessor.apply(decodeString(bytes)));
 
         if (enumConstant == null) {
             return;

src/main/java/io/lettuce/core/output/GeoCoordinatesListOutput.java

@@ -39,7 +39,7 @@ public void set(ByteBuffer bytes) {
             return;
         }
 
-        double value = (bytes == null) ? 0 : parseDouble(decodeAscii(bytes));
+        double value = (bytes == null) ? 0 : parseDouble(decodeString(bytes));
         set(value);
     }
 

src/main/java/io/lettuce/core/output/GeoCoordinatesValueListOutput.java

@@ -40,7 +40,7 @@ public void set(ByteBuffer bytes) {
             return;
         }
 
-        double value = parseDouble(decodeAscii(bytes));
+        double value = parseDouble(decodeString(bytes));
         set(value);
     }
 

src/main/java/io/lettuce/core/output/GeoWithinListOutput.java

@@ -73,7 +73,7 @@ public void set(ByteBuffer bytes) {
             return;
         }
 
-        double value = (bytes == null) ? 0 : parseDouble(decodeAscii(bytes));
+        double value = (bytes == null) ? 0 : parseDouble(decodeString(bytes));
         set(value);
     }
 

src/main/java/io/lettuce/core/output/JsonTypeListOutput.java

@@ -35,7 +35,7 @@ public void set(ByteBuffer bytes) {
             multi(1);
         }
 
-        output.add(JsonType.fromString(decodeAscii(bytes)));
+        output.add(JsonType.fromString(decodeString(bytes)));
     }
 
     @Override