Skip to content

Commit eddeb88

Browse files
committed
revert
1 parent 834dd4f commit eddeb88

File tree

9 files changed

+9
-24
lines changed

9 files changed

+9
-24
lines changed

src/NRedisStack/Graph/DataTypes/Edge.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ public class Edge : GraphEntity
2626
/// <value></value>
2727
public long Destination { get; set; }
2828

29+
// TODO: check if this is needed:
2930
/// <summary>
3031
/// Overriden from the base `Equals` implementation. In addition to the expected behavior of checking
3132
/// reference equality, we'll also fall back and check to see if the: Source, Destination, and RelationshipType

src/NRedisStack/Graph/DataTypes/GraphEntity.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ public abstract class GraphEntity
1212

1313
public IDictionary<string, object> PropertyMap = new Dictionary<string, object>();
1414

15+
// TODO: check if this is needed:
1516
/// <summary>
1617
/// Overriden Equals that considers the equality of the entity ID as well as the equality of the
1718
/// properties that each entity has.

src/NRedisStack/Graph/DataTypes/Node.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ public Node()
1616
Labels = new List<string>();
1717
}
1818

19+
// TODO: check if this is needed:
1920
/// <summary>
2021
/// Overriden member that checks to see if the names of the labels of a node are equal
2122
/// (in addition to base `Equals` functionality).

src/NRedisStack/Graph/DataTypes/Path.cs

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,7 @@ public Path(IList<Node> nodes, IList<Edge> edges)
2020
Edges = new ReadOnlyCollection<Edge>(edges);
2121
}
2222

23-
24-
/// <summary>
25-
/// How many edges exist on this path.
26-
/// </summary>
27-
public int Length => Edges.Count;
28-
23+
// TODO: check if this is needed:
2924
/// <summary>
3025
/// Overriden `Equals` method that will consider the equality of the Nodes and Edges between two paths.
3126
/// </summary>
@@ -73,6 +68,7 @@ public override int GetHashCode()
7368
}
7469
}
7570

71+
// TODO: check if this is needed:
7672
/// <summary>
7773
/// Overridden `ToString` method that will emit a string based on the string values of the nodes and edges
7874
/// on the path.

src/NRedisStack/Graph/GraphCommandBuilder.cs

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,6 @@ public static class GraphCommandBuilder
88
{
99
internal static readonly object CompactQueryFlag = "--COMPACT";
1010

11-
/// <inheritdoc/>
12-
public static SerializedCommand Query(string graphName, string query, IDictionary<string, object> parameters, long? timeout = null)
13-
{
14-
var preparedQuery = PrepareQuery(query, parameters);
15-
16-
return Query(graphName, preparedQuery, timeout);
17-
}
18-
1911
/// <inheritdoc/>
2012
public static SerializedCommand Query(string graphName, string query, long? timeout = null)
2113
{
@@ -25,14 +17,6 @@ public static SerializedCommand Query(string graphName, string query, long? time
2517
return new SerializedCommand(GRAPH.QUERY, args);
2618
}
2719

28-
/// <inheritdoc/>
29-
public static SerializedCommand RO_Query(string graphName, string query, IDictionary<string, object> parameters, long? timeout = null)
30-
{
31-
var preparedQuery = PrepareQuery(query, parameters);
32-
33-
return RO_Query(graphName, preparedQuery, timeout);
34-
}
35-
3620
/// <inheritdoc/>
3721
public static SerializedCommand RO_Query(string graphName, string query, long? timeout = null)
3822
{

src/NRedisStack/Graph/Header.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ internal Header(RedisResult result)
4141
}
4242
}
4343

44+
// TODO: check if this is needed:
4445
public override bool Equals(object? obj)
4546
{
4647
if (obj == null) return this == null;

src/NRedisStack/Graph/Point.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ public Point(List<double> values)
2323
this.longitude = values[1];
2424
}
2525

26+
// TODO: check if this is needed:
2627
public override bool Equals(object? obj)
2728
{
2829
if (obj == null) return this == null;

src/NRedisStack/Graph/Record.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ internal Record(List<string> header, List<object> values)
5858
/// </summary>
5959
public int Size => Header.Count;
6060

61+
// TODO: check if this is needed:
6162
public override bool Equals(object? obj)
6263
{
6364
if (obj == null) return this == null;

tests/NRedisStack.Tests/Search/SearchTests.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -672,7 +672,7 @@ public void AlterAdd()
672672
Assert.Equal(100, info.NumDocs);
673673
Assert.Equal("300", info.MaxDocId);
674674
Assert.Equal(102, info.NumTerms);
675-
Assert.Equal(800, info.NumRecords);
675+
Assert.Equal(800, info.NumRecords); // TODO: why is this 800?
676676
Assert.Equal(0.004291534423828125, info.InvertedSzMebibytes);
677677
Assert.Equal(0, info.VectorIndexSzMebibytes);
678678
Assert.Equal(208, info.TotalInvertedIndexBlocks);
@@ -691,7 +691,6 @@ public void AlterAdd()
691691
Assert.Equal(4, info.NumberOfUses);
692692
Assert.Equal(7, info.GcStats.Count);
693693
Assert.Equal(4, info.CursorStats.Count);
694-
695694
}
696695

697696
[Fact]

0 commit comments

Comments
 (0)