Increasing code coverage (#56)

* Cover FTSearch

* delete IndexIndexDataType

* add TestQueryCommandBuilder

* more cover to equal & ToString of graph data types

* cover more equal/ToString/Hash functions

* fix test

* fix infinity

* start covering command builder

* Add TestInsertArgsError

* Cover Reducer

* Cover Document

* Cover limit

* Delete ExplainScore

* Cover CuckooCommandBuilder

* Cover TopK

* Cover Search Query

* Cover All search Query

* Cover search schema

* Cover FT._List

* mark as Comment CallProcedureReadOnly

* בםצצקמא ValueToStringNoQuotes

* cover more from AddVectorField

* More cover to timeSeries

* Comment TsDuplicatePolicy AsPolicy

* delete unnecessary code from graph

* delete unnecessary code from search

* delete unnecessary code from TimeSeries

Author: shacharPash

src/NRedisStack/Graph/DataTypes/Edge.cs

@@ -26,7 +26,6 @@ public class Edge : GraphEntity
         /// <value></value>
         public long Destination { get; set; }
 
-        // TODO: check if this is needed:
         /// <summary>
         /// Overriden from the base `Equals` implementation. In addition to the expected behavior of checking
         /// reference equality, we'll also fall back and check to see if the: Source, Destination, and RelationshipType

src/NRedisStack/Graph/DataTypes/GraphEntity.cs

@@ -12,7 +12,6 @@ public abstract class GraphEntity
 
         public IDictionary<string, object> PropertyMap = new Dictionary<string, object>();
 
-        // TODO: check if this is needed:
         /// <summary>
         /// Overriden Equals that considers the equality of the entity ID as well as the equality of the
         /// properties that each entity has.
@@ -49,7 +48,7 @@ public override int GetHashCode()
 
                 hash = hash * 31 + Id.GetHashCode();
 
-                foreach(var prop in PropertyMap)
+                foreach (var prop in PropertyMap)
                 {
                     hash = hash * 31 + prop.Key.GetHashCode();
                     hash = hash * 31 + prop.Value.GetHashCode();
@@ -59,23 +58,6 @@ public override int GetHashCode()
             }
         }
 
-        /// <summary>
-        /// Overriden ToString that emits a string containing the ID and property map of the entity.
-        /// </summary>
-        /// <returns></returns>
-        public override string ToString()
-        {
-            var sb = new StringBuilder();
-
-            sb.Append("GraphEntity{id=");
-            sb.Append(Id);
-            sb.Append(", propertyMap=");
-            sb.Append(PropertyMap);
-            sb.Append('}');
-
-            return sb.ToString();
-        }
-
         public string PropertyMapToString()
         {
             var sb = new StringBuilder();

src/NRedisStack/Graph/DataTypes/Node.cs

@@ -16,7 +16,6 @@ public Node()
             Labels = new List<string>();
         }
 
-        // TODO: check if this is needed:
         /// <summary>
         /// Overriden member that checks to see if the names of the labels of a node are equal
         /// (in addition to base `Equals` functionality).

src/NRedisStack/Graph/DataTypes/Path.cs

@@ -20,7 +20,6 @@ public Path(IList<Node> nodes, IList<Edge> edges)
             Edges = new ReadOnlyCollection<Edge>(edges);
         }
 
-        // TODO: check if this is needed:
         /// <summary>
         /// Overriden `Equals` method that will consider the equality of the Nodes and Edges between two paths.
         /// </summary>
@@ -68,7 +67,6 @@ public override int GetHashCode()
             }
         }
 
-        // TODO: check if this is needed:
         /// <summary>
         /// Overridden `ToString` method that will emit a string based on the string values of the nodes and edges
         /// on the path.

src/NRedisStack/Graph/GraphCacheList.cs

@@ -52,15 +52,4 @@ private void GetProcedureInfo()
         protected virtual ResultSet CallProcedure() =>
             graph.CallProcedure(GraphName, Procedure);
     }
-
-    internal class ReadOnlyGraphCacheList : GraphCacheList
-    {
-        internal ReadOnlyGraphCacheList(string graphName, string procedure, GraphCommands redisGraph) :
-            base(graphName, procedure, redisGraph)
-        {
-        }
-
-        protected override ResultSet CallProcedure() =>
-            graph.CallProcedureReadOnly(GraphName, Procedure);
-    }
 }

src/NRedisStack/Graph/GraphCommandBuilder.cs

@@ -1,6 +1,5 @@
 using NRedisStack.Literals;
 using NRedisStack.RedisStackCommands;
-using static NRedisStack.Graph.RedisGraphUtilities;
 
 namespace NRedisStack
 {

src/NRedisStack/Graph/GraphCommands.cs

@@ -97,7 +97,7 @@ public async Task<ResultSet> RO_QueryAsync(string graphName, string query, long?
         internal static readonly Dictionary<string, List<string>> EmptyKwargsDictionary =
             new Dictionary<string, List<string>>();
 
-        // TODO: Check if needed
+        // TODO: Check if this is needed:
         /// <inheritdoc/>
         public ResultSet CallProcedure(string graphName, string procedure) =>
         CallProcedure(graphName, procedure, Enumerable.Empty<string>(), EmptyKwargsDictionary);
@@ -147,32 +147,6 @@ public async Task<ResultSet> DeleteAsync(string graphName)
             return processedResult;
         }
 
-        // TODO: Check if this (CallProcedure) is needed
-        /// <inheritdoc/>
-        public ResultSet CallProcedureReadOnly(string graphName, string procedure) =>
-        CallProcedureReadOnly(graphName, procedure, Enumerable.Empty<string>(), EmptyKwargsDictionary);
-
-        /// <inheritdoc/>
-        public ResultSet CallProcedureReadOnly(string graphName, string procedure, IEnumerable<string> args) =>
-        CallProcedureReadOnly(graphName, procedure, args, EmptyKwargsDictionary);
-
-        /// <inheritdoc/>
-        public ResultSet CallProcedureReadOnly(string graphName, string procedure, IEnumerable<string> args, Dictionary<string, List<string>> kwargs)
-        {
-            args = args.Select(a => QuoteString(a));
-
-            var queryBody = new StringBuilder();
-
-            queryBody.Append($"CALL {procedure}({string.Join(",", args)})");
-
-            if (kwargs.TryGetValue("y", out var kwargsList))
-            {
-                queryBody.Append(string.Join(",", kwargsList));
-            }
-
-            return RO_Query(graphName, queryBody.ToString());
-        }
-
         /// <inheritdoc/>
         public IReadOnlyList<string> Explain(string graphName, string query)
         {

src/NRedisStack/Graph/Header.cs

@@ -20,7 +20,7 @@ public enum ResultSetColumnTypes
         /// <summary>
         /// Collection of the schema types present in the header.
         /// </summary>
-        // [Obsolete("SchemaType is no longer supported after RedisGraph 2.1 and will always return COLUMN_SCALAR")] // TODO: it's correct?
+        [Obsolete("SchemaType is no longer supported after RedisGraph 2.1 and will always return COLUMN_SCALAR")]
         public List<ResultSetColumnTypes> SchemaTypes { get; }
 
         /// <summary>
@@ -41,7 +41,6 @@ internal Header(RedisResult result)
             }
         }
 
-        // TODO: check if this is needed:
         public override bool Equals(object? obj)
         {
             if (obj == null) return this == null;

src/NRedisStack/Graph/IGraphCommands.cs

@@ -133,34 +133,6 @@ public interface IGraphCommands
         /// <remarks><seealso href="https://redis.io/commands/graph.delete"/></remarks>
         Task<ResultSet> DeleteAsync(string graphName);
 
-        // TODO: Check if this (CallProcedure) is needed
-        /// <summary>
-        /// Call a saved procedure against a read-only node.
-        /// </summary>
-        /// <param name="graphName">The graph containing the saved procedure.</param>
-        /// <param name="procedure">The procedure name.</param>
-        /// <returns>A result set.</returns>
-        ResultSet CallProcedureReadOnly(string graphName, string procedure);
-
-        /// <summary>
-        /// Call a saved procedure with parameters against a read-only node.
-        /// </summary>
-        /// <param name="graphName">The graph containing the saved procedure.</param>
-        /// <param name="procedure">The procedure name.</param>
-        /// <param name="args">A collection of positional arguments.</param>
-        /// <returns>A result set.</returns>
-        ResultSet CallProcedureReadOnly(string graphName, string procedure, IEnumerable<string> args);
-
-        /// <summary>
-        /// Call a saved procedure with parameters against a read-only node.
-        /// </summary>
-        /// <param name="graphName">The graph containing the saved procedure.</param>
-        /// <param name="procedure">The procedure name.</param>
-        /// <param name="args">A collection of positional arguments.</param>
-        /// <param name="kwargs">A collection of keyword arguments.</param>
-        /// <returns>A result set.</returns>
-        ResultSet CallProcedureReadOnly(string graphName, string procedure, IEnumerable<string> args, Dictionary<string, List<string>> kwargs);
-
         /// <summary>
         /// Constructs a query execution plan but does not run it. Inspect this execution plan to better understand how your
         /// query will get executed.

src/NRedisStack/Graph/Point.cs

@@ -23,7 +23,6 @@ public Point(List<double> values)
             this.longitude = values[1];
         }
 
-        // TODO: check if this is needed:
         public override bool Equals(object? obj)
         {
             if (obj == null) return this == null;