Add More Coverage (#54)

* Add FTCreateParams coverage

* chagne payload to string

* Add cover to graph delete

* cover test info

* add test to cover load and load all

* comment SortByAsc SortByDesc

* comment AggregationRequest SerializeRedisArgs

* Add test to cover numeric and geo filters

* Add test to cover schema Fields

* revert

* Add test to cover Equals methods in graph

* fix alterAdd test

* add info to TopK test

* local codecov

* comment ToHashEntry

* Change AlterAdd test

* Cover CF.INFO fields

* Cover TDigest.INFO fields

* comment ToFtInfoAsDictionary

* add cover to ArrPopAsync

* Add cover to json get command

Author: shacharPash

.gitignore

@@ -396,4 +396,7 @@ FodyWeavers.xsd
 
 # JetBrains Rider
 *.sln.iml
-.idea
+.idea
+tests/NRedisStack.Tests/lcov.net7.0.info
+tests/NRedisStack.Tests/lcov.net6.0.info
+tests/NRedisStack.Tests/lcov.info

.vscode/settings.json

@@ -1,2 +1,4 @@
 {
+    "dotnet-test-explorer.testArguments": "/p:CollectCoverage=true /p:CoverletOutputFormat=lcov /p:CoverletOutput=./lcov.info",
+    "dotnet-test-explorer.testProjectPath": "**/*NRedisStack.Tests.csproj"
 }

.vscode/tasks.json

@@ -36,6 +36,24 @@
                 "${workspaceFolder}/tests/NRedisStack.Tests/NRedisStack.Tests.csproj"
             ],
             "problemMatcher": "$msCompile"
+        },
+        {
+            "label": "test",
+            "dependsOn": [],
+            "command": "dotnet",
+            "type": "process",
+            "args": [
+                "test",
+                "${workspaceFolder}/tests/NRedisStack.Tests/NRedisStack.Tests.csproj",
+                "/p:CollectCoverage=true",
+                "/p:CoverletOutputFormat=lcov",
+                "/p:CoverletOutput=./lcov.info"
+            ],
+            "problemMatcher": "$msCompile",
+            "group": {
+                "kind": "test",
+                "isDefault": true
+            }
         }
     ]
 }

src/NRedisStack/CuckooFilter/DataTypes/CuckooInformation.cs

@@ -8,25 +8,25 @@ public class CuckooInformation
     {
         public long Size { get; private set; }
         public long NumberOfBuckets { get; private set; }
-        public long NumberOfFilter { get; private set; }
+        public long NumberOfFilters { get; private set; }
         public long NumberOfItemsInserted { get; private set; }
         public long NumberOfItemsDeleted { get; private set; }
         public long BucketSize { get; private set; }
         public long ExpansionRate { get; private set; }
-        public long MaxIteration { get; private set; }
+        public long MaxIterations { get; private set; }
 
         internal CuckooInformation(long size, long numberOfBuckets, long numberOfFilter,
                                    long numberOfItemsInserted, long numberOfItemsDeleted,
                                    long bucketSize, long expansionRate, long maxIteration)
         {
             Size = size;
             NumberOfBuckets = numberOfBuckets;
-            NumberOfFilter = numberOfFilter;
+            NumberOfFilters = numberOfFilter;
             NumberOfItemsInserted = numberOfItemsInserted;
             NumberOfItemsDeleted = numberOfItemsDeleted;
             BucketSize = bucketSize;
             ExpansionRate = expansionRate;
-            MaxIteration = maxIteration;
+            MaxIterations = maxIteration;
         }
     }
 }

src/NRedisStack/Graph/DataTypes/Edge.cs

@@ -26,6 +26,7 @@ public class Edge : GraphEntity
         /// <value></value>
         public long Destination { get; set; }
 
+        // TODO: check if this is needed:
         /// <summary>
         /// Overriden from the base `Equals` implementation. In addition to the expected behavior of checking
         /// reference equality, we'll also fall back and check to see if the: Source, Destination, and RelationshipType

src/NRedisStack/Graph/DataTypes/GraphEntity.cs

@@ -12,6 +12,7 @@ public abstract class GraphEntity
 
         public IDictionary<string, object> PropertyMap = new Dictionary<string, object>();
 
+        // TODO: check if this is needed:
         /// <summary>
         /// Overriden Equals that considers the equality of the entity ID as well as the equality of the
         /// properties that each entity has.

src/NRedisStack/Graph/DataTypes/Node.cs

@@ -16,6 +16,7 @@ public Node()
             Labels = new List<string>();
         }
 
+        // TODO: check if this is needed:
         /// <summary>
         /// Overriden member that checks to see if the names of the labels of a node are equal
         /// (in addition to base `Equals` functionality).

src/NRedisStack/Graph/DataTypes/Path.cs

@@ -20,12 +20,7 @@ public Path(IList<Node> nodes, IList<Edge> edges)
             Edges = new ReadOnlyCollection<Edge>(edges);
         }
 
-
-        /// <summary>
-        /// How many edges exist on this path.
-        /// </summary>
-        public int Length => Edges.Count;
-
+        // TODO: check if this is needed:
         /// <summary>
         /// Overriden `Equals` method that will consider the equality of the Nodes and Edges between two paths.
         /// </summary>
@@ -73,6 +68,7 @@ public override int GetHashCode()
             }
         }
 
+        // TODO: check if this is needed:
         /// <summary>
         /// Overridden `ToString` method that will emit a string based on the string values of the nodes and edges
         /// on the path.

src/NRedisStack/Graph/GraphCommandBuilder.cs

@@ -8,14 +8,6 @@ public static class GraphCommandBuilder
     {
         internal static readonly object CompactQueryFlag = "--COMPACT";
 
-        /// <inheritdoc/>
-        public static SerializedCommand Query(string graphName, string query, IDictionary<string, object> parameters, long? timeout = null)
-        {
-            var preparedQuery = PrepareQuery(query, parameters);
-
-            return Query(graphName, preparedQuery, timeout);
-        }
-
         /// <inheritdoc/>
         public static SerializedCommand Query(string graphName, string query, long? timeout = null)
         {
@@ -25,14 +17,6 @@ public static SerializedCommand Query(string graphName, string query, long? time
             return new SerializedCommand(GRAPH.QUERY, args);
         }
 
-        /// <inheritdoc/>
-        public static SerializedCommand RO_Query(string graphName, string query, IDictionary<string, object> parameters, long? timeout = null)
-        {
-            var preparedQuery = PrepareQuery(query, parameters);
-
-            return RO_Query(graphName, preparedQuery, timeout);
-        }
-
         /// <inheritdoc/>
         public static SerializedCommand RO_Query(string graphName, string query, long? timeout = null)
         {

src/NRedisStack/Graph/GraphCommands.cs

@@ -18,16 +18,6 @@ public GraphCommands(IDatabase db)
 
         private readonly IDictionary<string, GraphCache> _graphCaches = new Dictionary<string, GraphCache>();
 
-        private GraphCache GetGraphCache(string graphName)
-        {
-            if (!_graphCaches.ContainsKey(graphName))
-            {
-                _graphCaches.Add(graphName, new GraphCache(graphName, this));
-            }
-
-            return _graphCaches[graphName];
-        }
-
         /// <inheritdoc/>
         public ResultSet Query(string graphName, string query, IDictionary<string, object> parameters, long? timeout = null)
         {