Cleanup (#36)

* Cleanup

* Fix TestRankCommands

Author: shacharPash

src/NRedisStack/Search/AggregationRequest.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Collections.Generic;
 using System.Text;
+using NRedisStack.Literals;
 // using NRediSearch.Aggregation.Reducers;
 using StackExchange.Redis;
 
@@ -125,7 +126,7 @@ public AggregationRequest GroupBy(Group group)
 
         public AggregationRequest Filter(string expression)
         {
-            args.Add("FILTER");
+            args.Add(SearchArgs.FILTER);
             args.Add(expression);
             return this;
         }

src/NRedisStack/Search/Query.cs

@@ -1,5 +1,6 @@
 using System.Collections.Generic;
 using System.Globalization;
+using NRedisStack.Literals;
 using NRedisStack.Search;
 using StackExchange.Redis;
 
@@ -45,7 +46,7 @@ public NumericFilter(string property, double min, double max) : this(property, m
 
             internal override void SerializeRedisArgs(List<object> args)
             {
-                static RedisValue FormatNum(double num, bool exclude) //TODO: understand this:
+                static RedisValue FormatNum(double num, bool exclude)
                 {
                     if (!exclude || double.IsInfinity(num))
                     {
@@ -54,7 +55,7 @@ static RedisValue FormatNum(double num, bool exclude) //TODO: understand this:
                     // need to add leading bracket
                     return "(" + num.ToString("G17", NumberFormatInfo.InvariantInfo);
                 }
-                args.Add("FILTER");
+                args.Add(SearchArgs.FILTER);
                 args.Add(Property);
                 args.Add(FormatNum(min, exclusiveMin));
                 args.Add(FormatNum(max, exclusiveMax));
@@ -357,7 +358,7 @@ internal void SerializeRedisArgs(List<object> args)
                 args.Add(_returnFields.Length);
                 args.AddRange(_returnFields);
             }
-            else if (_returnFieldsNames?.Length > 0) // TODO: understad this
+            else if (_returnFieldsNames?.Length > 0)
             {
                 args.Add("RETURN");
                 int returnCountIndex = args.Count;

src/NRedisStack/Search/SearchCommands.cs

@@ -213,7 +213,7 @@ public async Task<bool> AlterAsync(string index, Schema schema, bool skipInitial
         public Dictionary<string, string> ConfigGet(string option)
         {
             var result = _db.Execute(FT.CONFIG, "GET", option);
-            return result.ToConfigDictionary(); // TODO: fix all tests to be like this
+            return result.ToConfigDictionary();
         }
 
         /// <summary>

tests/NRedisStack.Tests/Tdigest/TdigestTests.cs

@@ -119,10 +119,10 @@ public void TestRankCommands()
         var tdigest = db.TDIGEST();
         tdigest.Create(key);
         tdigest.Add(key, 2d, 3d, 5d);
-        Assert.Equal(new long[] { 1l, 2l }, tdigest.Rank(key, 2, 4));
+        Assert.Equal(new long[] { 1, 2 }, tdigest.Rank(key, 2, 4));
         Assert.Equal(new long[] { 0, 1 }, tdigest.RevRank(key, 5, 4));
         Assert.Equal(new double[] { 2, 3 }, tdigest.ByRank(key, 0, 1));
-        Assert.Equal(new double[] { 5, 3 }, tdigest.ByRevRank(key, 1, 2));
+        Assert.Equal(new double[] { 5, 3 }, tdigest.ByRevRank(key, 0, 1));
     }
 
     // [Fact]