Remove use of collection literals

Collection literals are not supported by older dotnet versions, it
seems, so stop using them for now.

Author: Gabriel Erzse

src/NRedisStack/CoreCommands/CoreCommandBuilder.cs

@@ -28,12 +28,14 @@ public static SerializedCommand BzmPop(int timeout, RedisKey[] keys, MinMaxModif
                 throw new ArgumentException("At least one key must be provided.");
             }
 
-            List<object> args = [
+            List<object> args = new List<object> {
                 timeout,
-                keys.Length,
-                .. keys.Cast<object>(),
-                minMaxModifier == MinMaxModifier.Min ? CoreArgs.MIN : CoreArgs.MAX
-            ];
+                keys.Length
+            };
+
+            args.AddRange(keys.Cast<object>());
+
+            args.Add(minMaxModifier == MinMaxModifier.Min ? CoreArgs.MIN : CoreArgs.MAX);
 
             if (count != null)
             {

src/NRedisStack/CoreCommands/CoreCommands.cs

@@ -75,7 +75,7 @@ public static bool ClientSetInfo(this IDatabase db, SetInfoAttr attr, string val
         /// <remarks><seealso href="https://redis.io/commands/bzmpop"/></remarks>
         public static Tuple<RedisKey, List<RedisValueWithScore>>? BzmPop(this IDatabase db, int timeout, RedisKey key, MinMaxModifier minMaxModifier, long? count = null)
         {
-            return BzmPop(db, timeout, [key], minMaxModifier, count);
+            return BzmPop(db, timeout, new[] { key }, minMaxModifier, count);
         }
     }
 }

src/NRedisStack/ResponseParser.cs

@@ -738,7 +738,7 @@ public static Dictionary<string, RedisResult>[] ToDictionarys(this RedisResult r
             var resultKey = resultArray[0].ToRedisKey();
             var resultSetItems = resultArray[1].ToArray();
 
-            List<RedisValueWithScore> valuesWithScores = [];
+            List<RedisValueWithScore> valuesWithScores = new List<RedisValueWithScore>();
 
             foreach (var resultSetItem in resultSetItems)
             {

tests/NRedisStack.Tests/Core Commands/CoreTests.cs

@@ -153,7 +153,7 @@ public void TestBzmPop()
         var db = redis.GetDatabase(null);
         db.Execute("FLUSHALL");
 
-        var sortedSetKey = "my-set";
+        var sortedSetKey = new RedisKey("my-set");
 
         db.SortedSetAdd(sortedSetKey, "a", 1.5);
         db.SortedSetAdd(sortedSetKey, "b", 5.1);
@@ -162,7 +162,7 @@ public void TestBzmPop()
         db.SortedSetAdd(sortedSetKey, "e", 7.76);
 
         // Pop two items with default order, which means it will pop the minimum values.
-        var resultWithDefaultOrder = db.BzmPop(0, [sortedSetKey], MinMaxModifier.Min, 2);
+        var resultWithDefaultOrder = db.BzmPop(0, new[] { sortedSetKey }, MinMaxModifier.Min, 2);
 
         Assert.NotNull(resultWithDefaultOrder);
         Assert.Equal(sortedSetKey, resultWithDefaultOrder!.Item1);
@@ -171,7 +171,7 @@ public void TestBzmPop()
         Assert.Equal("c", resultWithDefaultOrder.Item2[1].Value.ToString());
 
         // Pop one more item, with descending order, which means it will pop the maximum value.
-        var resultWithDescendingOrder = db.BzmPop(0, [sortedSetKey], MinMaxModifier.Max, 1);
+        var resultWithDescendingOrder = db.BzmPop(0, new[] { sortedSetKey }, MinMaxModifier.Max, 1);
 
         Assert.NotNull(resultWithDescendingOrder);
         Assert.Equal(sortedSetKey, resultWithDescendingOrder!.Item1);
@@ -188,7 +188,7 @@ public void TestBzmPopNull()
         db.Execute("FLUSHALL");
 
         // Nothing in the set, and a short server timeout, which yields null.
-        var result = db.BzmPop(1, ["my-set"], MinMaxModifier.Min, null);
+        var result = db.BzmPop(1, "my-set", MinMaxModifier.Min);
 
         Assert.Null(result);
     }
@@ -205,7 +205,7 @@ public void TestBzmPopMultiplexerTimeout()
         db.Execute("FLUSHALL");
 
         // Server would wait forever, but the multiplexer times out in 1 second.
-        Assert.Throws<RedisTimeoutException>(() => db.BzmPop(0, ["my-set"], MinMaxModifier.Min));
+        Assert.Throws<RedisTimeoutException>(() => db.BzmPop(0, "my-set", MinMaxModifier.Min));
     }
 
     [SkipIfRedis(Is.OSSCluster, Comparison.LessThan, "7.0.0")]
@@ -229,14 +229,14 @@ public void TestBzmPopMultipleSets()
         Assert.Single(result.Item2);
         Assert.Equal("d", result.Item2[0].Value.ToString());
 
-        result = db.BzmPop(0, ["set-two", "set-one"], MinMaxModifier.Min);
+        result = db.BzmPop(0, new[] { new RedisKey("set-two"), new RedisKey("set-one") }, MinMaxModifier.Min);
 
         Assert.NotNull(result);
         Assert.Equal("set-two", result!.Item1);
         Assert.Single(result.Item2);
         Assert.Equal("e", result.Item2[0].Value.ToString());
 
-        result = db.BzmPop(0, ["set-two", "set-one"], MinMaxModifier.Max);
+        result = db.BzmPop(0, new[] { new RedisKey("set-two"), new RedisKey("set-one") }, MinMaxModifier.Max);
 
         Assert.NotNull(result);
         Assert.Equal("set-one", result!.Item1);
@@ -261,7 +261,7 @@ public void TestBzmPopNoKeysProvided()
         db.Execute("FLUSHALL");
 
         // Server would wait forever, but the multiplexer times out in 1 second.
-        Assert.Throws<ArgumentException>(() => db.BzmPop(0, [], MinMaxModifier.Min));
+        Assert.Throws<ArgumentException>(() => db.BzmPop(0, Array.Empty<RedisKey>(), MinMaxModifier.Min));
     }
 
     [SkipIfRedis(Is.OSSCluster, Comparison.LessThan, "7.0.0")]
@@ -279,15 +279,15 @@ public void TestBzmPopWithOrderEnum()
         db.SortedSetAdd(sortedSetKey, "c", 3.7);
 
         // Pop two items with default order, which means it will pop the minimum values.
-        var resultWithDefaultOrder = db.BzmPop(0, [sortedSetKey], Order.Ascending.ToMinMax());
+        var resultWithDefaultOrder = db.BzmPop(0, sortedSetKey, Order.Ascending.ToMinMax());
 
         Assert.NotNull(resultWithDefaultOrder);
         Assert.Equal(sortedSetKey, resultWithDefaultOrder!.Item1);
         Assert.Single(resultWithDefaultOrder.Item2);
         Assert.Equal("a", resultWithDefaultOrder.Item2[0].Value.ToString());
 
         // Pop one more item, with descending order, which means it will pop the maximum value.
-        var resultWithDescendingOrder = db.BzmPop(0, [sortedSetKey], Order.Descending.ToMinMax());
+        var resultWithDescendingOrder = db.BzmPop(0, sortedSetKey, Order.Descending.ToMinMax());
 
         Assert.NotNull(resultWithDescendingOrder);
         Assert.Equal(sortedSetKey, resultWithDescendingOrder!.Item1);

tests/NRedisStack.Tests/TimeSeries/TestAPI/TestMRange.cs

@@ -322,18 +322,18 @@ public void TestMRangeLatest()
                 (long)TimeSpan.FromHours(1).TotalMilliseconds, // 1h used to force partial bucket 
                 TsAggregation.Sum);
 
-            ts.Create(primaryTsKey, labels: [label]);
-            ts.Create(compactedTsKey, labels: [label, compactedLabel]);
+            ts.Create(primaryTsKey, labels: new[] { label });
+            ts.Create(compactedTsKey, labels: new[] { label, compactedLabel });
             ts.CreateRule(primaryTsKey, compactionRule);
-            var tuples = CreateData(ts, 50, [primaryTsKey]);
+            var tuples = CreateData(ts, 50, new[] { primaryTsKey });
 
-            var results = ts.MRange("-", "+", ["key=MRangeLatest", "compact=true"], latest: true);
+            var results = ts.MRange("-", "+", new[] { "key=MRangeLatest", "compact=true" }, latest: true);
             Assert.Single(results);
             Assert.Equal(compactedTsKey, results[0].key);
             Assert.NotEmpty(results[0].values);
             Assert.Equal(tuples.Sum(x => x.Val), results[0].values.Sum(x => x.Val));
 
-            results = ts.MRange("-", "+", ["key=MRangeLatest", "compact=true"], latest: false);
+            results = ts.MRange("-", "+", new[] { "key=MRangeLatest", "compact=true" }, latest: false);
             Assert.Single(results);
             Assert.Equal(compactedTsKey, results[0].key);
             Assert.Empty(results[0].values);