Streamline CI jobs

Add net8.0 as target framework.

Remove the `doctests` workflow, since all tests inside `tests/Doc` are
executed anyway during the `integration` workflow.

Separate the concurrency groups between workflows, to avoid them
cancelling each other during one CI run. This seems to be a known issue:
https://github.com/orgs/community/discussions/41518

Instead of running the `integration` workflow separately for different
dotnet target frameworks (which turned out to be an illusion, because it
was always running with dotnet 8), run it only once per Redis setup
type, and don't restrict the target framework, so it will run against
all listed target frameworks.

Remove parallel test runs, trying to avoid spurious test failures in CI.

Update the release workflow to also use dotnet 8, and to print the
dotnet version and available SDKs and runtimes, for clarity.

Author: Gabriel Erzse

.github/workflows/doctests.yml

@@ -12,62 +12,15 @@ on:
     - cron: "0 1 * * *"
 
 concurrency:
-  group: ${{ github.event.pull_request.number || github.ref }}
+  group: ${{ github.event.pull_request.number || github.ref }}-integration
   cancel-in-progress: true
 
 jobs:
-  dotnet_6_cluster:
-    name: .NET 6 on [redis-stack cluster]
-    uses: ./.github/workflows/reusable.yml
-    with:
-      redis_stack_type: cluster
-      clr_version: net6.0
-      dotenv_file: .github/cluster.env
-    secrets: inherit
-
-  dotnet_6:
-    name: .NET 6 on [redis-stack ${{matrix.redis-stack-type}}]
-    uses: ./.github/workflows/reusable.yml
-    strategy:
-      fail-fast: false
-      max-parallel: 5
-      matrix:
-        redis-stack-type: ['edge', '6.2.6', '7.2.0-RC3']
-    with:
-      redis_stack_type: ${{matrix.redis-stack-type}}
-      clr_version: net6.0
-      dotenv_file: .github/standalone.env
-    secrets: inherit
-
-  dotnet_7_cluster:
-    name: .NET 7 on [redis-stack cluster]
-    uses: ./.github/workflows/reusable.yml
-    with:
-      redis_stack_type: cluster
-      clr_version: net7.0
-      dotenv_file: .github/cluster.env
-    secrets: inherit
-
-  dotnet_7:
-    name: .NET 7 on [redis-stack ${{matrix.redis-stack-type}}]
-    uses: ./.github/workflows/reusable.yml
-    strategy:
-      fail-fast: false
-      max-parallel: 5
-      matrix:
-        redis-stack-type: ['edge', '6.2.6', '7.2.0-RC3']
-    with:
-      redis_stack_type: ${{matrix.redis-stack-type}}
-      clr_version: net7.0
-      dotenv_file: .github/standalone.env
-    secrets: inherit
-
   dotnet_8_cluster:
     name: .NET 8 on [redis-stack cluster]
     uses: ./.github/workflows/reusable.yml
     with:
       redis_stack_type: cluster
-      clr_version: net8.0
       dotenv_file: .github/cluster.env
     secrets: inherit
 
@@ -76,12 +29,10 @@ jobs:
     uses: ./.github/workflows/reusable.yml
     strategy:
       fail-fast: false
-      max-parallel: 5
       matrix:
         redis-stack-type: ['edge', '6.2.6', '7.2.0-RC3']
     with:
       redis_stack_type: ${{matrix.redis-stack-type}}
-      clr_version: net8.0
       dotenv_file: .github/standalone.env
     secrets: inherit
 
@@ -109,6 +60,8 @@ jobs:
           sudo apt-get install curl -y && sudo apt-get install gpg -y && apt-get install lsb-release -y && apt-get install libgomp1 -y
           curl https://packages.redis.io/redis-stack/redis-stack-server-${{env.redis_stack_version}}.jammy.x86_64.tar.gz -o redis-stack.tar.gz
           tar xf redis-stack.tar.gz
+      - name: Clean
+        run: dotnet clean
       - name: Restore dependencies
         run: dotnet restore
       - name: Build

.github/workflows/integration.yml

@@ -3,7 +3,7 @@ name: Format check on pull request
 on: pull_request
 
 concurrency:
-  group: ${{ github.event.pull_request.number || github.ref }}
+  group: ${{ github.event.pull_request.number || github.ref }}-linter
   cancel-in-progress: true
 
 jobs:
@@ -14,7 +14,7 @@ jobs:
         run: dotnet tool install -g dotnet-format
 
       - name: Checkout repo
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           ref: ${{ github.head_ref }}
 

.github/workflows/linter.yaml

@@ -9,17 +9,21 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
-      - name: Set up .NET Core 6
-        uses: actions/setup-dotnet@v2
+      - name: Set up .NET Core 8
+        uses: actions/setup-dotnet@v3
         with:
-          dotnet-version: '6.0.x'
-      - name: Set up .NET Core 7
-        uses: actions/setup-dotnet@v2
-        with:
-          dotnet-version: '7.0.x'
+          dotnet-version: 8
+      - name: Check .NET version
+        working-directory: .github
+        run: dotnet --version
+      - name: Check .NET SDKs
+        working-directory: .github
+        run: dotnet --list-sdks
+      - name: Check .NET runtimes
+        working-directory: .github
+        run: dotnet --list-runtimes
       - name: Build
         run: dotnet pack -c Release --output .
-
       - name: Publish
         uses: alirezanet/[email protected]
         with:

.github/workflows/nuget-release.yml

@@ -7,10 +7,6 @@ on:
             required: true
             type: string
 
-        clr_version:
-            required: true
-            type: string
-
         dotenv_file:
             required: true
             type: string
@@ -25,24 +21,12 @@ jobs:
           PASSWORD: ${{ secrets.PASSWORD }}
           ENDPOINT: ${{ secrets.ENDPOINT }}
         steps:
-
           - uses: actions/checkout@v3
 
-          - name: .NET Core 6
-            uses: actions/setup-dotnet@v2
-            with:
-              dotnet-version: '6.0.x'
-
-          - name: .NET Core 7
-            uses: actions/setup-dotnet@v2
-            with:
-              dotnet-version: '7.0.x'
-
-          - name: .NET Core 8 preview
+          - name: .NET Core 8
             uses: actions/setup-dotnet@v3
             with:
               dotnet-version: 8
-              dotnet-quality: 'preview'
 
           - name: run redis-stack-server docker
             working-directory: .github
@@ -53,6 +37,8 @@ jobs:
             with:
               env-file: ${{inputs.dotenv_file}}
 
+          - name: Cleanup
+            run: dotnet clean
           - name: Restore dependencies
             run: dotnet restore
           - name: Build
@@ -62,13 +48,11 @@ jobs:
               echo "${{secrets.REDIS_CA_PEM}}" > tests/NRedisStack.Tests/bin/Debug/net6.0/redis_ca.pem
               echo "${{secrets.REDIS_USER_CRT}}" > tests/NRedisStack.Tests/bin/Debug/net6.0/redis_user.crt
               echo "${{secrets.REDIS_USER_PRIVATE_KEY}}" > tests/NRedisStack.Tests/bin/Debug/net6.0/redis_user_private.key
-              ls -R
-              dotnet test -f ${{inputs.clr_version}} --no-build --verbosity normal /p:CollectCoverage=true /p:CoverletOutputFormat=opencover
+              dotnet test --no-build --verbosity normal /p:CollectCoverage=true /p:CoverletOutputFormat=opencover
           - name: Codecov
             uses: codecov/codecov-action@v3
             with:
               token: ${{secrets.CODECOV_TOKEN}}
               verbose: true
           - name: Build
             run: dotnet pack -c Release
-

.github/workflows/reusable.yml

@@ -4,7 +4,7 @@ on:
   pull_request:
 
 concurrency:
-  group: ${{ github.event.pull_request.number || github.ref }}
+  group: ${{ github.event.pull_request.number || github.ref }}-spellcheck
   cancel-in-progress: true
 
 jobs:

.github/workflows/spellcheck.yml

@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <Nullable>enable</Nullable>
-	<TargetFrameworks>netstandard2.0;net6.0;net7.0</TargetFrameworks>
+	<TargetFrameworks>netstandard2.0;net6.0;net7.0;net8.0</TargetFrameworks>
 	<LangVersion>latest</LangVersion>
 	<ImplicitUsings>enable</ImplicitUsings>
 	<Authors>Redis Open Source</Authors>

src/NRedisStack/NRedisStack.csproj

@@ -1,8 +1,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <IsWindows>$([System.Runtime.InteropServices.RuntimeInformation]::IsOSPlatform($([System.Runtime.InteropServices.OSPlatform]::get_Windows())))</IsWindows>
-    <TargetFrameworks Condition=" '$(IsWindows)' == 'true'">net6.0;net7.0;net481</TargetFrameworks>
-    <TargetFrameworks Condition=" '$(IsWindows)' != 'true'">net6.0;net7.0</TargetFrameworks>
+    <TargetFrameworks Condition=" '$(IsWindows)' == 'true'">net6.0;net7.0;net8.0;net481</TargetFrameworks>
+    <TargetFrameworks Condition=" '$(IsWindows)' != 'true'">net6.0;net7.0;net8.0</TargetFrameworks>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
     <LangVersion>latest</LangVersion>

tests/Doc/Doc.csproj

@@ -1,8 +1,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <IsWindows>$([System.Runtime.InteropServices.RuntimeInformation]::IsOSPlatform($([System.Runtime.InteropServices.OSPlatform]::get_Windows())))</IsWindows>
-    <TargetFrameworks Condition=" '$(IsWindows)' == 'true'">net6.0;net7.0;net481</TargetFrameworks>
-    <TargetFrameworks Condition=" '$(IsWindows)' != 'true'">net6.0;net7.0</TargetFrameworks>
+    <TargetFrameworks Condition=" '$(IsWindows)' == 'true'">net6.0;net7.0;net8.0;net481</TargetFrameworks>
+    <TargetFrameworks Condition=" '$(IsWindows)' != 'true'">net6.0;net7.0;net8.0</TargetFrameworks>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
     <LangVersion>latest</LangVersion>