Error while opening a book with a subtitle

[ClementHard]

Hello,

I'm getting an error when i try to open a book with a subtitle.
It does not occur on iOS.
When i remove the subtitle (<dc:title id="subtitle">Book Subtitle</dc:title>) it works fine.

Here is the metadata from content.opf

<metadata xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:opf="http://www.idpf.org/2007/opf" xmlns="http://www.idpf.org/2007/opf">
    <dc:title id="title">Book Title</dc:title>
    <meta property="title-type" refines="#title">main</meta>
    <dc:title id="subtitle">Book Subtitle</dc:title>
    <meta property="title-type" refines="#subtitle">subtitle</meta>
    <dc:creator id="creator01">John Doe</dc:creator>
    <meta scheme="marc:relators" property="role" refines="#creator01">aut</meta>
    <meta property="display-seq" refines="#creator01">1</meta>
    <dc:creator id="creator02">Foo Bar</dc:creator>
    <meta scheme="marc:relators" property="role" refines="#creator02">aut</meta>
    <meta property="display-seq" refines="#creator02">2</meta>
    <dc:creator id="creator03">Bar Foo</dc:creator>
    <meta scheme="marc:relators" property="role" refines="#creator03">aut</meta>
    <meta property="display-seq" refines="#creator03">3</meta>
    <dc:date>2014-06-04</dc:date>
    <meta property="dcterms:modified">2014-06-04T00:00:00Z</meta>
    <dc:identifier id="bookid">123456789FOO</dc:identifier>
    <dc:language>fr</dc:language>
    <meta name="cover" content="cover-image"/>
</metadata>

Here is the error :

19244                   libc  F  Fatal signal 11 (SIGSEGV) at 0x0000000c (code=1), thread 19244 (ndroid.launcher)
  121                   DEBUG  I  *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
  121                   DEBUG  I  Build fingerprint: 'google/nakasi/grouper:4.4.2/KOT49H/937116:user/release-keys'
  121                   DEBUG  I  Revision: '0'
  121                   DEBUG  I  pid: 19244, tid: 19244, name: ndroid.launcher  >>> org.readium.sdk.android.launcher <<<
  121                   DEBUG  I  signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0000000c
  121                   DEBUG  I  r0 00000004  r1 bea33f5c  r2 00000004  r3 0000000c
  121                   DEBUG  I  r4 699a6000  r5 69d75e74  r6 bea33fb4  r7 bea340b0
  121                   DEBUG  I  r8 bea33f88  r9 69d779f8  sl 699a6000  fp 69d77a00
  121                   DEBUG  I  ip 00000001  sp bea33f54  lr 6b32f198  pc 6b214e48  cpsr 80070010
  121                   DEBUG  I  d0  000000003a6e7275  d1  0000000000000000
  121                   DEBUG  I  d2  0000000000000000  d3  0000000000000000
  121                   DEBUG  I  d4  000000010a3e6c6f  d5  3ff0000000000000
  121                   DEBUG  I  d6  3ff0000000000000  d7  3ff0000000000000
  121                   DEBUG  I  d8  0000000000000000  d9  0000000000000000
  121                   DEBUG  I  d10 0000000000000000  d11 0000000000000000
  121                   DEBUG  I  d12 0000000000000000  d13 0000000000000000
  121                   DEBUG  I  d14 0000000000000000  d15 0000000000000000
  121                   DEBUG  I  d16 20200a3e612f3c34  d17 2020202020202020
  121                   DEBUG  I  d18 3f91a7b9611a7b96  d19 401211a7c0000000
  121                   DEBUG  I  d20 401211a7c0000000  d21 4020000000000000
  121                   DEBUG  I  d22 3fe211a7c0000000  d23 3ff0000000000000
  121                   DEBUG  I  d24 3ff0000000000000  d25 0000000000000000
  121                   DEBUG  I  d26 b96377ce858a5d48  d27 b96377ce858a5d48
  121                   DEBUG  I  d28 3ff0000000000000  d29 0000000000000000
  121                   DEBUG  I  d30 0000000000000000  d31 c088480000000000
  121                   DEBUG  I  scr 60000010
  121                   DEBUG  I  backtrace:
  121                   DEBUG  I  #00  pc 0008de48  /data/app-lib/org.readium.sdk.android.launcher-2/libepub3.so
  121                   DEBUG  I  #01  pc 001a8194  /data/app-lib/org.readium.sdk.android.launcher-2/libepub3.so
  121                   DEBUG  I  #02  pc 000d23c9  /data/app-lib/org.readium.sdk.android.launcher-2/libepub3.so (ePub3::Package::FullTitle(bool) const+312)
  121                   DEBUG  I  stack:
  121                   DEBUG  I  bea33f14  6b260dfb  /data/app-lib/org.readium.sdk.android.launcher-2/libepub3.so (ePub3::Property::LocalizedValue(std::locale const&) const+270)
  121                   DEBUG  I  bea33f18  00000028
  121                   DEBUG  I  bea33f1c  698947fc
  121                   DEBUG  I  bea33f20  00000000
  121                   DEBUG  I  bea33f24  bea33fa8  [stack]
  121                   DEBUG  I  bea33f28  bea33f3c  [stack]
  121                   DEBUG  I  bea33f2c  6b25ff07  /data/app-lib/org.readium.sdk.android.launcher-2/libepub3.so (ePub3::PropertyHolder::PropertiesMatching(ePub3::IRI const&, bool) const+94)
  121                   DEBUG  I  bea33f30  401a9e85  /system/lib/libc.so (dlmalloc)
  121                   DEBUG  I  bea33f34  ffffffff
  121                   DEBUG  I  bea33f38  0000000a
  121                   DEBUG  I  bea33f3c  401c52ad  /system/lib/libc.so (strtoul+120)
  121                   DEBUG  I  bea33f40  69d78b6c
  121                   DEBUG  I  bea33f44  00000000
  121                   DEBUG  I  bea33f48  0000000a
  121                   DEBUG  I  bea33f4c  bea33fcc  [stack]
  121                   DEBUG  I  bea33f50  bea33fcc  [stack]
  121                   DEBUG  I  #00  bea33f54  699a6000
  121                   DEBUG  I  #01  bea33f58  bea33fb4  [stack]
  121                   DEBUG  I  bea33f5c  bea340b0  [stack]
  121                   DEBUG  I  bea33f60  bea33f88  [stack]
  121                   DEBUG  I  bea33f64  bea33fcc  [stack]
  121                   DEBUG  I  bea33f68  bea33f80  [stack]
  121                   DEBUG  I  bea33f6c  6b2593cd  /data/app-lib/org.readium.sdk.android.launcher-2/libepub3.so (ePub3::Package::FullTitle(bool) const+316)
  121                   DEBUG  I  #02  bea33f70  00000001
  121                   DEBUG  I  bea33f74  bea33f90  [stack]
  121                   DEBUG  I  bea33f78  bea33fa8  [stack]
  121                   DEBUG  I  bea33f7c  bea33f8c  [stack]
  121                   DEBUG  I  bea33f80  6b3a61bc
  121                   DEBUG  I  bea33f84  698947fc
  121                   DEBUG  I  bea33f88  69d76118
  121                   DEBUG  I  bea33f8c  69d76108
  121                   DEBUG  I  bea33f90  69a7c7a0
  121                   DEBUG  I  bea33f94  69a7c7b0
  121                   DEBUG  I  bea33f98  69a7c7b0
  121                   DEBUG  I  bea33f9c  699a5ff8
  121                   DEBUG  I  bea33fa0  699a6000
  121                   DEBUG  I  bea33fa4  699a6000
  121                   DEBUG  I  bea33fa8  69d779e8
  121                   DEBUG  I  bea33fac  69d77a00

[danielweck]

I am not actually working on this bug right now, but just for future reference:

https://github.com/readium/readium-sdk/blob/develop/ePub3/ePub/package.cpp#L1307

[bluefire-cbond]

The error here is caused by the flawed assumptions in Package::FullTitle that:

1. display-seq only applies to titles
2. title items always include display-seq data

In the particular case supplied by Twibit, we have a meta section that has three sequenced authors, and two title entries (not sequenced). The code produces an array of two items and then attempts to put the three author names into this list (we get a seg fault on the 3rd item).

We need to:

1. Add support for titles without sequence data
2. Ensure that sequence data pulled is filtered so it only applies to titles

[danielweck]

Good find @bluefire-cbond

...and display-seq is not supported for dc:creator (See the API function that returns the ordered list of authors: https://github.com/readium/readium-sdk/blob/develop/ePub3/ePub/package.cpp#L1355 ) To be filed as a separate issue.

It looks like there might be several issues of a similar ilk. The metadata part of the Package API probably needs a thorough review.

[danielweck]

Issue now in correct repository (readium-sdk), closing this one.

readium/readium-sdk#101