make sure writes to URLSession.taskRegistry happen on work queue

Author: ahti

Foundation/URLSession/URLSessionTask.swift

@@ -702,24 +702,30 @@ extension _ProtocolClient: URLProtocolClient {
             session.delegateQueue.addOperation {
                 delegate.urlSession(session, task: task, didCompleteWithError: nil)
                 task.state = .completed
-                task.workQueue.async {
+                session.workQueue.async {
                     session.taskRegistry.remove(task)
                 }
             }
         case .noDelegate:
             task.state = .completed
-            session.taskRegistry.remove(task)
+            session.workQueue.async {
+                session.taskRegistry.remove(task)
+            }
         case .dataCompletionHandler(let completion):
             session.delegateQueue.addOperation {
                 completion(`protocol`.properties[URLProtocol._PropertyKey.responseData] as? Data ?? Data(), task.response, nil)
                 task.state = .completed
-                session.taskRegistry.remove(task)
+                session.workQueue.async {
+                    session.taskRegistry.remove(task)
+                }
             }
         case .downloadCompletionHandler(let completion):
             session.delegateQueue.addOperation {
                 completion(`protocol`.properties[URLProtocol._PropertyKey.temporaryFileURL] as? URL, task.response, nil)
                 task.state = .completed
-                session.taskRegistry.remove(task)
+                session.workQueue.async {
+                    session.taskRegistry.remove(task)
+                }
             }
         }
         task._protocol = nil
@@ -786,26 +792,30 @@ extension _ProtocolClient: URLProtocolClient {
             session.delegateQueue.addOperation {
                 delegate.urlSession(session, task: task, didCompleteWithError: error as Error)
                 task.state = .completed
-                task.workQueue.async {
+                session.workQueue.async {
                     session.taskRegistry.remove(task)
                 }
             }
         case .noDelegate:
             task.state = .completed
-            session.taskRegistry.remove(task)
+            session.workQueue.async {
+                session.taskRegistry.remove(task)
+            }
         case .dataCompletionHandler(let completion):
             session.delegateQueue.addOperation {
                 completion(nil, nil, error)
                 task.state = .completed
-                task.workQueue.async {
+                session.workQueue.async {
                     session.taskRegistry.remove(task)
                 }
             }
         case .downloadCompletionHandler(let completion):
             session.delegateQueue.addOperation {
                 completion(nil, nil, error)
                 task.state = .completed
-                session.taskRegistry.remove(task)
+                session.workQueue.async {
+                    session.taskRegistry.remove(task)
+                }
             }
         }
         task._protocol = nil