Fix CloseProtectionTests

Author: legionth

tests/CloseProtectionStreamTest.php

@@ -7,7 +7,7 @@
 
 class CloseProtectionStreamTest extends TestCase
 {
-    public function testCloseEventDoesntCloseInputStream()
+    public function testClosePausesTheInputStreamInsteadOfClosing()
     {
         $input = $this->getMockBuilder('React\Socket\Connection')->disableOriginalConstructor()->getMock();
         $input->expects($this->never())->method('close');
@@ -31,11 +31,10 @@ public function testHandleError()
 
         $protection = new CloseProtectionStream($input);
         $protection->on('error', $this->expectCallableOnce());
-        $protection->on('close', $this->expectCallableOnce());
 
         $input->emit('error', array(new \RuntimeException()));
 
-        $this->assertFalse($protection->isReadable());
+        $this->assertTrue($protection->isReadable());
         $this->assertTrue($input->isReadable());
     }
 
@@ -78,25 +77,11 @@ public function testHandleClose()
         $protection->on('close', $this->expectCallableOnce());
 
         $input->close();
-        $input->emit('end', array());
 
         $this->assertFalse($protection->isReadable());
         $this->assertFalse($input->isReadable());
     }
 
-    public function testSendEndViaPipe()
-    {
-        $input = new ReadableStream();
-
-        $protection = new CloseProtectionStream($input);
-        $protection->on('close', $this->expectCallableOnce());
-
-        $input->close();
-        $input->emit('end', array());
-
-        $this->assertFalse($protection->isReadable());
-    }
-
     public function testStopEmittingDataAfterClose()
     {
         $input = new ReadableStream();
@@ -149,14 +134,47 @@ public function testEndWontBeEmittedAfterClose()
 
     public function closeEventPausesInputStream()
     {
-        $input = $this->getMock('React\Stream\ReadableStreamInterface');
+        $input = $this->getMockBuilder('React\Stream\ReadableStreamInterface')->getMock();
+        $input->expects($this->once())->method('pause');
+
+        $protection = new CloseProtectionStream($input);
+
+        $protection->on('data', $this->expectCallableNever());
+        $protection->on('close', $this->expectCallableOnce());
+
+        $protection->close();
+    }
+
+    public function testPauseAfterCloseWontBeEmittedFurther()
+    {
+        $input = $this->getMockBuilder('React\Stream\ReadableStreamInterface')->getMock();
         $input->expects($this->once())->method('pause');
 
         $protection = new CloseProtectionStream($input);
+        $protection->on('data', $this->expectCallableNever());
+
+        $protection->on('close', $this->expectCallableOnce());
+
+        $protection->close();
+        $protection->pause();
+
+        $input->emit('data', array('hello'));
+    }
+
+    public function testResumeAfterCloseWontBeEmittedFurther()
+    {
+        $input = $this->getMockBuilder('React\Stream\ReadableStreamInterface')->getMock();
+        $input->expects($this->once())->method('pause');
+        $input->expects($this->never())->method('resume');
+
         $protection = new CloseProtectionStream($input);
         $protection->on('data', $this->expectCallableNever());
+
         $protection->on('close', $this->expectCallableOnce());
 
         $protection->close();
+        $protection->resume();
+
+        $input->emit('data', array('hello'));
     }
 }