Use PSR-7 approach to handle bodiless data

Author: legionth

src/Server.php

@@ -140,12 +140,14 @@ public function handleRequest(ConnectionInterface $conn, RequestInterface $reque
 
         $response = new Response($conn, $request->getProtocolVersion());
 
+        $contentLength = 0;
         $stream = new CloseProtectionStream($conn);
         if ($request->hasHeader('Transfer-Encoding')) {
             $transferEncodingHeader = $request->getHeader('Transfer-Encoding');
             // 'chunked' must always be the final value of 'Transfer-Encoding' according to: https://tools.ietf.org/html/rfc7230#section-3.3.1
             if (strtolower(end($transferEncodingHeader)) === 'chunked') {
                 $stream = new ChunkedDecoder($stream);
+                $contentLength = null;
             }
         } elseif ($request->hasHeader('Content-Length')) {
             $string = $request->getHeaderLine('Content-Length');
@@ -170,15 +172,9 @@ public function handleRequest(ConnectionInterface $conn, RequestInterface $reque
 
         $this->emit('request', array($request, $response));
 
-        if ($stream instanceof CloseProtectionStream) {
-            $request->emit('end');
-            $request->close();
-            return;
-        }
-
-        if ($stream instanceof LengthLimitedStream && $contentLength === 0) {
-            // Content-Length is 0 and won't emit further data,
-            // 'handleData' from LengthLimitedStream won't be called anymore
+        if ($contentLength === 0) {
+            // If Body is empty or Content-Length is 0 and won't emit further data,
+            // 'data' events from other streams won't be called anymore
             $stream->emit('end');
             $stream->close();
         }

tests/ServerTest.php

@@ -1205,6 +1205,42 @@ public function testEndEventWillBeEmittedOnSimpleRequest()
         $this->connection->emit('data', array($data));
     }
 
+    public function testRequestWithIncompleteHeaderWontEmitRequestEvent()
+    {
+        $server = new Server($this->socket);
+        $server->on('request', $this->expectCallableNever());
+
+        $this->socket->emit('connection', array($this->connection));
+
+        $data = "GET / HTTP/1.1\r\n";
+
+        $this->connection->emit('data', array($data));
+    }
+
+    public function testRequestWithoutDefinedLengthWillIgnoreDataEvent()
+    {
+        $server = new Server($this->socket);
+
+        $dataEvent = $this->expectCallableNever();
+        $endEvent = $this->expectCallableOnce();
+        $closeEvent = $this->expectCallableOnce();
+        $errorEvent = $this->expectCallableNever();
+
+        $server->on('request', function (Request $request, Response $response) use ($dataEvent, $endEvent, $closeEvent, $errorEvent) {
+            $request->on('data', $dataEvent);
+            $request->on('end', $endEvent);
+            $request->on('close', $closeEvent);
+            $request->on('error', $errorEvent);
+        });
+
+        $this->socket->emit('connection', array($this->connection));
+
+        $data = $this->createGetRequest();
+        $data .= "hello world";
+
+        $this->connection->emit('data', array($data));
+    }
+
     private function createGetRequest()
     {
         $data = "GET / HTTP/1.1\r\n";