Skip to content

Commit 66eeacb

Browse files
authored
fix types (#4677)
1 parent 63a812a commit 66eeacb

File tree

4 files changed

+17
-60
lines changed

4 files changed

+17
-60
lines changed

beta/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"check-all": "npm-run-all prettier lint:fix tsc"
2323
},
2424
"dependencies": {
25-
"@codesandbox/sandpack-react": "v0.19.8-experimental.0",
25+
"@codesandbox/sandpack-react": "v0.19.8-experimental.2",
2626
"@docsearch/css": "3.0.0-alpha.41",
2727
"@docsearch/react": "3.0.0-alpha.41",
2828
"@headlessui/react": "^1.3.0",

beta/patches/@codesandbox+sandpack-client+0.19.8-experimental.0.patch

Lines changed: 0 additions & 35 deletions
This file was deleted.

beta/src/components/MDX/Sandpack/Console.tsx

Lines changed: 7 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,11 @@ import * as React from 'react';
33
import {IconChevron} from 'components/Icon/IconChevron';
44

55
import {SandpackCodeViewer, useSandpack} from '@codesandbox/sandpack-react';
6+
import type {SandpackMessageConsoleMethods} from '@codesandbox/sandpack-client';
67

7-
const getType = (message: Methods): 'info' | 'warning' | 'error' => {
8+
const getType = (
9+
message: SandpackMessageConsoleMethods
10+
): 'info' | 'warning' | 'error' => {
811
if (message === 'log' || message === 'info') {
912
return 'info';
1013
}
@@ -19,25 +22,12 @@ const getType = (message: Methods): 'info' | 'warning' | 'error' => {
1922
type ConsoleData = Array<{
2023
data: Array<string | Record<string, string>>;
2124
id: string;
22-
method: Methods;
25+
method: SandpackMessageConsoleMethods;
2326
}>;
2427

25-
type Methods =
26-
| 'log'
27-
| 'debug'
28-
| 'info'
29-
| 'warn'
30-
| 'error'
31-
| 'table'
32-
| 'clear'
33-
| 'time'
34-
| 'timeEnd'
35-
| 'count'
36-
| 'assert';
37-
3828
const MAX_MESSAGE_COUNT = 100;
3929

40-
export const SandpackConsole: React.FC<{clientId?: string}> = ({clientId}) => {
30+
export const SandpackConsole: React.FC = () => {
4131
const {listen} = useSandpack();
4232
const [logs, setLogs] = React.useState<ConsoleData>([]);
4333
const wrapperRef = React.useRef<HTMLDivElement>(null);
@@ -47,7 +37,7 @@ export const SandpackConsole: React.FC<{clientId?: string}> = ({clientId}) => {
4737
if (message.type === 'start') {
4838
setLogs([]);
4939
}
50-
// there is no such type as console in Sandpack
40+
5141
if (message.type === 'console' && message.codesandbox) {
5242
setLogs((prev) => {
5343
const messages = [...prev, ...message.log];

beta/yarn.lock

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -483,16 +483,18 @@
483483
style-mod "^4.0.0"
484484
w3c-keyname "^2.2.4"
485485

486-
"@codesandbox/sandpack-client@^0.19.8-experimental.0":
487-
version "0.19.8-experimental.0"
488-
resolved "https://registry.yarnpkg.com/@codesandbox/sandpack-client/-/sandpack-client-0.19.8-experimental.0.tgz#044afb1efce0356e18b6d644960694c817012a2a"
486+
"@codesandbox/sandpack-client@^0.19.8-experimental.2":
487+
version "0.19.9"
488+
resolved "https://registry.yarnpkg.com/@codesandbox/sandpack-client/-/sandpack-client-0.19.9.tgz#29fded94a3087de155035634d596651268e27797"
489+
integrity sha512-/PPFqAJ8NSlP1jpWjQtwvmVS5o1xLRVqdbzXF7Num7zVUdYLZAbpzT7KijneZSmdcJHOvCCAYGLKJg+TcgmLjw==
489490
dependencies:
490491
codesandbox-import-utils "^1.2.3"
491492
lodash.isequal "^4.5.0"
492493

493-
"@codesandbox/[email protected]":
494-
version "0.19.8-experimental.0"
495-
resolved "https://registry.yarnpkg.com/@codesandbox/sandpack-react/-/sandpack-react-0.19.8-experimental.0.tgz#0a86971be53f5d177d61796d4e048998c2dcc271"
494+
"@codesandbox/[email protected]":
495+
version "0.19.8-experimental.2"
496+
resolved "https://registry.yarnpkg.com/@codesandbox/sandpack-react/-/sandpack-react-0.19.8-experimental.2.tgz#99b5f6a3c5ab056aaa0c9024e05704f53e245450"
497+
integrity sha512-juaOZjlHVQ7BV6tj0d+RfhTptFp2AOBvVHI53Ze5T4hGmlCg6Ic8/DlStS98lygNWL9vKHiyv7umlN9Xom/EjQ==
496498
dependencies:
497499
"@code-hike/classer" "^0.0.0-aa6efee"
498500
"@codemirror/closebrackets" "^0.19.0"
@@ -508,7 +510,7 @@
508510
"@codemirror/matchbrackets" "^0.19.3"
509511
"@codemirror/state" "^0.19.6"
510512
"@codemirror/view" "^0.19.32"
511-
"@codesandbox/sandpack-client" "^0.19.8-experimental.0"
513+
"@codesandbox/sandpack-client" "^0.19.8-experimental.2"
512514
"@react-hook/intersection-observer" "^3.1.1"
513515
codesandbox-import-util-types "^2.2.3"
514516
lodash.isequal "^4.5.0"

0 commit comments

Comments
 (0)