From 4f0f9726f93300dbf2a43405143d8d5df7f90282 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Jos=C3=A9=20Cano=20Duque?= Date: Fri, 9 Jun 2023 10:43:31 -0500 Subject: [PATCH] Update parameter name in starlette.py Looks like the configure() method has an error in the component parameter. In the code documentation, the parameter indicates 'component' but the name is 'constructor', I've reviewed other files, and looks like the standard is 'component'. --- src/py/reactpy/reactpy/backend/starlette.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/py/reactpy/reactpy/backend/starlette.py b/src/py/reactpy/reactpy/backend/starlette.py index 658fccfbd..3a9695b33 100644 --- a/src/py/reactpy/reactpy/backend/starlette.py +++ b/src/py/reactpy/reactpy/backend/starlette.py @@ -36,7 +36,7 @@ def configure( app: Starlette, - constructor: RootComponentConstructor, + component: RootComponentConstructor, options: Options | None = None, ) -> None: """Configure the necessary ReactPy routes on the given app. @@ -49,7 +49,7 @@ def configure( options = options or Options() # this route should take priority so set up it up first - _setup_single_view_dispatcher_route(options, app, constructor) + _setup_single_view_dispatcher_route(options, app, component) _setup_common_routes(options, app) @@ -129,7 +129,7 @@ async def serve_index(request: Request) -> HTMLResponse: def _setup_single_view_dispatcher_route( - options: Options, app: Starlette, constructor: RootComponentConstructor + options: Options, app: Starlette, component: RootComponentConstructor ) -> None: @app.websocket_route(str(STREAM_PATH)) @app.websocket_route(f"{STREAM_PATH}/{{path:path}}") @@ -145,7 +145,7 @@ async def model_stream(socket: WebSocket) -> None: await serve_layout( Layout( ConnectionContext( - constructor(), + component(), value=Connection( scope=socket.scope, location=Location(pathname, f"?{search}" if search else ""),