test module_name_suffix

Author: rmorshea

docs/source/_static/custom.js

@@ -1644,22 +1644,27 @@ function ImportedElement({ model }) {
   }
 }
 
-function RenderImportedElement() {
+function RenderImportedElement({ model, importSource }) {
   react.useContext(LayoutConfigContext);
   const mountPoint = react.useRef(null);
   const sourceBinding = react.useRef(null);
 
   react.useEffect(() => {
     sourceBinding.current = importSource.bind(mountPoint.current);
-    return () => {
-      sourceBinding.current.unmount();
-    };
+    if (!importSource.data.unmountBeforeUpdate) {
+      return sourceBinding.current.unmount;
+    }
   }, []);
 
   // this effect must run every time in case the model has changed
-  react.useEffect(() => sourceBinding.current.render(model));
-
+  react.useEffect(() => {
+    sourceBinding.current.render(model);
+    if (importSource.data.unmountBeforeUpdate) {
+      return sourceBinding.current.unmount;
+    }
+  });
 
+  return html`<div ref=${mountPoint} />`;
 }
 
 function elementChildren(modelChildren) {
@@ -1717,6 +1722,7 @@ function loadImportSource$1(config, importSource) {
     .then((module) => {
       if (typeof module.bind == "function") {
         return {
+          data: importSource,
           bind: (node) => {
             const binding = module.bind(node, config);
             if (

tests/test_web/test_utils.py

@@ -4,6 +4,7 @@
 import responses
 
 from idom.web.utils import (
+    module_name_suffix,
     resolve_module_exports_from_file,
     resolve_module_exports_from_source,
     resolve_module_exports_from_url,
@@ -13,6 +14,23 @@
 JS_FIXTURES_DIR = Path(__file__).parent / "js_fixtures"
 
 
+@pytest.mark.parametrize(
+    "name, suffix",
+    [
+        ("module", ".js"),
+        ("module.ext", ".ext"),
+        ("[email protected]", ".js"),
+        ("[email protected]", ".ext"),
+        ("@namespace/module", ".js"),
+        ("@namespace/module.ext", ".ext"),
+        ("@namespace/[email protected]", ".js"),
+        ("@namespace/[email protected]", ".ext"),
+    ],
+)
+def test_module_name_suffix(name, suffix):
+    assert module_name_suffix(name) == suffix
+
+
 @responses.activate
 def test_resolve_module_exports_from_file(caplog):
     responses.add(