Skip to content

Commit 5b1dbd2

Browse files
author
Alessio Civitillo
committed
Merge branch 'main' of https://github.com/acivitillo/idom into form_serialize
2 parents d3da1af + 942a302 commit 5b1dbd2

39 files changed

+684
-240
lines changed

.github/ISSUE_TEMPLATE/issue-form.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,3 @@ body:
1414
description: Describe what ought to be done, and why that will address the reasons for action mentioned above.
1515
validations:
1616
required: false
17-
- type: textarea
18-
attributes:
19-
label: Work Items
20-
description: |
21-
An itemized list or detailed description of the work to be done to based on the proposed actions above.
22-
validations:
23-
required: false

.pre-commit-config.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,6 @@ repos:
33
rev: 22.1.0
44
hooks:
55
- id: black
6-
- repo: https://github.com/PyCQA/flake8
7-
rev: 3.7.9
8-
hooks:
9-
- id: flake8
106
- repo: https://github.com/pycqa/isort
117
rev: 5.6.3
128
hooks:

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
0.36.0
1+
0.36.3

docs/source/_custom_js/package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/source/developing-idom/changelog.rst

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,48 @@ team are working on, or have feedback on how issues should be prioritized, feel
77
:discussion-type:`open up a discussion <question>`.
88

99

10+
0.36.3
11+
------
12+
13+
Misc bug fixes along with a minor improvement that allows components to return ``None``
14+
to render nothing.
15+
16+
**Closed Issues**
17+
18+
- All child states wiped upon any child key change - :issue:`652`
19+
- Allow NoneType returns within components - :issue:`538`
20+
21+
**Merged Pull Requests**
22+
23+
- fix #652 - :pull:`672`
24+
- Fix 663 - :pull:`667`
25+
26+
27+
0.36.2
28+
------
29+
30+
Hot fix for newly introduced ``DeprecatedOption``:
31+
32+
- :commit:`c146dfb264cbc3d2256a62efdfe9ccf62c795b01`
33+
34+
35+
0.36.1
36+
------
37+
38+
Includes bug fixes and renames the configuration option ``IDOM_WED_MODULES_DIR`` to
39+
``IDOM_WEB_MODULES_DIR`` with a corresponding deprecation warning.
40+
41+
**Closed Issues**
42+
43+
- Fix Key Error When Cleaning Up Event Handlers - :issue:`640`
44+
- Update Script Tag Behavior - :issue:`628`
45+
46+
**Merged Pull Requests**
47+
48+
- mark old state as None if unmounting - :pull:`641`
49+
- rename IDOM_WED_MODULES_DIR to IDOM_WEB_MODULES_DIR - :pull:`638`
50+
51+
1052
0.36.0
1153
------
1254

docs/source/developing-idom/contributor-guide.rst

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -297,8 +297,7 @@ following commands using the ``<format>`` of your choosing (``rst``, ``md``, ``t
297297

298298
.. code-block:: bash
299299
300-
nox -s latest_closed_issues -- <format>
301-
nox -s latest_pull_requests -- <format>
300+
nox -s changes_since_release -- <format>
302301
303302
Once the version has been updated and the changelog entry completed, you should commit
304303
the changes.

noxfile.py

Lines changed: 4 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -248,16 +248,7 @@ def test_docs(session: Session) -> None:
248248
)
249249
session.run("sphinx-build", "-b", "doctest", "docs/source", "docs/build")
250250
# ensure docker image build works too
251-
# session.run(
252-
# "docker",
253-
# "build",
254-
# ".",
255-
# "--file",
256-
# "docs/Dockerfile",
257-
# "--tag",
258-
# "idom-docs:latest",
259-
# external=True,
260-
# )
251+
session.run("docker", "build", ".", "--file", "docs/Dockerfile", external=True)
261252

262253

263254
@do_first
@@ -359,17 +350,10 @@ def update_version(session: Session) -> None:
359350

360351

361352
@nox.session(reuse_venv=True)
362-
def latest_pull_requests(session: Session) -> None:
363-
"""A basic script for outputing changelog info"""
353+
def changes_since_release(session: Session) -> None:
354+
"""Output the latest changes since the last release"""
364355
session.install("requests", "python-dateutil")
365-
session.run("python", "scripts/latest_pull_requests.py", *session.posargs)
366-
367-
368-
@nox.session(reuse_venv=True)
369-
def latest_closed_issues(session: Session) -> None:
370-
"""A basic script for outputing changelog info"""
371-
session.install("requests", "python-dateutil")
372-
session.run("python", "scripts/latest_closed_issues.py", *session.posargs)
356+
session.run("python", "scripts/changes_since_release.py", *session.posargs)
373357

374358

375359
def install_requirements_file(session: Session, name: str) -> None:

requirements/check-style.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,5 @@ flake8-print
55
flake8-tidy-imports
66
isort >=5.7.0
77
pep8-naming
8+
# pydocstyle
9+
git+https://github.com/PyCQA/pydocstyle.git@bd4993345a241bd0d5128f21de56394b1cde3714#egg=pydocstyle

requirements/pkg-extras.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ uvicorn[standard] >=0.13.4
1212

1313
# extra=flask
1414
flask<2.0
15+
markupsafe<2.1
1516
flask-cors
1617
flask-sockets
1718

scripts/changes_since_release.py

Lines changed: 56 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
1+
from __future__ import annotations
2+
3+
import sys
4+
5+
from common.github_utils import (
6+
REPO_NAME,
7+
date_range_query,
8+
last_release_date,
9+
search_idom_repo,
10+
)
11+
12+
13+
SECTION_FORMAT_TEMPLATES = {
14+
"md": lambda title: f"# {title}",
15+
"rst": lambda title: f"**{title}**\n",
16+
"text": lambda title: f"{title}\n{'-' * len(title)}",
17+
}
18+
19+
20+
ISSUE_FORMAT_TEMPLATES = {
21+
"md": lambda title, number, **_: f"- {title} - [#{number}](https://github.com/{REPO_NAME}/issues/{number})",
22+
"rst": lambda title, number, **_: f"- {title} - :issue:`{number}`",
23+
"text": lambda title, number, **_: f"- {title} - #{number}",
24+
}
25+
26+
PULL_REQUEST_FORMAT_TEMPLATES = {
27+
"md": lambda title, number, **_: f"- {title} - [#{number}](https://github.com/{REPO_NAME}/pull/{number})",
28+
"rst": lambda title, number, **_: f"- {title} - :pull:`{number}`",
29+
"text": lambda title, number, **_: f"- {title} - #{number}",
30+
}
31+
32+
33+
def show_issues(format: str):
34+
print(SECTION_FORMAT_TEMPLATES[format]("Closed Issues"))
35+
template = ISSUE_FORMAT_TEMPLATES[format]
36+
query = f"type:issue closed:{date_range_query(last_release_date())}"
37+
for issue in search_idom_repo(query):
38+
print(template(**issue))
39+
40+
41+
def show_pull_requests(format: str = "text"):
42+
print(SECTION_FORMAT_TEMPLATES[format]("Merged Pull Requests"))
43+
template = PULL_REQUEST_FORMAT_TEMPLATES[format]
44+
query = f"type:pr merged:{date_range_query(last_release_date())}"
45+
for pull in search_idom_repo(query):
46+
print(template(**pull))
47+
48+
49+
def main(format: str = "text"):
50+
for func in [show_issues, show_pull_requests]:
51+
func(format)
52+
print()
53+
54+
55+
if __name__ == "__main__":
56+
main(*sys.argv[1:])

0 commit comments

Comments
 (0)