Fix unmount (#901)

* remove upper bound

* revert #886 + add test + misc

* changelog entry

* changes for latest black

Author: rmorshea

docs/source/_exts/idom_example.py

@@ -18,7 +18,6 @@
 
 
 class WidgetExample(SphinxDirective):
-
     has_content = False
     required_arguments = 1
     _next_id = 0

docs/source/_exts/idom_view.py

@@ -13,7 +13,6 @@
 
 
 class IteractiveWidget(SphinxDirective):
-
     has_content = False
     required_arguments = 1
     _next_id = 0

docs/source/about/changelog.rst

@@ -23,7 +23,13 @@ more info, see the :ref:`Contributor Guide <Creating a Changelog Entry>`.
 Unreleased
 ----------
 
-No changes.
+**Reverted**
+
+- :pull:`901` - reverts :pull:`886` due to :issue:`896`
+
+**Fixed**
+
+- :issue:`896` - Stale event handlers after disconnect/reconnect cycle
 
 
 v1.0.0-a1

requirements/pkg-deps.txt

@@ -7,4 +7,4 @@ requests >=2
 colorlog >=6
 asgiref >=3
 lxml >=4
-click >=8, <9
+click >=8

src/client/packages/idom-client-react/src/mount.js

@@ -38,6 +38,9 @@ function mountLayoutWithReconnectingWebSocket(
   socket.onopen = (event) => {
     console.info(`IDOM WebSocket connected.`);
 
+    if (mountState.everMounted) {
+      ReactDOM.unmountComponentAtNode(element);
+    }
     _resetOpenMountState(mountState);
 
     mountLayout(element, {

src/idom/backend/tornado.py

@@ -158,7 +158,6 @@ def _setup_single_view_dispatcher_route(
 
 
 class IndexHandler(RequestHandler):
-
     _index_html: str
 
     def initialize(self, index_html: str) -> None:

src/idom/core/hooks.py

@@ -75,7 +75,6 @@ def use_state(initial_value: _Type | Callable[[], _Type]) -> State[_Type]:
 
 
 class _CurrentState(Generic[_Type]):
-
     __slots__ = "value", "dispatch"
 
     def __init__(
@@ -148,11 +147,9 @@ def use_effect(
     last_clean_callback: Ref[Optional[_EffectCleanFunc]] = use_ref(None)
 
     def add_effect(function: _EffectApplyFunc) -> None:
-
         if not asyncio.iscoroutinefunction(function):
             sync_function = cast(_SyncEffectFunc, function)
         else:
-
             async_function = cast(_AsyncEffectFunc, function)
 
             def sync_function() -> Optional[_EffectCleanFunc]:

src/idom/core/layout.py

@@ -651,7 +651,6 @@ class _LifeCycleState(NamedTuple):
 
 
 class _ThreadSafeQueue(Generic[_Type]):
-
     __slots__ = "_loop", "_queue", "_pending"
 
     def __init__(self) -> None:

src/idom/core/vdom.py

@@ -258,7 +258,6 @@ def separate_attributes_and_event_handlers(
     separated_handlers: DefaultDict[str, list[EventHandlerType]] = DefaultDict(list)
 
     for k, v in attributes.items():
-
         handler: EventHandlerType
 
         if callable(v):

src/idom/testing/common.py

@@ -56,6 +56,7 @@ async def until(
         condition: Callable[[_R], bool],
         timeout: float = IDOM_TESTING_DEFAULT_TIMEOUT.current,
         delay: float = _DEFAULT_POLL_DELAY,
+        description: str = "condition to be true",
     ) -> None:
         """Check that the coroutines result meets a condition within the timeout"""
         started_at = time.time()
@@ -66,7 +67,7 @@ async def until(
                 break
             elif (time.time() - started_at) > timeout:  # pragma: no cover
                 raise TimeoutError(
-                    f"Condition not met within {timeout} "
+                    f"Expected {description} after {timeout} "
                     f"seconds - last value was {result!r}"
                 )
 
@@ -77,7 +78,12 @@ async def until_is(
         delay: float = _DEFAULT_POLL_DELAY,
     ) -> None:
         """Wait until the result is identical to the given value"""
-        return await self.until(lambda left: left is right, timeout, delay)
+        return await self.until(
+            lambda left: left is right,
+            timeout,
+            delay,
+            f"value to be identical to {right!r}",
+        )
 
     async def until_equals(
         self,
@@ -86,7 +92,12 @@ async def until_equals(
         delay: float = _DEFAULT_POLL_DELAY,
     ) -> None:
         """Wait until the result is equal to the given value"""
-        return await self.until(lambda left: left == right, timeout, delay)
+        return await self.until(
+            lambda left: left == right,
+            timeout,
+            delay,
+            f"value to equal {right!r}",
+        )
 
 
 class HookCatcher: