Skip to content

Conversation

@bdwade100
Copy link
Contributor

@bdwade100 bdwade100 commented Aug 26, 2018

This pull request fixes issue #324.

@bdwade100
Copy link
Contributor Author

Let me know if you have any questions.

…t (for example, in tabs) causes a failure.
@bdwade100
Copy link
Contributor Author

bdwade100 commented Jan 9, 2019

@jerairrest, please review this pull request. We have used it in production code since Oct 2018 and would love to pull it from your npm module.

Let me know if you have any questions. Thanks!

@bdwade100
Copy link
Contributor Author

@jerairrest , thanks for considering this pull request. If it would help, I can add additional comments to the code or review them with you. I did a force push so that this pull request is one change from your current branch.

@bdwade100
Copy link
Contributor Author

Hi @jerairrest , I haven't heard anything back from you on my previous posts to review this pull request, so I'm getting the sense that you're not interested in it.

I'd consider it a personal favor if you would let me know either way, and I can stop sending requests to review the pull request which I'm sure you can appreciate.

Respectfully,
Brad

@jerairrest
Copy link
Collaborator

Hey Brad!

I apologise for being MIA from this project. :( I'll attempt to look at this pull request tonight.

Thanks for contributing

Jer

@jerairrest jerairrest merged commit 3d13c37 into reactchartjs:master Mar 26, 2019
@bdwade100
Copy link
Contributor Author

Thanks, Jeremy, for looking at my PR and merging it.

Brad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants