From a433f8f6d6d710ccb6311c1bd5c2728cdff2b1f3 Mon Sep 17 00:00:00 2001
From: Mark Nevill <mark.nevill@gmail.com>
Date: Tue, 15 Feb 2022 09:54:23 +0000
Subject: [PATCH] feat: allow passing executor parameters to test jobs

closes #112
---
 src/jobs/android_test.yml       | 15 +++++++++++++--
 src/jobs/ios_build_and_test.yml | 15 +++++++++++++--
 2 files changed, 26 insertions(+), 4 deletions(-)

diff --git a/src/jobs/android_test.yml b/src/jobs/android_test.yml
index 7094acc..847c7be 100644
--- a/src/jobs/android_test.yml
+++ b/src/jobs/android_test.yml
@@ -1,7 +1,5 @@
 description: Tests the Android app on the given device, with the given Detox configuration. You should have already built the correct Android APK (including the androidTest APK) and have both persisted to the worksapce.
 
-executor: macos
-
 parameters:
   # For this job
   workspace_root:
@@ -76,6 +74,19 @@ parameters:
     description: Should we run brew update? Defaults to true
     type: boolean
     default: true
+  xcode_version:
+    description: The version of Xcode to use. See here for the list of supported versions https://circleci.com/docs/2.0/testing-ios/#supported-xcode-versions
+    type: string
+    default: "12.4.0"
+  resource_class:
+    description: Changes the resource class of the executor. Requires a support request to enable the resource_class parameter. See https://circleci.com/docs/2.0/configuration-reference/#resource_class
+    type: string
+    default: medium
+
+executor:
+  name: macos
+  xcode_version: <<parameters.xcode_version>>
+  resource_class: <<parameters.resource_class>>
 
 steps:
   - attach_workspace:
diff --git a/src/jobs/ios_build_and_test.yml b/src/jobs/ios_build_and_test.yml
index 1d45e39..b3fb796 100644
--- a/src/jobs/ios_build_and_test.yml
+++ b/src/jobs/ios_build_and_test.yml
@@ -1,7 +1,5 @@
 description: Builds the iOS app at the given path with the given build scheme and configuration and then runs the tests with the Detox configuration given.
 
-executor: macos
-
 parameters:
   # For this job
   checkout:
@@ -95,6 +93,19 @@ parameters:
     description: Should we run brew update? Defaults to true
     type: boolean
     default: true
+  xcode_version:
+    description: The version of Xcode to use. See here for the list of supported versions https://circleci.com/docs/2.0/testing-ios/#supported-xcode-versions
+    type: string
+    default: "12.4.0"
+  resource_class:
+    description: Changes the resource class of the executor. Requires a support request to enable the resource_class parameter. See https://circleci.com/docs/2.0/configuration-reference/#resource_class
+    type: string
+    default: medium
+
+executor:
+  name: macos
+  xcode_version: <<parameters.xcode_version>>
+  resource_class: <<parameters.resource_class>>
 
 steps:
   - when: