Skip to content

fix(ios): update default ios device to iPhone 11 #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2022
Merged

fix(ios): update default ios device to iPhone 11 #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ workflows:
- rn/ios_build:
name: build_ios_release
project_path: ios/Example.xcodeproj
device: "iPhone X"
device: "iPhone 11"
build_configuration: Release
scheme: Example
requires:
Expand All @@ -130,7 +130,7 @@ workflows:
# Build and test the iOS app in release mode
- rn/ios_build_and_test:
project_path: "ios/Example.xcodeproj"
device: "iPhone X"
device: "iPhone 11"
build_configuration: "Release"
scheme: "Example"
detox_configuration: "ios.sim.release"
Expand Down
2 changes: 1 addition & 1 deletion src/commands/ios_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ parameters:
device:
description: The type of device you want to build for.
type: string
default: "iPhone X"
default: "iPhone 11"
scheme:
description: The scheme to use.
type: string
Expand Down
2 changes: 1 addition & 1 deletion src/commands/ios_simulator_start.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ parameters:
device:
description: The type of device you want to start.
type: string
default: "iPhone X"
default: "iPhone 11"
background:
default: true
description: Should ios simulator boot in background?
Expand Down
4 changes: 2 additions & 2 deletions src/examples/full.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ usage:
name: build_ios_release
node_version: '12'
project_path: ios/Example.xcodeproj
device: "iPhone X"
device: "iPhone 11"
build_configuration: Release
scheme: Example
requires:
Expand All @@ -101,7 +101,7 @@ usage:
- rn/ios_build_and_test:
node_version: '12'
project_path: "ios/Example.xcodeproj"
device: "iPhone X"
device: "iPhone 11"
build_configuration: "Release"
scheme: "Example"
detox_configuration: "ios.sim.release"
Expand Down
4 changes: 2 additions & 2 deletions src/examples/ios.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ usage:
- rn/ios_build:
name: build_ios_release
project_path: ios/Example.xcodeproj
device: "iPhone X"
device: "iPhone 11"
build_configuration: Release
scheme: Example
requires:
Expand All @@ -71,7 +71,7 @@ usage:
# Build and test the iOS app in release mode
- rn/ios_build_and_test:
project_path: "ios/Example.xcodeproj"
device: "iPhone X"
device: "iPhone 11"
build_configuration: "Release"
scheme: "Example"
detox_configuration: "ios.sim.release"
Expand Down
2 changes: 1 addition & 1 deletion src/jobs/ios_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ parameters:
device:
description: The type of device you want to build for.
type: string
default: "iPhone X"
default: "iPhone 11"
scheme:
description: The scheme to use.
type: string
Expand Down
2 changes: 1 addition & 1 deletion src/jobs/ios_build_and_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ parameters:
device:
description: The type of device you want to build for.
type: string
default: "iPhone X"
default: "iPhone 11"
scheme:
description: The scheme to use.
type: string
Expand Down