cleanup code

Author: silkentrance

test/assertions.js

@@ -23,7 +23,7 @@ module.exports.assertMode = function assertMode(name, mode) {
   // mode values do not work properly on Windows. Ignore “group” and
   // “other” bits then. Ignore execute bit on that platform because it
   // doesn’t exist—even for directories.
-  if (process.platform == 'win32') {
+  if (process.platform === 'win32') {
     assert.equal(stat.mode & 0o600, mode & 0o600);
   } else {
     assert.equal(stat.mode & 0o777, mode);

test/outband/unlink.js

@@ -3,6 +3,8 @@ const fs = require('fs');
 module.exports = function (result) {
   const stat = fs.statSync(result.name);
   if (stat.isFile()) {
+    // TODO must also close the file, otherwise the file will be closed during garbage collection, which we do not want
+    // TODO #241 get rid of the open file descriptor
     fs.unlinkSync(result.name);
   } else {
     fs.rmdirSync(result.name);

test/outband/unsafe.js

@@ -15,12 +15,11 @@ module.exports = function (result) {
   // symlink that should be removed but the contents should be preserved.
   // Skip on Windows because symlinks require elevated privileges (instead just
   // create the file)
-  if (process.platform == 'win32') {
+  if (process.platform === 'win32') {
     fs.writeFileSync(symlinkTarget);
   } else {
     fs.symlinkSync(symlinkSource, symlinkTarget, 'dir');
   }
 
   this.out(result.name);
 };
-