Skip to content
This repository was archived by the owner on Feb 27, 2023. It is now read-only.

Conversation

@procount
Copy link
Contributor

@procount procount commented Nov 9, 2020

This modification allows NOOBS to automatically switch to the correct HDMI port according to which is connected to a monitor.
The precedence is: DSI, HDMI0, HDMI1.
I'm not sure if line recovery/init#42 is absolutely necessary, but I left it in.

(I also included setting PS1 in the root/.profile file, which I think helps anyone who decides to use the shell, but delete if you want)



CON2FBMAP_VERSION = 1.0
CON2FBMAP_SITE = $(TOPDIR)/../con2fbmap
Copy link
Collaborator

@lurch lurch Nov 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably makes sense to move the con2fbmap files down into this subdirectory, rather than adding an extra directory at the top-level? (but it's been a long time since I've messed around with Buildroot, so please accept my apologies if that wouldn't work!)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put it at the same level as my rebootp package in PINN, keeping it separate from buildroot.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, I'll defer this decision to @maxnet / @XECDesign

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, I'll defer this decision to @maxnet / @XECDesign

Not mine to make.
Just dropping by here as normal bystander, as someone mentioned my name :-)
Have not been involved with NOOBS in recent years.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just dropping by here as normal bystander, as someone mentioned my name :-)

🙂 👋

Have not been involved with NOOBS in recent years.

Ditto. I was only mentioning your name because you have more recent buildroot experience than me. Apologies if I gave the wrong impression.

@lurch
Copy link
Collaborator

lurch commented Nov 9, 2020

I've not tested this, but if it works I guess it'd be super-useful for Pi400 owners, where the HDMI0 / HDMI1 distinction isn't labelled 🙂

@lurch
Copy link
Collaborator

lurch commented Nov 9, 2020

(I also included setting PS1 in the root/.profile file, which I think helps anyone who decides to use the shell, but delete if you want)

It's up to @XECDesign , but it might be worth making that a separate PR? Personally, I always prefer separate PRs for seperate "things".

For those of us with rusty PS1 knowledge, could you tell us what the shell prompt looks like before and after this change? 🐚

@procount
Copy link
Contributor Author

I've not tested this, but if it works I guess it'd be super-useful for Pi400 owners, where the HDMI0 / HDMI1 distinction isn't labelled

That's where the idea came from. I built and tested it in NOOBS with DSI touchscreen, HDMI0 and HDMI1 connection combinations. It's already in PINN and working nicely. I haven't tested it with my pinn_init script for configuring the pimoroni hyperpixels, but those drivers need looking at anyway.

it might be worth making that a separate PR?

I thought about that, and I remembered that thought again, just after I'd squashed the commits ;) But hey, I can separate it out again if necessary.

Before this change the shell prompt is just a '#' symbol. Nothing else.
After this change, it looks more like the standard User@hostname: <pwd> # . It makes it a lot easier to know where you are in the file tree.

@procount procount mentioned this pull request Nov 10, 2020
@raspberrypi raspberrypi deleted a comment Nov 25, 2020
@raspberrypi raspberrypi deleted a comment Nov 25, 2020
@lurch lurch mentioned this pull request Nov 29, 2020
@XECDesign XECDesign merged commit 4409f7d into raspberrypi:master Jan 12, 2022
@XECDesign
Copy link
Contributor

Many thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants