Skip to content

Commit 7b33fe3

Browse files
committed
Remove fix to use rake-compiler-dock on Windows for libiconv
The original author states that the code I removed is for using virtualbox on Windows to compile the gem. I read up on this and while rake-compiler-dock still supports using docker-machine to compile gems, the project has been discontinued in favor of Docker Desktop, which nowadays only works with Docker in WSL2.
1 parent 7e8cb9f commit 7b33fe3

File tree

1 file changed

+0
-17
lines changed

1 file changed

+0
-17
lines changed

tasks/ports/libiconv.rb

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -8,25 +8,8 @@ def initialize(version)
88
set_patches
99
end
1010

11-
def cook
12-
chdir_for_build do
13-
super
14-
end
15-
self
16-
end
17-
1811
private
1912

20-
# When using rake-compiler-dock on Windows, the underlying Virtualbox shared
21-
# folders don't support symlinks, but libiconv expects it for a build on
22-
# Linux. We work around this limitation by using the temp dir for cooking.
23-
def chdir_for_build
24-
build_dir = ENV['RCD_HOST_RUBY_PLATFORM'].to_s =~ /mingw|mswin|cygwin/ ? '/tmp' : '.'
25-
Dir.chdir(build_dir) do
26-
yield
27-
end
28-
end
29-
3013
def configure_defaults
3114
[
3215
"--host=#{@host}",

0 commit comments

Comments
 (0)