Style

Author: bf4

lib/active_model/serializer/association.rb

@@ -46,18 +46,18 @@ def meta
       end
 
       def object
-        @object ||= @wip_isolated_options[:association_options].fetch(:reflection).
-          value(
-            @wip_isolated_options[:association_options].fetch(:parent_serializer),
-            @wip_isolated_options[:association_options].fetch(:include_slice)
-        )
+        @object ||= @wip_isolated_options[:association_options].fetch(:reflection)
+                                                               .value(
+                                                                 @wip_isolated_options[:association_options].fetch(:parent_serializer),
+                                                                 @wip_isolated_options[:association_options].fetch(:include_slice)
+                                                               )
       end
-      alias eval_reflection_block object
+      alias_method :eval_reflection_block, :object
 
       def include_data?
         eval_reflection_block if @wip_isolated_options[:association_options].fetch(:reflection).block
-        @wip_isolated_options[:association_options].fetch(:reflection).
-          include_data?(@wip_isolated_options[:association_options].fetch(:include_slice))
+        @wip_isolated_options[:association_options].fetch(:reflection)
+                                                   .include_data?(@wip_isolated_options[:association_options].fetch(:include_slice))
       end
 
       # @return [ActiveModel::Serializer, nil]
@@ -93,6 +93,8 @@ def serialize_object!(object)
         end
       end
 
+      # NOTE(BF): This serializer throw/catch should only happen when the serializer is a collection
+      # serializer.  This is a good reason for the reflection to have a to_many? type method.
       def instantiate_serializer(object)
         serializer = catch(:no_serializer) do
           serializer_options = @wip_isolated_options[:association_options].fetch(:parent_serializer_options).except(:serializer)

test/serializers/associations_test.rb

@@ -380,7 +380,7 @@ def setup
 
         test 'a serializer inheriting from another serializer can have an additional association with the same name but with different key' do
           expected = [:author, :comments, :blog, :reviews].sort
-          result = @inherited_post_serializer.associations.map { |a| a.key }.sort
+          result = @inherited_post_serializer.associations.map(&:key).sort
           assert_equal(result, expected)
         end
       end