From 00c783aee5085e9994cd84c3c8d53ecf83caeaff Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Arnaud=20Cogolu=C3=A8gnes?= <514737+acogoluegnes@users.noreply.github.com> Date: Fri, 28 Mar 2025 08:52:34 +0100 Subject: [PATCH 1/2] Use "balanced" for leader locator default value References rabbitmq/rabbitmq-stream-java-client#732 --- src/main/java/com/rabbitmq/stream/perf/StreamPerfTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/rabbitmq/stream/perf/StreamPerfTest.java b/src/main/java/com/rabbitmq/stream/perf/StreamPerfTest.java index 5cdb43e..37967f8 100644 --- a/src/main/java/com/rabbitmq/stream/perf/StreamPerfTest.java +++ b/src/main/java/com/rabbitmq/stream/perf/StreamPerfTest.java @@ -260,7 +260,7 @@ void setDeleteStreams(String input) throws Exception { "leader locator strategy for created stream. " + "Possible values: client-local, balanced (RabbitMQ 3.10), least-leaders, random.", converter = Converters.LeaderLocatorTypeConverter.class, - defaultValue = "least-leaders") + defaultValue = "balanced") private LeaderLocator leaderLocator; @CommandLine.Option( From 00eff33ffcf66f4016e032e01544030ee48fe5a6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Arnaud=20Cogolu=C3=A8gnes?= <514737+acogoluegnes@users.noreply.github.com> Date: Fri, 28 Mar 2025 09:07:09 +0100 Subject: [PATCH 2/2] Fix test --- .../java/com/rabbitmq/stream/perf/StreamPerfTestTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/test/java/com/rabbitmq/stream/perf/StreamPerfTestTest.java b/src/test/java/com/rabbitmq/stream/perf/StreamPerfTestTest.java index 8535d82..e2b8a89 100644 --- a/src/test/java/com/rabbitmq/stream/perf/StreamPerfTestTest.java +++ b/src/test/java/com/rabbitmq/stream/perf/StreamPerfTestTest.java @@ -313,7 +313,7 @@ void streamCreationIsIdempotentWhateverTheDifferencesInStreamProperties() throws new StreamParametersBuilder() .maxLengthBytes(ByteCapacity.GB(1)) .maxSegmentSizeBytes(ByteCapacity.MB(500)) - .leaderLocator(LeaderLocator.LEAST_LEADERS) + .leaderLocator(LeaderLocator.BALANCED) .build()); assertThat(response.isOk()).isTrue(); Future run = @@ -321,7 +321,7 @@ void streamCreationIsIdempotentWhateverTheDifferencesInStreamProperties() throws builder() .maxLengthBytes(ByteCapacity.GB(42)) // different from already existing stream .streamMaxSegmentSizeBytes(ByteCapacity.MB(500)) - .leaderLocator(LeaderLocator.LEAST_LEADERS)); + .leaderLocator(LeaderLocator.BALANCED)); waitOneSecond(); run.cancel(true); waitRunEnds();