Hide credit settings

Revert the public API part of f78ac08.

Providing 1 initial credit on subscription and another 1
on each incoming chunk seems appropriate for most use cases.

We'll provide more options if necessary.

References #262

Author: acogoluegnes

src/main/java/com/rabbitmq/stream/ConsumerBuilder.java

@@ -151,18 +151,6 @@ public interface ConsumerBuilder {
    */
   ConsumerBuilder noTrackingStrategy();
 
-  /**
-   * Define credit values for the subscription.
-   *
-   * <p>This is an experimental API, subject to change.
-   *
-   * @param initial the initial number of credits, default is 10
-   * @param onChunkDelivery the number of credits provided on each chunk delivery, default is 1
-   * @return this builder instance
-   * @since 0.10.0
-   */
-  ConsumerBuilder credits(int initial, int onChunkDelivery);
-
   /**
    * Create the configured {@link Consumer}
    *

src/main/java/com/rabbitmq/stream/impl/ConsumersCoordinator.java

@@ -943,7 +943,6 @@ synchronized void add(
             subscriptionContext.offsetSpecification());
 
         checkNotClosed();
-        // FIXME consider using fewer initial credits
         byte subId = subscriptionId;
         Client.Response subscribeResponse =
             Utils.callAndMaybeRetry(

src/main/java/com/rabbitmq/stream/impl/StreamConsumerBuilder.java

@@ -132,7 +132,6 @@ public ConsumerBuilder noTrackingStrategy() {
     return this;
   }
 
-  @Override
   public ConsumerBuilder credits(int initial, int onChunkDelivery) {
     if (initial <= 0 || onChunkDelivery <= 0) {
       throw new IllegalArgumentException("Credits must be positive");

src/main/java/com/rabbitmq/stream/perf/StreamPerfTest.java

@@ -418,7 +418,7 @@ public class StreamPerfTest implements Callable<Integer> {
   @CommandLine.Option(
       names = {"--credits", "-cr"},
       description = "initial and additional credits for subscriptions",
-      defaultValue = "10:1",
+      defaultValue = "1:1",
       converter = Utils.CreditsTypeConverter.class)
   private CreditSettings credits;
 
@@ -994,10 +994,7 @@ public Integer call() throws Exception {
                         AtomicLong messageCount = new AtomicLong(0);
                         String stream = stream(streams, i);
                         ConsumerBuilder consumerBuilder =
-                            environment
-                                .consumerBuilder()
-                                .offset(this.offset)
-                                .credits(this.credits.initial(), this.credits.additional());
+                            environment.consumerBuilder().offset(this.offset);
 
                         if (this.superStreams) {
                           consumerBuilder.superStream(stream);

src/test/java/com/rabbitmq/stream/impl/ClientFlowControlTest.java

@@ -21,7 +21,8 @@
 import com.rabbitmq.stream.OffsetSpecification;
 import com.rabbitmq.stream.impl.Client.ClientParameters;
 import java.util.concurrent.CountDownLatch;
-import java.util.concurrent.atomic.AtomicInteger;import java.util.concurrent.atomic.AtomicReference;
+import java.util.concurrent.atomic.AtomicInteger;
+import java.util.concurrent.atomic.AtomicReference;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.TestInfo;
 import org.junit.jupiter.api.extension.ExtendWith;