Skip to content
This repository was archived by the owner on Nov 18, 2020. It is now read-only.

Commit d1099e8

Browse files
committed
Handle 21.3 tls_alert error format.
1 parent 5e25ab4 commit d1099e8

File tree

1 file changed

+25
-15
lines changed

1 file changed

+25
-15
lines changed

src/rabbit_stomp_reader.erl

Lines changed: 25 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -288,24 +288,23 @@ log_reason({network_error, {ssl_upgrade_error, closed}, ConnStr}, _State) ->
288288
rabbit_log_connection:error("STOMP detected TLS upgrade error on ~s: connection closed~n",
289289
[ConnStr]);
290290

291-
log_reason({network_error,
292-
{ssl_upgrade_error,
293-
{tls_alert, "handshake failure"}}, ConnStr}, _State) ->
294-
rabbit_log_connection:error("STOMP detected TLS upgrade error on ~s: handshake failure~n",
295-
[ConnStr]);
296291

297292
log_reason({network_error,
298-
{ssl_upgrade_error,
299-
{tls_alert, "unknown ca"}}, ConnStr}, _State) ->
300-
rabbit_log_connection:error("STOMP detected TLS certificate verification error on ~s: alert 'unknown CA'~n",
301-
[ConnStr]);
302-
293+
{ssl_upgrade_error,
294+
{tls_alert, "handshake failure"}}, ConnStr}, _State) ->
295+
log_tls_alert(handshake_failure, ConnStr);
303296
log_reason({network_error,
304-
{ssl_upgrade_error,
305-
{tls_alert, Alert}}, ConnStr}, _State) ->
306-
rabbit_log_connection:error("STOMP detected TLS upgrade error on ~s: alert ~s~n",
307-
[ConnStr, Alert]);
308-
297+
{ssl_upgrade_error,
298+
{tls_alert, "unknown ca"}}, ConnStr}, _State) ->
299+
log_tls_alert(unknown_ca, ConnStr);
300+
log_reason({network_error,
301+
{ssl_upgrade_error,
302+
{tls_alert, {Err, _}}}, ConnStr}, _State) ->
303+
log_tls_alert(Err, ConnStr);
304+
log_reason({network_error,
305+
{ssl_upgrade_error,
306+
{tls_alert, Alert}}, ConnStr}, _State) ->
307+
log_tls_alert(Alert, ConnStr);
309308
log_reason({network_error, {ssl_upgrade_error, Reason}, ConnStr}, _State) ->
310309
rabbit_log_connection:error("STOMP detected TLS upgrade error on ~s: ~p~n",
311310
[ConnStr, Reason]);
@@ -334,6 +333,17 @@ log_reason(Reason, #reader_state{ processor_state = ProcState }) ->
334333
rabbit_log:warning("STOMP connection ~s terminated"
335334
" with reason ~p, closing it~n", [AdapterName, Reason]).
336335

336+
log_tls_alert(handshake_failure, ConnStr) ->
337+
rabbit_log_connection:error("STOMP detected TLS upgrade error on ~s: handshake failure~n",
338+
[ConnStr]);
339+
log_tls_alert(unknown_ca, ConnStr) ->
340+
rabbit_log_connection:error("STOMP detected TLS certificate verification error on ~s: alert 'unknown CA'~n",
341+
[ConnStr]);
342+
log_tls_alert(Alert, ConnStr) ->
343+
rabbit_log_connection:error("STOMP detected TLS upgrade error on ~s: alert ~s~n",
344+
[ConnStr, Alert]).
345+
346+
337347
%%----------------------------------------------------------------------------
338348

339349
processor_args(Configuration, Sock) ->

0 commit comments

Comments
 (0)