Skip to content

Commit 64feb7a

Browse files
committed
Delete streams test case
The test suite constructed a wrong filter-set. Specifically the value of the filter-set didn't use a described type as mandated by the spec. Using https://azure.github.io/amqpnetlite/api/Amqp.Types.DescribedValue.html throws errors that the descriptor can't be encoded. Given that this code path is already tests via the amqp_filtex_SUITE, this F# test gets therefore deleted.
1 parent 9a79b59 commit 64feb7a

File tree

2 files changed

+1
-48
lines changed

2 files changed

+1
-48
lines changed

deps/rabbit/test/amqp_system_SUITE.erl

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,7 @@ groups() ->
4040
auth_failure,
4141
access_failure,
4242
access_failure_not_allowed,
43-
access_failure_send,
44-
streams
43+
access_failure_send
4544
]},
4645
{java, [], [
4746
roundtrip
@@ -122,10 +121,6 @@ roundtrip(Config) ->
122121
run(Config, [{dotnet, "roundtrip"},
123122
{java, "RoundTripTest"}]).
124123

125-
streams(Config) ->
126-
declare_queue(Config, ?FUNCTION_NAME, "stream"),
127-
run(Config, [{dotnet, "streams"}]).
128-
129124
roundtrip_to_amqp_091(Config) ->
130125
declare_queue(Config, ?FUNCTION_NAME, "classic"),
131126
run(Config, [{dotnet, "roundtrip_to_amqp_091"}]).

deps/rabbit/test/amqp_system_SUITE_data/fsharp-tests/Program.fs

Lines changed: 0 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -179,45 +179,6 @@ module Test =
179179
assertEqual rtd.Properties.CorrelationId corr
180180
()
181181

182-
let streams uri =
183-
use c = connectAnon uri
184-
let name = "streams-test"
185-
let address = "/queues/streams"
186-
let sender = SenderLink(c.Session, name + "-sender" , address)
187-
//for body in sampleTypes do
188-
let body = "hi"B :> obj
189-
190-
let corr = "correlation"
191-
new Message(body,
192-
Properties = new Properties(CorrelationId = corr))
193-
|> sender.Send
194-
//TODO wait for settlement
195-
let specs = [box("first");
196-
box("last");
197-
box("10m");
198-
box(0)]
199-
for spec in specs do
200-
printfn "testing streams spec %A" spec
201-
let filterSet = Map()
202-
filterSet.Add(Symbol "rabbitmq:stream-offset-spec", spec)
203-
let source = Source(Address = address,
204-
FilterSet = filterSet)
205-
let attach = Attach(Source = source)
206-
let attached = new OnAttached (fun _ _ -> ())
207-
let receiver = ReceiverLink(c.Session, Guid.NewGuid().ToString(), attach, attached)
208-
receiver.SetCredit(100, true)
209-
let rtd = receiver.Receive()
210-
assertNotNull rtd
211-
assertEqual 3 rtd.MessageAnnotations.Map.Count
212-
assertTrue (rtd.MessageAnnotations.Map.ContainsKey(Symbol "x-stream-offset"))
213-
assertTrue (rtd.MessageAnnotations.Map.ContainsKey(Symbol "x-exchange"))
214-
assertTrue (rtd.MessageAnnotations.Map.ContainsKey(Symbol "x-routing-key"))
215-
216-
assertEqual body rtd.Body
217-
assertEqual rtd.Properties.CorrelationId corr
218-
receiver.Close()
219-
()
220-
221182
open RabbitMQ.Client
222183

223184
let roundtrip_to_amqp_091 uri =
@@ -553,9 +514,6 @@ let main argv =
553514
| [AsLower "invalid_routes"; uri] ->
554515
invalidRoutes uri
555516
0
556-
| [AsLower "streams"; uri] ->
557-
streams uri
558-
0
559517
| [AsLower "no_routes_is_released"; uri] ->
560518
no_routes_is_released uri
561519
0

0 commit comments

Comments
 (0)