Skip to content

Commit 61e4b6e

Browse files
committed
clustering_recovery_SUITE: Skip tests that require RabbitMQ 4.2.0 in mixed-version testing
[Why] The `*_queue_after_partition_recovery_1` testcases rely on the fact that the queue process retries to delete its queue record in its terminate function. RabbitMQ 4.1.x and before don't have that. Thus, depending on the timing of the election of the Khepri leader after a network partition, the test might fail. (cherry picked from commit 69e1703)
1 parent c8ac599 commit 61e4b6e

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

deps/rabbit/test/clustering_recovery_SUITE.erl

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,8 +152,12 @@ init_per_testcase(Testcase, Config) ->
152152
rabbit_ct_client_helpers:setup_steps()),
153153
case Config3 of
154154
_ when is_list(Config3) andalso
155-
(Testcase =:= autodelete_transient_queue_after_partition_recovery_2 orelse
155+
(Testcase =:= autodelete_transient_queue_after_partition_recovery_1 orelse
156+
Testcase =:= autodelete_durable_queue_after_partition_recovery_1 orelse
157+
Testcase =:= autodelete_transient_queue_after_partition_recovery_2 orelse
156158
Testcase =:= autodelete_durable_queue_after_partition_recovery_2 orelse
159+
Testcase =:= exclusive_transient_queue_after_partition_recovery_1 orelse
160+
Testcase =:= exclusive_durable_queue_after_partition_recovery_1 orelse
157161
Testcase =:= exclusive_transient_queue_after_partition_recovery_2 orelse
158162
Testcase =:= exclusive_durable_queue_after_partition_recovery_2) ->
159163
NewEnough = ok =:= rabbit_ct_broker_helpers:enable_feature_flag(
@@ -169,7 +173,7 @@ init_per_testcase(Testcase, Config) ->
169173
rabbit_ct_helpers:testcase_finished(Config3, Testcase),
170174
{skip,
171175
"The old node does not have improvements to "
172-
"rabbit_node_monitor"}
176+
"rabbit_amqqueue_process and rabbit_node_monitor"}
173177
end;
174178
_ ->
175179
%% Other testcases or failure to setup broker and client.

0 commit comments

Comments
 (0)