Fix many Dialyzer warnings

Author: essen

src/lager_exchange_backend.erl

@@ -39,8 +39,8 @@
 -record(state, {level :: {'mask', integer()},
                 formatter :: atom(),
                 format_config :: any(),
-                init_exchange_ts = undefined :: rabbit_types:timestamp(),
-                exchange = undefined :: #resource{}}).
+                init_exchange_ts = undefined :: integer() | undefined,
+                exchange = undefined :: #resource{} | undefined}).
 
 -ifdef(TEST).
 -include_lib("eunit/include/eunit.hrl").

src/lqueue.erl

@@ -30,7 +30,7 @@
               ?MODULE/1
              ]).
 
--opaque ?MODULE() :: {non_neg_integer(), queue:queue(term())}.
+-opaque ?MODULE() :: ?MODULE(_).
 -opaque ?MODULE(T) :: {non_neg_integer(), queue:queue(T)}.
 -type value()     :: any().
 -type result(T)    :: 'empty' | {'value', T}.

src/rabbit.erl

@@ -314,14 +314,10 @@ ensure_config() ->
             log_boot_error_and_exit(check_config_file, ErrFmt, ErrArgs)
     end,
     case rabbit_config:prepare_and_use_config() of
-        {error, Reason} ->
-            {Format, Arg} = case Reason of
-                {generation_error, Error} -> {"~s", [Error]};
-                Other                     -> {"~p", [Other]}
-            end,
+        {error, {generation_error, Error}} ->
             log_boot_error_and_exit(generate_config_file,
-                                    "~nConfig file generation failed "++Format,
-                                    Arg);
+                                    "~nConfig file generation failed ~s",
+                                    Error);
         ok -> ok
     end.
 
@@ -688,6 +684,7 @@ stop_apps(Apps) ->
     end,
     ok.
 
+-spec handle_app_error(_) -> fun((_, _) -> no_return()).
 handle_app_error(Term) ->
     fun(App, {bad_return, {_MFA, {'EXIT', ExitReason}}}) ->
             throw({Term, App, ExitReason});
@@ -1006,6 +1003,7 @@ boot_error(Class, Reason) ->
       [lager:pr_stacktrace(erlang:get_stacktrace(), {Class, Reason})] ++
       LogLocations).
 
+-spec log_boot_error_and_exit(_, _, _) -> no_return().
 log_boot_error_and_exit(Reason, Format, Args) ->
     rabbit_log:error(Format, Args),
     io:format(standard_error, "~nBOOT FAILED~n===========~n" ++ Format ++ "~n", Args),

src/rabbit_config.erl

@@ -121,9 +121,7 @@ maybe_set_net_ticktime(KernelConfig) ->
                     io:format(standard_error,
                         "~nCouldn't set net_ticktime to ~p "
                         "as net_kernel is busy changing net_ticktime to ~p seconds ~n",
-                        [NetTickTime, NewNetTicktime]);
-                _ ->
-                    ok
+                        [NetTickTime, NewNetTicktime])
             end
     end.
 

src/rabbit_health_check.erl

@@ -51,14 +51,15 @@ run_checks([C|Cs]) ->
             Error
     end.
 
+%% A lot of health checks seem to not be able to fail anymore.
 node_health_check(list_channels) ->
     case rabbit_channel:info_local([pid]) of
         L when is_list(L) ->
-            ok;
-        Other ->
-            ErrorMsg = io_lib:format("list_channels unexpected output: ~p",
-                                     [Other]),
-            {error_string, ErrorMsg}
+            ok%;
+%        Other ->
+%            ErrorMsg = io_lib:format("list_channels unexpected output: ~p",
+%                                     [Other]),
+%            {error_string, ErrorMsg}
     end;
 
 node_health_check(list_queues) ->
@@ -67,11 +68,11 @@ node_health_check(list_queues) ->
 node_health_check(rabbit_node_monitor) ->
     case rabbit_node_monitor:partitions() of
         L when is_list(L) ->
-            ok;
-        Other ->
-            ErrorMsg = io_lib:format("rabbit_node_monitor reports unexpected partitions value: ~p",
-                                     [Other]),
-            {error_string, ErrorMsg}
+            ok%;
+%        Other ->
+%            ErrorMsg = io_lib:format("rabbit_node_monitor reports unexpected partitions value: ~p",
+%                                     [Other]),
+%            {error_string, ErrorMsg}
     end;
 
 node_health_check(alarms) ->
@@ -88,9 +89,9 @@ health_check_queues([]) ->
 health_check_queues([VHost|RestVHosts]) ->
     case rabbit_amqqueue:info_local(VHost) of
         L when is_list(L) ->
-            health_check_queues(RestVHosts);
-        Other ->
-            ErrorMsg = io_lib:format("list_queues unexpected output for vhost ~s: ~p",
-                                     [VHost, Other]),
-            {error_string, ErrorMsg}
+            health_check_queues(RestVHosts)%;
+%        Other ->
+%            ErrorMsg = io_lib:format("list_queues unexpected output for vhost ~s: ~p",
+%                                     [VHost, Other]),
+%            {error_string, ErrorMsg}
     end.

src/rabbit_mirror_queue_master.erl

@@ -70,15 +70,18 @@
 %% Backing queue
 %% ---------------------------------------------------------------------------
 
+-spec start(_, _) -> no_return().
 start(_Vhost, _DurableQueues) ->
     %% This will never get called as this module will never be
     %% installed as the default BQ implementation.
     exit({not_valid_for_generic_backing_queue, ?MODULE}).
 
+-spec stop(_) -> no_return().
 stop(_Vhost) ->
     %% Same as start/1.
     exit({not_valid_for_generic_backing_queue, ?MODULE}).
 
+-spec delete_crashed(_) -> no_return().
 delete_crashed(_QName) ->
     exit({not_valid_for_generic_backing_queue, ?MODULE}).
 
@@ -228,6 +231,7 @@ purge(State = #state { gm                  = GM,
     {Count, BQS1} = BQ:purge(BQS),
     {Count, State #state { backing_queue_state = BQS1 }}.
 
+-spec purge_acks(_) -> no_return().
 purge_acks(_State) -> exit({not_implemented, {?MODULE, purge_acks}}).
 
 publish(Msg = #basic_message { id = MsgId }, MsgProps, IsDelivered, ChPid, Flow,

src/rabbit_mirror_queue_misc.erl

@@ -61,7 +61,8 @@
 
 -spec remove_from_queue
         (rabbit_amqqueue:name(), pid(), [pid()]) ->
-            {'ok', pid(), [pid()], [node()]} | {'error', 'not_found'}.
+            {'ok', pid(), [pid()], [node()]} | {'error', 'not_found'} |
+            {'error', {'not_synced', [pid()]}}.
 
 remove_from_queue(QueueName, Self, DeadGMPids) ->
     rabbit_misc:execute_mnesia_transaction(

src/rabbit_mirror_queue_sync.erl

@@ -78,6 +78,7 @@ master_prepare(Ref, QName, Log, SPids) ->
                       non_neg_integer(),
                       bq(), bqs()) ->
                           {'already_synced', bqs()} | {'ok', bqs()} |
+                          {'cancelled', bqs()} |
                           {'shutdown', any(), bqs()} |
                           {'sync_died', any(), bqs()}.
 

src/rabbit_networking.erl

@@ -177,7 +177,7 @@ tcp_listener_addresses_auto(Port) ->
 
 -spec tcp_listener_spec
         (name_prefix(), address(), [gen_tcp:listen_option()], module(), module(),
-         protocol(), any(), non_neg_integer(), label()) ->
+         any(), protocol(), non_neg_integer(), label()) ->
             supervisor:child_spec().
 
 tcp_listener_spec(NamePrefix, {IPAddress, Port, Family}, SocketOpts,
@@ -285,6 +285,10 @@ tcp_listener_stopped(Protocol, Opts, IPAddress, Port) ->
                      port = Port,
                      opts = Opts}).
 
+%% @todo Temporary, to be removed before merge. Real fix is
+%% in an OTP PR at https://github.com/erlang/otp/pull/2117
+-dialyzer({nowarn_function, record_distribution_listener/0}).
+
 record_distribution_listener() ->
     {Name, Host} = rabbit_nodes:parts(node()),
     {port, Port, _Version} = erl_epmd:port_please(Name, Host),
@@ -449,6 +453,7 @@ gethostaddr(Host, Family) ->
         {error, Reason} -> host_lookup_error(Host, Reason)
     end.
 
+-spec host_lookup_error(_, _) -> no_return().
 host_lookup_error(Host, Reason) ->
     rabbit_log:error("invalid host ~p - ~p~n", [Host, Reason]),
     throw({error, {invalid_host, Host, Reason}}).

src/rabbit_plugins.erl

@@ -310,7 +310,7 @@ is_loadable(App) ->
 
 
 %% List running plugins along with their version.
--spec running_plugins() -> [{atom(), Vsn :: string()}].
+-spec running_plugins() -> {ok, [{atom(), Vsn :: string()}]}.
 running_plugins() ->
     ActivePlugins = active(),
     {ok, [{App, Vsn} || {App, _ , Vsn} <- rabbit_misc:which_applications(), lists:member(App, ActivePlugins)]}.