Merge pull request #174 from rabbitmq/error-handling

Handle a couple of potential errors a bit better

Author: michaelklishin

.github/workflows/erlang.yml

@@ -29,17 +29,3 @@ jobs:
       run: make
     - name: Run tests
       run: make check
-
-  build-bazel:
-    runs-on: ubuntu-latest
-    strategy:
-      fail-fast: false
-      matrix:
-        otp_major:
-        - "26"
-    steps:
-    - name: Clone the repository
-      uses: actions/checkout@v2
-    - name: Run tests
-      run: |
-        bazelisk test //... --config=rbe-${{ matrix.otp_major }}

src/osiris_replica.erl

@@ -160,8 +160,17 @@ handle_continue(#{name := Name0,
         {error, no_process} ->
             ?INFO_(Name, "Writer process not alive, exiting...", []),
             {stop, {shutdown, writer_unavailable}, undefined};
+        missing_file ->
+            ?INFO_(Name, "missing file returned from writer, exiting...", []),
+            {stop, {shutdown, missing_file}, undefined};
         {error, _} = Err ->
             {stop, Err, undefined};
+        {badrpc, {'EXIT', shutdown}} ->
+            ?INFO_(Name, "Writer process shutting down, exiting...", []),
+            {stop, {shutdown, writer_unavailable}, undefined};
+        {badrpc, nodedown} ->
+            ?INFO_(Name, "Writer process node is down, exiting...", []),
+            {stop, {shutdown, writer_unavailable}, undefined};
         {badrpc, Reason} ->
             {stop, {badrpc, Reason}, undefined};
         {ok, {LeaderRange, LeaderEpochOffs}} ->

src/osiris_replica_reader.erl

@@ -330,7 +330,9 @@ do_sendfile0(#state{name = Name,
         {ok, Log} ->
             do_sendfile0(State#state{log = Log});
         {error, _Err} ->
-            ok = setopts(Transport, Sock, [{nopush, false}]),
+            %% ignore return value here as we've already hit an error
+            %% and it is likely we'll get another one when setting opts
+            _ = setopts(Transport, Sock, [{nopush, false}]),
             ?DEBUG_(Name, "sendfile err ~w", [_Err]),
             State;
         {end_of_stream, Log} ->