Skip to content

Commit f7ce9a1

Browse files
committed
All remotes should ignore additional arguments
They now get passed all arguments from the parent call, but some of them are not applicable to the remote constructor
1 parent 48c9cb0 commit f7ce9a1

File tree

8 files changed

+8
-8
lines changed

8 files changed

+8
-8
lines changed

R/install-bitbucket.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ install_bitbucket <- function(repo, ref = "master", subdir = NULL,
4343

4444
bitbucket_remote <- function(repo, ref = "master", subdir = NULL,
4545
auth_user = NULL, password = NULL, sha = NULL,
46-
host = NULL) {
46+
host = NULL, ...) {
4747

4848
meta <- parse_git_repo(repo)
4949

R/install-cran.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ install_cran <- function(pkgs, repos = getOption("repos"), type = getOption("pkg
2020
install_remotes(remotes, quiet = quiet, ...)
2121
}
2222

23-
cran_remote <- function(pkg, repos, type) {
23+
cran_remote <- function(pkg, repos, type, ...) {
2424

2525
remote("cran",
2626
name = pkg,

R/install-git.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ install_git <- function(url, subdir = NULL, branch = NULL,
2828
}
2929

3030

31-
git_remote <- function(url, subdir = NULL, branch = NULL, git = c("auto", "git2r", "external")) {
31+
git_remote <- function(url, subdir = NULL, branch = NULL, git = c("auto", "git2r", "external"), ...) {
3232
git <- match.arg(git)
3333
if (git == "auto") {
3434
git <- if (pkg_installed("git2r")) "git2r" else "external"

R/install-github.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ install_github <- function(repo,
5252

5353
github_remote <- function(repo, ref = "master", subdir = NULL,
5454
auth_token = github_pat(), sha = NULL,
55-
host = "api.github.com") {
55+
host = "api.github.com", ...) {
5656

5757
meta <- parse_git_repo(repo)
5858
meta <- github_resolve_ref(meta$ref %||% ref, meta, auth_token)

R/install-gitlab.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ install_gitlab <- function(repo,
2828

2929
gitlab_remote <- function(repo,
3030
auth_token = gitlab_pat(), sha = NULL,
31-
host = "gitlab.com") {
31+
host = "gitlab.com", ...) {
3232

3333
meta <- parse_git_repo(repo)
3434
meta$ref <- meta$ref %||% "master"

R/install-local.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ install_local <- function(path, subdir = NULL, ...) {
2121
install_remotes(remotes, ...)
2222
}
2323

24-
local_remote <- function(path, subdir = NULL, branch = NULL, args = character(0)) {
24+
local_remote <- function(path, subdir = NULL, branch = NULL, args = character(0), ...) {
2525
remote("local",
2626
path = normalizePath(path),
2727
subdir = subdir

R/install-svn.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ install_svn <- function(url, subdir = NULL, args = character(0),
3131
}
3232

3333
svn_remote <- function(url, svn_subdir = NULL, revision = NULL,
34-
args = character(0)) {
34+
args = character(0), ...) {
3535
remote("svn",
3636
url = url,
3737
svn_subdir = svn_subdir,

R/install-url.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ install_url <- function(url, subdir = NULL, ...) {
2020
install_remotes(remotes, ...)
2121
}
2222

23-
url_remote <- function(url, subdir = NULL) {
23+
url_remote <- function(url, subdir = NULL, ...) {
2424
remote("url",
2525
url = url,
2626
subdir = subdir

0 commit comments

Comments
 (0)