Silence noisy (and useless) MSVC warnings

Author: saghul

CMakeLists.txt

@@ -51,6 +51,19 @@ if(MSVC)
     xcheck_add_c_compiler_flag(-Wno-reserved-identifier)
     xcheck_add_c_compiler_flag(-Wdeprecated-declarations)
     xcheck_add_c_compiler_flag(/experimental:c11atomics)
+    xcheck_add_c_compiler_flag(/wd4018)
+    xcheck_add_c_compiler_flag(/wd4061)
+    xcheck_add_c_compiler_flag(/wd4100)
+    xcheck_add_c_compiler_flag(/wd4242)
+    xcheck_add_c_compiler_flag(/wd4244)
+    xcheck_add_c_compiler_flag(/wd4245)
+    xcheck_add_c_compiler_flag(/wd4267)
+    xcheck_add_c_compiler_flag(/wd4388)
+    xcheck_add_c_compiler_flag(/wd4389)
+    xcheck_add_c_compiler_flag(/wd4710)
+    xcheck_add_c_compiler_flag(/wd4711)
+    xcheck_add_c_compiler_flag(/wd4820)
+    xcheck_add_c_compiler_flag(/wd5045)
 endif()
 
 # MacOS and GCC 11 or later need -Wno-maybe-uninitialized

cutils.c

@@ -37,7 +37,9 @@
 #undef NANOSEC
 #define NANOSEC ((uint64_t) 1e9)
 
+#ifdef __GNUC__
 #pragma GCC visibility push(default)
+#endif
 
 void pstrcpy(char *buf, int buf_size, const char *str)
 {
@@ -1404,4 +1406,6 @@ int js_cond_timedwait(js_cond_t *cond, js_mutex_t *mutex, uint64_t timeout) {
 
 #endif /* !defined(EMSCRIPTEN) && !defined(__wasi__) */
 
+#ifdef __GNUC__
 #pragma GCC visibility pop
+#endif

quickjs.c

@@ -34050,7 +34050,9 @@ typedef struct BCReaderState {
 } BCReaderState;
 
 #ifdef DUMP_READ_OBJECT
+#ifdef __GNUC__
 #pragma GCC diagnostic ignored "-Wformat-zero-length"
+#endif
 static void __attribute__((format(printf, 2, 3))) bc_read_trace(BCReaderState *s, const char *fmt, ...) {
     va_list ap;
     int i, n, n0;
@@ -34084,7 +34086,9 @@ static void __attribute__((format(printf, 2, 3))) bc_read_trace(BCReaderState *s
     if (strchr(fmt, '{'))
         s->level++;
 }
+#ifdef __GNUC__
 #pragma GCC diagnostic warning "-Wformat-zero-length"
+#endif
 #else
 #define bc_read_trace(...)
 #endif