Skip to content

Commit d21d64d

Browse files
committed
Fixed issues with icon removal, copyright notice, and license identifier.
- Removed icons as per requirement. - Updated copyright notice to reflect correct ownership and licensing. - Moved license identifier to the top of the file for clarity. - Added proper dependency checks to ensure smooth execution. - Updated steps to push required scripts to target. - Fixed Shell Check in Bluetooth/run.sh. Signed-off-by: Anil Yadav <[email protected]>
1 parent 1d48755 commit d21d64d

File tree

6 files changed

+86
-50
lines changed

6 files changed

+86
-50
lines changed

Runner/suites/Connectivity/Bluetooth/README.md

Lines changed: 20 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,33 @@
1+
Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
2+
SPDX-License-Identifier: BSD-3-Clause-Clear
3+
14
# Bluetooth Validation Test
25

3-
## 📌 Overview
6+
## Overview
47

58
This test case validates the basic functionality of the Bluetooth controller on the device. It checks for:
69

710
- Presence of `bluetoothctl`
811
- Running status of `bluetoothd`
912
- Power state toggling of the Bluetooth controller
1013

14+
## Usage
1115

16+
Instructions:
1217

13-
## How to Run
18+
1. Copy repo to Target Device: Use scp to transfer the scripts from the host to the target device. The scripts should be copied to any directory on the target device.
19+
2. Verify Transfer: Ensure that the repo have been successfully copied to any directory on the target device.
20+
3. Run Scripts: Navigate to the directory where these files are copied on the target device and execute the scripts as needed.
1421

15-
```sh
16-
source init_env
17-
cd suites/Connectivity/Bluetooth
18-
./run.sh
22+
Run a Connectivity Bluetooth test using:
23+
---
24+
#### Quick Example
25+
```
26+
git clone <this-repo>
27+
cd <this-repo>
28+
scp -r common Runner user@target_device_ip:<Path in device>
29+
ssh user@target_device_ip
30+
cd <Path in device>/Runner && ./run-test.sh Bluetooth
1931
```
2032

2133
## Prerequisites
@@ -26,13 +38,13 @@ cd suites/Connectivity/Bluetooth
2638
## Result Format
2739

2840
Test result will be saved in Bluetooth.res as:
29-
Pass Criteria
41+
#### Pass Criteria
3042
- bluetoothctl is available
3143
- bluetoothd is running
3244
- Power on command returns success
3345
- Bluetooth controller powered on successfully. – if all validations pass
3446
<!-- -->
35-
Fail Criteria
47+
#### Fail Criteria
3648
- bluetoothctl not found
3749
- bluetoothd not running
3850
- Power on command fails
@@ -44,7 +56,3 @@ A .res file is generated in the same directory:
4456

4557
`PASS Bluetooth` OR `FAIL Bluetooth`
4658

47-
## License
48-
49-
SPDX-License-Identifier: BSD-3-Clause-Clear
50-
(C) Qualcomm Technologies, Inc. and/or its subsidiaries.

Runner/suites/Connectivity/Bluetooth/run.sh

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,25 @@ if ! command -v bluetoothctl >/dev/null 2>&1; then
5353
fi
5454

5555
# Check if bluetoothd is running
56-
if ! pgrep bluetoothd >/dev/null; then
57-
log_fail "bluetoothd is not running. Please start the Bluetooth daemon."
56+
MAX_RETRIES=3
57+
RETRY_DELAY=10 # seconds
58+
retry=0
59+
60+
while [ "$retry" -lt "$MAX_RETRIES" ]; do
61+
if pgrep bluetoothd >/dev/null; then
62+
break
63+
fi
64+
log_info "Bluetooth daemon not found, retrying in ${RETRY_DELAY} seconds..."
65+
sleep "$RETRY_DELAY"
66+
retry=$((retry + 1))
67+
done
68+
69+
if [ "$retry" -eq "$MAX_RETRIES" ]; then
70+
log_fail "Failed to start bluetoothd after ${MAX_RETRIES} retries. Aborting test."
5871
echo "FAIL $TESTNAME" > "$res_file"
5972
exit 1
73+
else
74+
log_info "Bluetooth daemon started successfully."
6075
fi
6176

6277
# Power off Bluetooth controller

Runner/suites/Connectivity/Ethernet/README.md

Lines changed: 22 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,37 +1,49 @@
1+
Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
2+
SPDX-License-Identifier: BSD-3-Clause-Clear
3+
14
# Ethernet Validation Test
25

3-
## 📌 Overview
6+
## Overview
47

58
This test case validates the basic functionality of the Ethernet interface (`eth0`) on the device. It checks for:
69

710
- Interface presence
811
- Interface status (UP/DOWN)
912
- Basic connectivity via ping to `8.8.8.8`
1013

14+
## Usage
15+
16+
Instructions:
1117

12-
## How to Run
18+
1. Copy repo to Target Device: Use scp to transfer the scripts from the host to the target device. The scripts should be copied to any directory on the target device.
19+
2. Verify Transfer: Ensure that the repo have been successfully copied to any directory on the target device.
20+
3. Run Scripts: Navigate to the directory where these files are copied on the target device and execute the scripts as needed.
1321

14-
```sh
15-
source init_env
16-
cd suites/Connectivity/Ethernet
17-
./run.sh
22+
Run a Connectivity Ethernet test using:
23+
---
24+
#### Quick Example
25+
```
26+
git clone <this-repo>
27+
cd <this-repo>
28+
scp -r common Runner user@target_device_ip:<Path in device>
29+
ssh user@target_device_ip
30+
cd <Path in device>/Runner && ./run-test.sh Ethernet
1831
```
1932

2033
## Prerequisites
2134

22-
- `net-tools` must be available
35+
- `ip` and `ping` must be available
2336
- Root access may be required for complete validation
2437

2538
## Result Format
26-
2739
Test result will be saved in `Ethernet.res` as:
28-
Pass Criteria
40+
#### Pass Criteria
2941
- Ethernet interface eth0 is detected
3042
- Interface is successfully brought up (if down)
3143
- Ping to 8.8.8.8 succeeds
3244
- `Ethernet connectivity verified` – if all validations pass
3345
<!-- -->
34-
Fail Criteria
46+
#### Fail Criteria
3547
- Interface eth0 is not found
3648
- Interface cannot be brought up
3749
- Ping test fails
@@ -42,8 +54,3 @@ Test result will be saved in `Ethernet.res` as:
4254
A .res file is generated in the same directory:
4355

4456
`PASS Ethernet` OR `FAIL Ethernet`
45-
46-
## License
47-
48-
SPDX-License-Identifier: BSD-3-Clause-Clear
49-
(C) Qualcomm Technologies, Inc. and/or its subsidiaries.

Runner/suites/Connectivity/Ethernet/run.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ rm -f "$res_file"
4040
log_info "--------------------------------------------------------------------------"
4141
log_info "-------------------Starting $TESTNAME Testcase----------------------------"
4242

43-
log_info "Checking if dependency: net-tools is available"
44-
check_dependencies net-tools
43+
log_info "Checking if dependency: ip and ping is available"
44+
check_dependencies ip ping
4545

4646
log_info "Starting Ethernet test..."
4747

Runner/suites/Kernel/FunctionalArea/baseport/shmbridge/README.md

Lines changed: 23 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
1+
Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
2+
SPDX-License-Identifier: BSD-3-Clause-Clear
3+
14
# shmbridge Validation Test
25

3-
## 📌 Overview
6+
## Overview
47

58
This test case validates the encryption and access functionality of the `shmbridge` partition by:
69

@@ -10,29 +13,40 @@ This test case validates the encryption and access functionality of the `shmbrid
1013
- Setting and verifying an encryption policy
1114
- Writing and reading a test file to confirm data integrity
1215

13-
## How to Run
16+
## Usage
17+
18+
Instructions:
19+
20+
1. Copy repo to Target Device: Use scp to transfer the scripts from the host to the target device. The scripts should be copied to any directory on the target device.
21+
2. Verify Transfer: Ensure that the repo have been successfully copied to any directory on the target device.
22+
3. Run Scripts: Navigate to the directory where these files are copied on the target device and execute the scripts as needed.
1423

15-
```sh
16-
source init_env
17-
cd suites/Kernel/FunctionalArea/baseport/shmbridge
18-
./run.sh
24+
Run a Kernel Baseport shmbridge test using:
25+
---
26+
#### Quick Example
27+
```
28+
git clone <this-repo>
29+
cd <this-repo>
30+
scp -r common Runner user@target_device_ip:<Path in device>
31+
ssh user@target_device_ip
32+
cd <Path in device>/Runner && ./run-test.sh shmbridge
1933
```
2034

2135
## Prerequisites
22-
- `fscryptctl` must be available
36+
- `fscryptctl`, `mkfs.ext4` and `mount` must be available
2337
- Root access is required
2438
- Partition /dev/disk/by-partlabel/xbl_ramdump_a must exist and be accessible
2539

2640
## Result Format
2741

2842
Test result will be saved in shmbridge.res as:
29-
Pass Criteria
43+
#### Pass Criteria
3044
- Partition is found and formatted
3145
- Encryption key is added and policy is set
3246
- Test file is written and read successfully
3347
- `Test Passed` – if all validations succeed
3448
<!-- -->
35-
Fail Criteria
49+
#### Fail Criteria
3650
- Partition not found
3751
- Encryption setup fails
3852
- Test file cannot be read or content mismatch
@@ -42,8 +56,3 @@ Test result will be saved in shmbridge.res as:
4256
A .res file is generated in the same directory:
4357

4458
`PASS shmbridge` OR `FAIL shmbridge`
45-
46-
## License
47-
48-
SPDX-License-Identifier: BSD-3-Clause-Clear
49-
(C) Qualcomm Technologies, Inc. and/or its subsidiaries.

Runner/suites/Kernel/FunctionalArea/baseport/shmbridge/run.sh

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ log_info "----------------------------------------------------------------------
4141
log_info "-------------------Starting $TESTNAME Testcase----------------------------"
4242

4343
log_info "Checking if dependency: fscryptctl is available"
44-
check_dependencies fscryptctl
44+
check_dependencies fscryptctl mkfs.ext4 mount
4545

4646
MOUNT_POINT="/mnt/overlay"
4747
PARTITION="/dev/disk/by-partlabel/xbl_ramdump_a"
@@ -70,10 +70,7 @@ log_info "Mounting partition to $MOUNT_POINT with inlinecrypt"
7070
mount "$PARTITION" -o inlinecrypt "$MOUNT_POINT"
7171

7272
log_info "Generating 64-byte encryption key"
73-
head -c 64 /dev/urandom > "$KEY_FILE"
74-
75-
log_info "Checking if dependency binary is available"
76-
check_dependencies fscryptctl
73+
dd if=/dev/urandom bs=1 count=64 > "$KEY_FILE"
7774

7875
log_info "Adding encryption key using fscryptctl"
7976
identifier=$(fscryptctl add_key "$MOUNT_POINT" < "$KEY_FILE")

0 commit comments

Comments
 (0)