Skip to content

Commit e2c0cc6

Browse files
committed
migrate to Jakarta EE
Signed-off-by: Ceki Gulcu <[email protected]>
1 parent 0088e60 commit e2c0cc6

37 files changed

+192
-212
lines changed

logback-access/pom.xml

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@
3434
</dependency>
3535

3636
<dependency>
37-
<groupId>javax.servlet</groupId>
38-
<artifactId>javax.servlet-api</artifactId>
37+
<groupId>jakarta.servlet</groupId>
38+
<artifactId>jakarta.servlet-api</artifactId>
3939
<scope>provided</scope>
4040
</dependency>
4141

@@ -65,8 +65,15 @@
6565
</dependency>
6666

6767
<dependency>
68-
<groupId>javax.mail</groupId>
69-
<artifactId>javax.mail-api</artifactId>
68+
<groupId>jakarta.mail</groupId>
69+
<artifactId>jakarta.mail-api</artifactId>
70+
<scope>compile</scope>
71+
<optional>true</optional>
72+
</dependency>
73+
74+
<dependency>
75+
<groupId>jakarta.activation</groupId>
76+
<artifactId>jakarta.activation-api</artifactId>
7077
<scope>compile</scope>
7178
<optional>true</optional>
7279
</dependency>
@@ -135,7 +142,7 @@
135142
<Import-Package>
136143
ch.qos.logback.core.rolling,
137144
ch.qos.logback.core.rolling.helper,
138-
javax.servlet.*;version="4.0.0",
145+
jakarta.servlet.*;version="4.0.0",
139146
org.apache.catalina.*;version="${tomcat.version}";resolution:=optional,
140147
org.eclipse.jetty.*;version="${jetty.version}";resolution:=optional,
141148
*

logback-access/src/main/java/ch/qos/logback/access/ViewStatusMessagesServlet.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@
1313
*/
1414
package ch.qos.logback.access;
1515

16-
import javax.servlet.ServletContext;
17-
import javax.servlet.http.HttpServletRequest;
18-
import javax.servlet.http.HttpServletResponse;
16+
import jakarta.servlet.ServletContext;
17+
import jakarta.servlet.http.HttpServletRequest;
18+
import jakarta.servlet.http.HttpServletResponse;
1919

2020
import ch.qos.logback.core.status.StatusManager;
2121
import ch.qos.logback.core.status.ViewStatusMessagesServletBase;

logback-access/src/main/java/ch/qos/logback/access/jetty/RequestLogImpl.java

Lines changed: 12 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515

1616
import java.io.File;
1717
import java.net.URL;
18+
import java.util.EventListener;
1819
import java.util.HashMap;
1920
import java.util.Iterator;
2021
import java.util.List;
@@ -243,20 +244,10 @@ enum State {
243244
String fileName;
244245
String resource;
245246

246-
// Jetty 9.4.x and newer is considered modern.
247-
boolean modernJettyRequestLog;
248247
boolean quiet = false;
249248

250249
public RequestLogImpl() {
251250
putObject(CoreConstants.EVALUATOR_MAP, new HashMap<String, EventEvaluator<?>>());
252-
253-
// plumb the depths of Jetty and the environment ...
254-
if (EnvUtil.isClassAvailable(this.getClass(), "jakarta.servlet.http.HttpServlet")) {
255-
throw new RuntimeException("The new jakarta.servlet classes are not supported by this " + "version of logback-access (check for a newer version of logback-access that " + "does support it)");
256-
}
257-
258-
// look for modern approach to RequestLog
259-
modernJettyRequestLog = EnvUtil.isClassAvailable(this.getClass(), "org.eclipse.jetty.server.CustomRequestLog");
260251
}
261252

262253
@Override
@@ -270,11 +261,7 @@ public void log(Request jettyRequest, Response jettyResponse) {
270261
}
271262

272263
private JettyServerAdapter makeJettyServerAdapter(Request jettyRequest, Response jettyResponse) {
273-
if (modernJettyRequestLog) {
274-
return new JettyModernServerAdapter(jettyRequest, jettyResponse);
275-
} else {
276-
return new JettyServerAdapter(jettyRequest, jettyResponse);
277-
}
264+
return new JettyModernServerAdapter(jettyRequest, jettyResponse);
278265
}
279266

280267
protected void addInfo(String msg) {
@@ -402,6 +389,16 @@ public boolean isFailed() {
402389
return state == State.FAILED;
403390
}
404391

392+
@Override
393+
public boolean addEventListener(EventListener listener) {
394+
return false;
395+
}
396+
397+
@Override
398+
public boolean removeEventListener(EventListener listener) {
399+
return false;
400+
}
401+
405402

406403
public boolean isQuiet() {
407404
return quiet;
@@ -466,13 +463,10 @@ public FilterReply getFilterChainDecision(IAccessEvent event) {
466463
return fai.getFilterChainDecision(event);
467464
}
468465

469-
470-
@Override
471466
public void addLifeCycleListener(LifeCycle.Listener listener) {
472467
// we'll implement this when asked
473468
}
474469

475-
@Override
476470
public void removeLifeCycleListener(LifeCycle.Listener listener) {
477471
// we'll implement this when asked
478472
}

logback-access/src/main/java/ch/qos/logback/access/servlet/TeeFilter.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,14 @@
1919
import java.util.ArrayList;
2020
import java.util.List;
2121

22-
import javax.servlet.Filter;
23-
import javax.servlet.FilterChain;
24-
import javax.servlet.FilterConfig;
25-
import javax.servlet.ServletException;
26-
import javax.servlet.ServletRequest;
27-
import javax.servlet.ServletResponse;
28-
import javax.servlet.http.HttpServletRequest;
29-
import javax.servlet.http.HttpServletResponse;
22+
import jakarta.servlet.Filter;
23+
import jakarta.servlet.FilterChain;
24+
import jakarta.servlet.FilterConfig;
25+
import jakarta.servlet.ServletException;
26+
import jakarta.servlet.ServletRequest;
27+
import jakarta.servlet.ServletResponse;
28+
import jakarta.servlet.http.HttpServletRequest;
29+
import jakarta.servlet.http.HttpServletResponse;
3030

3131
import static ch.qos.logback.access.AccessConstants.LB_OUTPUT_BUFFER;
3232
import static ch.qos.logback.access.AccessConstants.TEE_FILTER_INCLUDES_PARAM;

logback-access/src/main/java/ch/qos/logback/access/servlet/TeeHttpServletRequest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@
1717
import java.io.IOException;
1818
import java.io.InputStreamReader;
1919

20-
import javax.servlet.ServletInputStream;
21-
import javax.servlet.http.HttpServletRequest;
22-
import javax.servlet.http.HttpServletRequestWrapper;
20+
import jakarta.servlet.ServletInputStream;
21+
import jakarta.servlet.http.HttpServletRequest;
22+
import jakarta.servlet.http.HttpServletRequestWrapper;
2323

2424
import static ch.qos.logback.access.AccessConstants.LB_INPUT_BUFFER;
2525

logback-access/src/main/java/ch/qos/logback/access/servlet/TeeHttpServletResponse.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@
1717
import java.io.OutputStreamWriter;
1818
import java.io.PrintWriter;
1919

20-
import javax.servlet.ServletOutputStream;
21-
import javax.servlet.http.HttpServletResponse;
22-
import javax.servlet.http.HttpServletResponseWrapper;
20+
import jakarta.servlet.ServletOutputStream;
21+
import jakarta.servlet.http.HttpServletResponse;
22+
import jakarta.servlet.http.HttpServletResponseWrapper;
2323

2424
public class TeeHttpServletResponse extends HttpServletResponseWrapper {
2525

logback-access/src/main/java/ch/qos/logback/access/servlet/TeeServletInputStream.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@
1818
import java.io.IOException;
1919
import java.io.InputStream;
2020

21-
import javax.servlet.ReadListener;
22-
import javax.servlet.ServletInputStream;
23-
import javax.servlet.http.HttpServletRequest;
21+
import jakarta.servlet.ReadListener;
22+
import jakarta.servlet.ServletInputStream;
23+
import jakarta.servlet.http.HttpServletRequest;
2424

2525
class TeeServletInputStream extends ServletInputStream {
2626

logback-access/src/main/java/ch/qos/logback/access/servlet/TeeServletOutputStream.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616
import java.io.ByteArrayOutputStream;
1717
import java.io.IOException;
1818

19-
import javax.servlet.ServletOutputStream;
20-
import javax.servlet.ServletResponse;
21-
import javax.servlet.WriteListener;
19+
import jakarta.servlet.ServletOutputStream;
20+
import jakarta.servlet.ServletResponse;
21+
import jakarta.servlet.WriteListener;
2222

2323
public class TeeServletOutputStream extends ServletOutputStream {
2424

logback-access/src/main/java/ch/qos/logback/access/servlet/Util.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515

1616
import ch.qos.logback.access.AccessConstants;
1717

18-
import javax.servlet.http.HttpServletRequest;
19-
import javax.servlet.http.HttpServletResponse;
18+
import jakarta.servlet.http.HttpServletRequest;
19+
import jakarta.servlet.http.HttpServletResponse;
2020

2121
public class Util {
2222

logback-access/src/main/java/ch/qos/logback/access/sift/AccessEventDiscriminator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313
*/
1414
package ch.qos.logback.access.sift;
1515

16-
import javax.servlet.http.HttpServletRequest;
17-
import javax.servlet.http.HttpSession;
16+
import jakarta.servlet.http.HttpServletRequest;
17+
import jakarta.servlet.http.HttpSession;
1818

1919
import ch.qos.logback.access.spi.IAccessEvent;
2020
import ch.qos.logback.core.sift.AbstractDiscriminator;

0 commit comments

Comments
 (0)