lowercase trial component name (aws#776)

Author: danabens

src/sagemaker/experiments/run.py

@@ -57,7 +57,7 @@
 
 logger = logging.getLogger(__name__)
 
-RUN_NAME_BASE = "Sagemaker-Run"
+RUN_NAME_BASE = "Sagemaker-Run".lower()
 TRIAL_NAME_TEMPLATE = "Default-Run-Group-{}"
 MAX_RUN_TC_ARTIFACTS_LEN = 30
 MAX_NAME_LEN_IN_BACKEND = 120
@@ -140,6 +140,10 @@ def __init__(
         self.experiment_name = experiment_name
         sagemaker_session = sagemaker_session or _utils.default_session()
         self.run_name = run_name or unique_name_from_base(RUN_NAME_BASE)
+
+        # avoid confusion due to mis-match in casing between run name and TC name
+        self.run_name = self.run_name.lower()
+
         trial_component_name = Run._generate_trial_component_name(
             run_name=self.run_name, experiment_name=self.experiment_name
         )
@@ -597,7 +601,10 @@ def _generate_trial_component_name(run_name: str, experiment_name: str) -> str:
             raise ValueError(
                 err_msg_template.format("experiment_name", len(experiment_name), max_len)
             )
-        return "{}{}{}".format(experiment_name, DELIMITER, run_name)
+        trial_component_name = "{}{}{}".format(experiment_name, DELIMITER, run_name)
+        # due to mixed-case concerns on the backend
+        trial_component_name = trial_component_name.lower()
+        return trial_component_name
 
     @staticmethod
     def _extract_run_name_from_tc_name(trial_component_name: str, experiment_name: str) -> str:

tests/unit/sagemaker/experiments/test_run.py

@@ -710,9 +710,9 @@ def test_list(mock_tc_search, mock_tc_list, mock_tc_load, run_obj, sagemaker_ses
         [
             TrialComponentSearchResult(
                 trial_component_name=Run._generate_trial_component_name(
-                    "A" + str(i), TEST_EXP_NAME
+                    "a" + str(i), TEST_EXP_NAME
                 ),
-                trial_component_arn="B" + str(i),
+                trial_component_arn="b" + str(i),
                 display_name="C" + str(i),
                 creation_time=creation_time + datetime.timedelta(hours=i),
                 last_modified_time=last_modified_time + datetime.timedelta(hours=i),
@@ -725,7 +725,7 @@ def test_list(mock_tc_search, mock_tc_list, mock_tc_load, run_obj, sagemaker_ses
     mock_tc_list.return_value = [
         TrialComponentSummary(
             trial_component_name=Run._generate_trial_component_name("A" + str(i), TEST_EXP_NAME),
-            trial_component_arn="B" + str(i),
+            trial_component_arn="b" + str(i),
             display_name="C" + str(i),
             source_arn="D" + str(i),
             status=TrialComponentStatus(
@@ -743,9 +743,9 @@ def test_list(mock_tc_search, mock_tc_list, mock_tc_load, run_obj, sagemaker_ses
         (
             _TrialComponent(
                 trial_component_name=Run._generate_trial_component_name(
-                    "A" + str(i), TEST_EXP_NAME
+                    "a" + str(i), TEST_EXP_NAME
                 ),
-                trial_component_arn="B" + str(i),
+                trial_component_arn="b" + str(i),
                 display_name="C" + str(i),
                 source_arn="D" + str(i),
                 status=TrialComponentStatus(
@@ -783,12 +783,12 @@ def test_list(mock_tc_search, mock_tc_list, mock_tc_load, run_obj, sagemaker_ses
     for i in range(tc_list_len_half):
         run = run_list[i]
         assert run.experiment_name == TEST_EXP_NAME
-        assert run.run_name == "A" + str(i)
+        assert run.run_name == "a" + str(i)
         assert run._experiment
         assert run._trial
         assert isinstance(run._trial_component, _TrialComponent)
         assert run._trial_component.trial_component_name == Run._generate_trial_component_name(
-            "A" + str(i), TEST_EXP_NAME
+            "a" + str(i), TEST_EXP_NAME
         )
         assert run._in_load is False
         assert run._inside_load_context is False