From db4473197d573d2ad1056ad574396404f867a152 Mon Sep 17 00:00:00 2001 From: Oleksandr_Halichenko Date: Fri, 1 Sep 2023 12:12:23 +0300 Subject: [PATCH] fixed Feature that contains only undefined/skipped scenarios is displayed as passed --- CHANGELOG.MD | 3 +++ package-lock.json | 4 ++-- package.json | 2 +- src/index.tsx | 2 +- test-e2e/features/FeaturePage.feature | 6 +++--- 5 files changed, 10 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.MD b/CHANGELOG.MD index c4bffcb..ddceb4b 100644 --- a/CHANGELOG.MD +++ b/CHANGELOG.MD @@ -1,3 +1,6 @@ +# 0.14.4 +- fixed [Feature that contains only undefined/skipped scenarios is displayed as passed](https://github.com/qavajs/html-formatter/issues/36) + # 0.14.3 - fixed width and height of error and logs overlay diff --git a/package-lock.json b/package-lock.json index 2a74936..68db952 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@qavajs/html-formatter", - "version": "0.14.3", + "version": "0.14.4", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@qavajs/html-formatter", - "version": "0.14.3", + "version": "0.14.4", "devDependencies": { "@babel/core": "^7.21.0", "@cucumber/cucumber": "^9.4.0", diff --git a/package.json b/package.json index 0fa8026..cee0c8b 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@qavajs/html-formatter", - "version": "0.14.3", + "version": "0.14.4", "main": "formatter/formatter.js", "scripts": { "report:compile": "node test/compile_report.js", diff --git a/src/index.tsx b/src/index.tsx index f01b191..837175d 100644 --- a/src/index.tsx +++ b/src/index.tsx @@ -33,7 +33,7 @@ const data = window.sourceData total: feature.elements.length, elements: feature.elements.map((scenario: any) => ({ ...scenario, - isFailed: scenario.steps.some((step: any) => step.result.status === 'failed') + isFailed: scenario.steps.some((step: any) => step.result.status !== 'passed') })), })) .map((feature: any) => ({ diff --git a/test-e2e/features/FeaturePage.feature b/test-e2e/features/FeaturePage.feature index d75aa1f..399d30d 100644 --- a/test-e2e/features/FeaturePage.feature +++ b/test-e2e/features/FeaturePage.feature @@ -12,13 +12,13 @@ Feature: Feature Page Scenario: verify that user can filter only failed on feature page When I click 'Feature > Show Only Failed' - Then I expect number of elements in 'Feature > Scenarios' collection to be equal '3' + Then I expect number of elements in 'Feature > Scenarios' collection to be equal '6' And I expect text of 'Feature > #1 of Scenarios > Title' to be equal 'Scenario: scenario failed' Scenario: verify that filter state is saved When I click 'Feature > Show Only Failed' - Then I expect number of elements in 'Feature > Scenarios' collection to be equal '3' + Then I expect number of elements in 'Feature > Scenarios' collection to be equal '6' And I expect text of 'Feature > #1 of Scenarios > Title' to be equal 'Scenario: scenario failed' When I refresh page - Then I expect number of elements in 'Feature > Scenarios' collection to be equal '3' + Then I expect number of elements in 'Feature > Scenarios' collection to be equal '6' And I expect text of 'Feature > #1 of Scenarios > Title' to be equal 'Scenario: scenario failed'