Skip to content

Commit d83ec9e

Browse files
Fix log popup size (#35)
* fixed width and height of error and logs overlay
1 parent a3f14f9 commit d83ec9e

File tree

7 files changed

+18
-9
lines changed

7 files changed

+18
-9
lines changed

CHANGELOG.MD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# 0.14.2
1+
# 0.14.3
22
- fixed width and height of error and logs overlay
33

44
# 0.14.1

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@qavajs/html-formatter",
3-
"version": "0.14.2",
3+
"version": "0.14.3",
44
"main": "formatter/formatter.js",
55
"scripts": {
66
"report:compile": "node test/compile_report.js",

src/components/ErrorModal.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@ import {
1111
export const ErrorModal = (modalProps: any) => {
1212
return <>
1313
<ModalBlocker blockerShadow='dark' {...modalProps}>
14-
<ModalWindow style={{width: '90vw', margin: 'auto', height: '60vh'}}>
14+
<ModalWindow style={{width: '90vw', margin: 'auto'}}>
1515
<Panel background="white">
1616
<ModalHeader title="Error" onClose={() => modalProps.success('close')}/>
1717
<FlexRow padding='24'>
18-
<pre style={{width: '100%', overflow: 'auto'}}>
18+
<pre style={{width: '100%', overflow: 'auto', height: '60vh'}}>
1919
{modalProps.error}
2020
</pre>
2121
</FlexRow>

src/components/LogsModal.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@ import {
1111
export const LogsModal = (modalProps: any) => {
1212
return <>
1313
<ModalBlocker blockerShadow='dark' {...modalProps}>
14-
<ModalWindow style={{width: '90vw', margin: 'auto', height: '60vh'}}>
14+
<ModalWindow style={{width: '90vw', margin: 'auto'}}>
1515
<Panel background="white">
1616
<ModalHeader title="Logs" onClose={() => modalProps.success('close')}/>
1717
<FlexRow padding='24'>
18-
<pre style={{width: '100%', overflow: 'auto'}}>
18+
<pre style={{width: '100%', overflow: 'auto', height: '60vh'}}>
1919
{modalProps.logs.map((log: any, index: number) => <div key={index}>{log.data}</div>)}
2020
</pre>
2121
</FlexRow>

test/features/Logs.feature

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,3 +8,6 @@ Feature: Logs
88

99
Scenario: scenario dollar replace
1010
And I expect 'some string' to match '^120$'
11+
12+
Scenario: scenario passed with huge log
13+
When passed step with huge log

test/step_definitions/custom_steps.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,15 @@ When('unsupported base64 attachment', function () {
6161

6262
When('passed step with log', function () {
6363
this.log('some information in passed step');
64-
this.log('one more log line')
64+
this.log('one more log line');
65+
});
6566

67+
When('passed step with huge log', function () {
68+
for (let i = 0; i < 100; i++) {
69+
this.log('one more log line '.repeat(100));
70+
}
6671
});
72+
6773
When('failed step with log', function () {
6874
this.log('some information in failed step');
6975
this.log('ER: expected result');

0 commit comments

Comments
 (0)