updated yaml to account for matrix

Author: dontedorsey

.github/workflows/api-ci.yml

@@ -24,15 +24,21 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, windows-latest]
+
     runs-on: ${{ matrix.os }}
 
     env:
+      # 🔁 tweak this if your .sln lives elsewhere
+      SOLUTION_PATH: ./ApiTests.sln
+
+      # 🔐 your secrets — already set up in your repo
       API_BASE_URL: ${{ secrets.API_BASE_URL }}
       API_KEY: ${{ secrets.API_KEY }}
       API_KEY_HEADER: ${{ secrets.API_KEY_HEADER }}
       API_LOGIN_PATH: ${{ secrets.API_LOGIN_PATH }}
       API_USERNAME: ${{ secrets.API_USERNAME }}
       API_PASSWORD: ${{ secrets.API_PASSWORD }}
+
       DOTNET_NOLOGO: true
 
     steps:
@@ -43,54 +49,59 @@ jobs:
         with:
           dotnet-version: '8.0.x'
           cache: true
+          # If you committed NuGet lock files:
+          cache-dependency-path: '**/packages.lock.json'
 
       - name: Restore
         run: dotnet restore
 
       - name: Build (Release)
         run: dotnet build --configuration Release --no-restore
 
-      - name: Test + Coverage + Threshold
+      # ▶️ Collect coverage (threshold=0 for now) into a single folder per job
+      - name: Test + Coverage (MSBuild, threshold=0)
+        shell: pwsh
+        run: |
+          $cov = Join-Path $env:GITHUB_WORKSPACE 'TestResults/coverage'
+          New-Item -ItemType Directory -Force -Path $cov | Out-Null
+          dotnet test $env:SOLUTION_PATH `
+            /p:CollectCoverage=true `
+            /p:CoverletOutputFormat=cobertura `
+            /p:CoverletOutput="$cov/coverage" `
+            /p:Threshold=30 `
+            /p:ThresholdType=line `
+            /p:ThresholdStat=total `
+            --logger "trx;LogFileName=testresults.trx" `
+            --results-directory "$($env:GITHUB_WORKSPACE)/TestResults"
+
+      - name: Install ReportGenerator (global tool)
+        shell: pwsh
         run: |
-          dotnet test ./ApiTests.sln \
-            /p:CollectCoverage=true \
-            /p:CoverletOutputFormat=cobertura \
-            /p:CoverletOutput=TestResults/coverage/ \
-            /p:Threshold=0 \
-            /p:ThresholdType=line \
-            /p:ThresholdStat=total
-      
-      - name: Install ReportGenerator
-        run: dotnet tool install --global dotnet-reportgenerator-globaltool
-
-      - name: Generate Coverage Report
+          dotnet tool install --global dotnet-reportgenerator-globaltool
+          # Ensure the global tool path is on PATH (works on both OSes)
+          $env:PATH += [IO.Path]::PathSeparator + (Join-Path $HOME ".dotnet/tools")
+
+      - name: Generate Coverage Report (HTML + Cobertura)
+        shell: pwsh
         run: |
-          export PATH="$PATH:~/.dotnet/tools"
-          reportgenerator \
-            -reports:"**/TestResults/coverage/coverage.cobertura.xml" \
-            -targetdir:"CoverageReport" \
+          $covFile = Join-Path $env:GITHUB_WORKSPACE 'TestResults/coverage'
+          reportgenerator `
+            -reports:"$covFile/*.cobertura.xml" `
+            -targetdir:"CoverageReport" `
             -reporttypes:"HtmlInline_AzurePipelines;Cobertura"
 
       - name: Upload Test Results (.trx)
         if: always()
         uses: actions/upload-artifact@v4
         with:
-          name: test-results
+          name: test-results-${{ matrix.os }}
           path: TestResults/**/*.trx
           if-no-files-found: warn
 
       - name: Upload Coverage Report (HTML)
         if: always()
         uses: actions/upload-artifact@v4
         with:
-          name: coverage-report
+          name: coverage-report-${{ matrix.os }}
           path: CoverageReport/**
           if-no-files-found: warn
-
-      - name: Summarize test results
-        if: always()
-        run: |
-          echo "## Test Summary" >> $GITHUB_STEP_SUMMARY
-          echo "- API: \`dotnet test\` with coverage" >> $GITHUB_STEP_SUMMARY
-          echo "- Coverage report: see artifacts → coverage-report/index.html" >> $GITHUB_STEP_SUMMARY
-