convert torch.split return to list in RAFT #7597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
added
the
other
Contributor
Author
|
Relevant lint CI job: https://github.com/pytorch/vision/actions/runs/5002317531/jobs/8962119940 |
Member
|
lol pytorch/pytorch#100655 (comment). and yes it needs to support jit :( |
Contributor
Author
|
Ok, let me convert to list then. Previously, JIT seemed to have ignored that the return type is |
This reverts commit e6646db.
pmeier
changed the title
|
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 23, 2023
Reviewed By: vmoens Differential Revision: D46071410 fbshipit-source-id: 043b40a2baee2bc17da658eafb27a55ab8f50c61
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytorch/pytorch#100655 introduced a fix for the annotation. Meaning, the return type always was a tuple, but it was annotated as list. Thus, we also now need to fix our annotation or CI will fail. For example: https://github.com/pytorch/vision/actions/runs/5001904005/jobs/8961199909
I don't know if this needs to be JIT scriptable. If so, this patch is not sufficient, since
Tuple[Tensor, ...]is not supported by JIT. We need to actually convert into a list then.