From 327bc0955a9b683f9f02918caebd8d013adcac07 Mon Sep 17 00:00:00 2001 From: Eli Uriegas Date: Fri, 7 Apr 2023 14:07:43 -0700 Subject: [PATCH 1/3] ci: Limit macOS testing to one version of python This limits macOS testing to one version of python since macOS unittests take a long time to run and are the most expensive runner type that we currently utilize Signed-off-by: Eli Uriegas --- .github/workflows/test-macos.yml | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/.github/workflows/test-macos.yml b/.github/workflows/test-macos.yml index 03e4b2db121..e3a5d1222fc 100644 --- a/.github/workflows/test-macos.yml +++ b/.github/workflows/test-macos.yml @@ -15,13 +15,7 @@ jobs: matrix: python-version: - "3.8" - - "3.9" - - "3.10" - - "3.11" - runner: ["macos-12"] - include: - - python-version: "3.8" - runner: macos-m1-12 + runner: ["macos-12", "macos-m1-12"] fail-fast: false uses: pytorch/test-infra/.github/workflows/macos_job.yml@main with: From 4a387eb5645bd1881219137922c57cd56e156f38 Mon Sep 17 00:00:00 2001 From: Eli Uriegas <1700823+seemethere@users.noreply.github.com> Date: Fri, 7 Apr 2023 14:17:52 -0700 Subject: [PATCH 2/3] Add note why 3.8 is important Co-authored-by: Nikita Shulga --- .github/workflows/test-macos.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/test-macos.yml b/.github/workflows/test-macos.yml index e3a5d1222fc..6cef21898ca 100644 --- a/.github/workflows/test-macos.yml +++ b/.github/workflows/test-macos.yml @@ -14,6 +14,7 @@ jobs: strategy: matrix: python-version: + # Test against the most popular version of Python (at the time of commit 40% of torch downloads use 3.8) - "3.8" runner: ["macos-12", "macos-m1-12"] fail-fast: false From 45806db25f56df89d89d9586d13b56e8f18a5a65 Mon Sep 17 00:00:00 2001 From: Eli Uriegas Date: Sat, 8 Apr 2023 19:36:26 -0700 Subject: [PATCH 3/3] update for minimum versions Signed-off-by: Eli Uriegas --- .github/workflows/test-macos.yml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test-macos.yml b/.github/workflows/test-macos.yml index 6cef21898ca..80cbafd2b93 100644 --- a/.github/workflows/test-macos.yml +++ b/.github/workflows/test-macos.yml @@ -13,10 +13,13 @@ jobs: unittests: strategy: matrix: - python-version: + include: # Test against the most popular version of Python (at the time of commit 40% of torch downloads use 3.8) - - "3.8" - runner: ["macos-12", "macos-m1-12"] + - python-version: "3.8" + runner: "macos-12" + # Minimum version available for Apple Silicon is 3.9, so just use that + - python-version: "3.9" + runner: "macos-m1-12" fail-fast: false uses: pytorch/test-infra/.github/workflows/macos_job.yml@main with: