Skip to content

[prototype] Reshape input before equalize #6775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 14, 2022
Merged

[prototype] Reshape input before equalize #6775

merged 2 commits into from
Oct 14, 2022

Conversation

@datumbox
Copy link
Contributor

@datumbox datumbox commented Oct 14, 2022

related to #6772

The input image also requires reshape to avoid errors such as:

RuntimeError: view size is not compatible with input tensor's size and stride (at least one dimension spans across two contiguous subspaces). Use .reshape(...) instead.

We should consider on a follow up PR to update all view() to reshape() calls.

@datumbox datumbox requested review from pmeier and vfdev-5 October 14, 2022 15:53
pmeier
pmeier approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We should consider on a follow up PR to update all view() to reshape() calls.

+1. Will do.

vfdev-5
vfdev-5 approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamp ✉️

@pmeier pmeier mentioned this pull request Oct 14, 2022
Merged
@datumbox datumbox merged commit e2fa1f9 into pytorch:main Oct 14, 2022
@datumbox datumbox deleted the prototype/equalize_reshape branch October 14, 2022 16:38
facebook-github-bot pushed a commit that referenced this pull request Oct 17, 2022
@facebook-github-bot
[fbsync] Reshare input before equalize (#6775)
11b7c2f 
Reviewed By: NicolasHug

Differential Revision: D40427474

fbshipit-source-id: cf180464c6859db68bd214730394c99fb78f591d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

@pmeier pmeier pmeier approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug cla signed module: transforms prototype

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@datumbox @vfdev-5 @pmeier @facebook-github-bot