From 519233655ef15f74cbbab3cc93bdefae5f9aba44 Mon Sep 17 00:00:00 2001 From: Philip Meier Date: Thu, 22 Sep 2022 16:45:20 +0200 Subject: [PATCH 01/19] always run all prototype tests in CI --- .github/workflows/prototype-tests.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/prototype-tests.yml b/.github/workflows/prototype-tests.yml index 93e6121faaa..b4e25294be1 100644 --- a/.github/workflows/prototype-tests.yml +++ b/.github/workflows/prototype-tests.yml @@ -40,13 +40,18 @@ jobs: run: pip install --progress-bar=off pytest pytest-mock - name: Run prototype datasets tests + id: datasets shell: bash run: pytest --durations=20 test/test_prototype_datasets*.py - name: Run prototype transforms tests + id: transforms + if: ${{ success() || steps.datasets.conclusion == 'failure' }} shell: bash run: pytest --durations=20 test/test_prototype_transforms*.py - name: Run prototype models tests + if: ${{ success() || steps.datasets.conclusion == 'failure' || steps.transforms.conclusion == 'failure' }} + id: models shell: bash run: pytest --durations=20 test/test_prototype_models*.py From 5bf250c9a7d32d3b502093c417e324ffe5f47712 Mon Sep 17 00:00:00 2001 From: Philip Meier Date: Thu, 22 Sep 2022 16:46:37 +0200 Subject: [PATCH 02/19] [DEBUG] test logic --- .github/workflows/prototype-tests.yml | 51 ++++++++++++++------------- 1 file changed, 26 insertions(+), 25 deletions(-) diff --git a/.github/workflows/prototype-tests.yml b/.github/workflows/prototype-tests.yml index b4e25294be1..164f250db09 100644 --- a/.github/workflows/prototype-tests.yml +++ b/.github/workflows/prototype-tests.yml @@ -16,42 +16,43 @@ jobs: runs-on: ${{ matrix.os }} steps: - - name: Set up python - uses: actions/setup-python@v3 - with: - python-version: 3.7 - - - name: Upgrade system packages - run: python -m pip install --upgrade pip setuptools wheel - - - name: Checkout repository - uses: actions/checkout@v3 - - - name: Install PyTorch nightly builds - run: pip install --progress-bar=off --pre torch torchdata --extra-index-url https://download.pytorch.org/whl/nightly/cpu/ - - - name: Install torchvision - run: pip install --progress-bar=off --no-build-isolation --editable . - - - name: Install other prototype dependencies - run: pip install --progress-bar=off scipy pycocotools h5py iopath - - - name: Install test requirements - run: pip install --progress-bar=off pytest pytest-mock +# - name: Set up python +# uses: actions/setup-python@v3 +# with: +# python-version: 3.7 +# +# - name: Upgrade system packages +# run: python -m pip install --upgrade pip setuptools wheel +# +# - name: Checkout repository +# uses: actions/checkout@v3 +# +# - name: Install PyTorch nightly builds +# run: pip install --progress-bar=off --pre torch torchdata --extra-index-url https://download.pytorch.org/whl/nightly/cpu/ +# +# - name: Install torchvision +# run: pip install --progress-bar=off --no-build-isolation --editable . +# +# - name: Install other prototype dependencies +# run: pip install --progress-bar=off scipy pycocotools h5py iopath +# +# - name: Install test requirements +# run: pip install --progress-bar=off pytest pytest-mock - name: Run prototype datasets tests id: datasets shell: bash - run: pytest --durations=20 test/test_prototype_datasets*.py +# run: pytest --durations=20 test/test_prototype_datasets*.py + run: exit 1 - name: Run prototype transforms tests id: transforms if: ${{ success() || steps.datasets.conclusion == 'failure' }} shell: bash - run: pytest --durations=20 test/test_prototype_transforms*.py + run: exit 1 - name: Run prototype models tests if: ${{ success() || steps.datasets.conclusion == 'failure' || steps.transforms.conclusion == 'failure' }} id: models shell: bash - run: pytest --durations=20 test/test_prototype_models*.py + run: exit 1 From f4449e133925d3d424d592f417473ea11d5f59d4 Mon Sep 17 00:00:00 2001 From: Philip Meier Date: Thu, 22 Sep 2022 16:46:43 +0200 Subject: [PATCH 03/19] [SKIP CI] only CircleCI From b97d2fbaf99bed14ccfb336f24e3149ca173b095 Mon Sep 17 00:00:00 2001 From: Philip Meier Date: Thu, 22 Sep 2022 16:48:06 +0200 Subject: [PATCH 04/19] [SKIP CI] more debug --- .github/workflows/prototype-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/prototype-tests.yml b/.github/workflows/prototype-tests.yml index 164f250db09..b899b668521 100644 --- a/.github/workflows/prototype-tests.yml +++ b/.github/workflows/prototype-tests.yml @@ -49,7 +49,7 @@ jobs: id: transforms if: ${{ success() || steps.datasets.conclusion == 'failure' }} shell: bash - run: exit 1 + run: exit 0 - name: Run prototype models tests if: ${{ success() || steps.datasets.conclusion == 'failure' || steps.transforms.conclusion == 'failure' }} From f0884b9d5762f936181dd71c790574ef6fcfa725 Mon Sep 17 00:00:00 2001 From: Philip Meier Date: Thu, 22 Sep 2022 16:48:56 +0200 Subject: [PATCH 05/19] Revert "[SKIP CI] more debug" This reverts commit b97d2fbaf99bed14ccfb336f24e3149ca173b095. --- .github/workflows/prototype-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/prototype-tests.yml b/.github/workflows/prototype-tests.yml index b899b668521..164f250db09 100644 --- a/.github/workflows/prototype-tests.yml +++ b/.github/workflows/prototype-tests.yml @@ -49,7 +49,7 @@ jobs: id: transforms if: ${{ success() || steps.datasets.conclusion == 'failure' }} shell: bash - run: exit 0 + run: exit 1 - name: Run prototype models tests if: ${{ success() || steps.datasets.conclusion == 'failure' || steps.transforms.conclusion == 'failure' }} From 8452002c7d98366c0e03aa5e36f40bd925613416 Mon Sep 17 00:00:00 2001 From: Philip Meier Date: Thu, 22 Sep 2022 16:49:25 +0200 Subject: [PATCH 06/19] Revert "[DEBUG] test logic" This reverts commit 5bf250c9a7d32d3b502093c417e324ffe5f47712. --- .github/workflows/prototype-tests.yml | 51 +++++++++++++-------------- 1 file changed, 25 insertions(+), 26 deletions(-) diff --git a/.github/workflows/prototype-tests.yml b/.github/workflows/prototype-tests.yml index 164f250db09..b4e25294be1 100644 --- a/.github/workflows/prototype-tests.yml +++ b/.github/workflows/prototype-tests.yml @@ -16,43 +16,42 @@ jobs: runs-on: ${{ matrix.os }} steps: -# - name: Set up python -# uses: actions/setup-python@v3 -# with: -# python-version: 3.7 -# -# - name: Upgrade system packages -# run: python -m pip install --upgrade pip setuptools wheel -# -# - name: Checkout repository -# uses: actions/checkout@v3 -# -# - name: Install PyTorch nightly builds -# run: pip install --progress-bar=off --pre torch torchdata --extra-index-url https://download.pytorch.org/whl/nightly/cpu/ -# -# - name: Install torchvision -# run: pip install --progress-bar=off --no-build-isolation --editable . -# -# - name: Install other prototype dependencies -# run: pip install --progress-bar=off scipy pycocotools h5py iopath -# -# - name: Install test requirements -# run: pip install --progress-bar=off pytest pytest-mock + - name: Set up python + uses: actions/setup-python@v3 + with: + python-version: 3.7 + + - name: Upgrade system packages + run: python -m pip install --upgrade pip setuptools wheel + + - name: Checkout repository + uses: actions/checkout@v3 + + - name: Install PyTorch nightly builds + run: pip install --progress-bar=off --pre torch torchdata --extra-index-url https://download.pytorch.org/whl/nightly/cpu/ + + - name: Install torchvision + run: pip install --progress-bar=off --no-build-isolation --editable . + + - name: Install other prototype dependencies + run: pip install --progress-bar=off scipy pycocotools h5py iopath + + - name: Install test requirements + run: pip install --progress-bar=off pytest pytest-mock - name: Run prototype datasets tests id: datasets shell: bash -# run: pytest --durations=20 test/test_prototype_datasets*.py - run: exit 1 + run: pytest --durations=20 test/test_prototype_datasets*.py - name: Run prototype transforms tests id: transforms if: ${{ success() || steps.datasets.conclusion == 'failure' }} shell: bash - run: exit 1 + run: pytest --durations=20 test/test_prototype_transforms*.py - name: Run prototype models tests if: ${{ success() || steps.datasets.conclusion == 'failure' || steps.transforms.conclusion == 'failure' }} id: models shell: bash - run: exit 1 + run: pytest --durations=20 test/test_prototype_models*.py From 0617a41bced5a1aaf2f38e25c9775f7fa7d4c47f Mon Sep 17 00:00:00 2001 From: Philip Meier Date: Fri, 23 Sep 2022 13:48:20 +0200 Subject: [PATCH 07/19] [NEEDS REVERT] proof of concept --- .github/workflows/prototype-tests.yml | 55 ++++++++++++++------------- 1 file changed, 29 insertions(+), 26 deletions(-) diff --git a/.github/workflows/prototype-tests.yml b/.github/workflows/prototype-tests.yml index b4e25294be1..41a8b1d9fa1 100644 --- a/.github/workflows/prototype-tests.yml +++ b/.github/workflows/prototype-tests.yml @@ -16,42 +16,45 @@ jobs: runs-on: ${{ matrix.os }} steps: - - name: Set up python - uses: actions/setup-python@v3 - with: - python-version: 3.7 - - - name: Upgrade system packages - run: python -m pip install --upgrade pip setuptools wheel - - - name: Checkout repository - uses: actions/checkout@v3 - - - name: Install PyTorch nightly builds - run: pip install --progress-bar=off --pre torch torchdata --extra-index-url https://download.pytorch.org/whl/nightly/cpu/ - - - name: Install torchvision - run: pip install --progress-bar=off --no-build-isolation --editable . - - - name: Install other prototype dependencies - run: pip install --progress-bar=off scipy pycocotools h5py iopath - - - name: Install test requirements - run: pip install --progress-bar=off pytest pytest-mock +# - name: Set up python +# uses: actions/setup-python@v3 +# with: +# python-version: 3.7 +# +# - name: Upgrade system packages +# run: python -m pip install --upgrade pip setuptools wheel +# +# - name: Checkout repository +# uses: actions/checkout@v3 +# +# - name: Install PyTorch nightly builds +# run: pip install --progress-bar=off --pre torch torchdata --extra-index-url https://download.pytorch.org/whl/nightly/cpu/ +# +# - name: Install torchvision +# run: pip install --progress-bar=off --no-build-isolation --editable . +# +# - name: Install other prototype dependencies +# run: pip install --progress-bar=off scipy pycocotools h5py iopath +# +# - name: Install test requirements +# run: pip install --progress-bar=off pytest pytest-mock + + - name: Dummy succeeding setup + run: exit 0 - name: Run prototype datasets tests id: datasets shell: bash - run: pytest --durations=20 test/test_prototype_datasets*.py + run: exit 0 - name: Run prototype transforms tests id: transforms if: ${{ success() || steps.datasets.conclusion == 'failure' }} shell: bash - run: pytest --durations=20 test/test_prototype_transforms*.py + run: exit 0 - name: Run prototype models tests - if: ${{ success() || steps.datasets.conclusion == 'failure' || steps.transforms.conclusion == 'failure' }} + if: ${{ success() || steps.transforms.conclusion == 'failure' }} id: models shell: bash - run: pytest --durations=20 test/test_prototype_models*.py + run: exit 0 From 1850e04d4bb67a2c51d4f29b706eb74f4c5be3a3 Mon Sep 17 00:00:00 2001 From: Philip Meier Date: Fri, 23 Sep 2022 13:51:25 +0200 Subject: [PATCH 08/19] [NEEDS REVERT] fix exit codes --- .github/workflows/prototype-tests.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/prototype-tests.yml b/.github/workflows/prototype-tests.yml index 41a8b1d9fa1..73eb3ea096d 100644 --- a/.github/workflows/prototype-tests.yml +++ b/.github/workflows/prototype-tests.yml @@ -45,16 +45,16 @@ jobs: - name: Run prototype datasets tests id: datasets shell: bash - run: exit 0 + run: exit 1 - name: Run prototype transforms tests id: transforms if: ${{ success() || steps.datasets.conclusion == 'failure' }} shell: bash - run: exit 0 + run: exit 1 - name: Run prototype models tests if: ${{ success() || steps.transforms.conclusion == 'failure' }} id: models shell: bash - run: exit 0 + run: exit 1 From 89f83067817f454bb5a7b919d38f8661ca23de20 Mon Sep 17 00:00:00 2001 From: Philip Meier Date: Fri, 23 Sep 2022 13:53:52 +0200 Subject: [PATCH 09/19] [NEEDS REVERT] fix exit codes ... again --- .github/workflows/prototype-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/prototype-tests.yml b/.github/workflows/prototype-tests.yml index 73eb3ea096d..50e0d8bc8e5 100644 --- a/.github/workflows/prototype-tests.yml +++ b/.github/workflows/prototype-tests.yml @@ -51,7 +51,7 @@ jobs: id: transforms if: ${{ success() || steps.datasets.conclusion == 'failure' }} shell: bash - run: exit 1 + run: exit 0 - name: Run prototype models tests if: ${{ success() || steps.transforms.conclusion == 'failure' }} From 8ecdad037b515405e832a26f40a6c57b036c1ff0 Mon Sep 17 00:00:00 2001 From: Philip Meier Date: Fri, 23 Sep 2022 13:53:52 +0200 Subject: [PATCH 10/19] Revert "[NEEDS REVERT] fix exit codes ... again" This reverts commit 89f83067817f454bb5a7b919d38f8661ca23de20. --- .github/workflows/prototype-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/prototype-tests.yml b/.github/workflows/prototype-tests.yml index 50e0d8bc8e5..73eb3ea096d 100644 --- a/.github/workflows/prototype-tests.yml +++ b/.github/workflows/prototype-tests.yml @@ -51,7 +51,7 @@ jobs: id: transforms if: ${{ success() || steps.datasets.conclusion == 'failure' }} shell: bash - run: exit 0 + run: exit 1 - name: Run prototype models tests if: ${{ success() || steps.transforms.conclusion == 'failure' }} From 5075038d09de8e99758374cdd426c54bfd4dc4ac Mon Sep 17 00:00:00 2001 From: Philip Meier Date: Fri, 23 Sep 2022 13:51:25 +0200 Subject: [PATCH 11/19] Revert "[NEEDS REVERT] fix exit codes" This reverts commit 1850e04d4bb67a2c51d4f29b706eb74f4c5be3a3. --- .github/workflows/prototype-tests.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/prototype-tests.yml b/.github/workflows/prototype-tests.yml index 73eb3ea096d..41a8b1d9fa1 100644 --- a/.github/workflows/prototype-tests.yml +++ b/.github/workflows/prototype-tests.yml @@ -45,16 +45,16 @@ jobs: - name: Run prototype datasets tests id: datasets shell: bash - run: exit 1 + run: exit 0 - name: Run prototype transforms tests id: transforms if: ${{ success() || steps.datasets.conclusion == 'failure' }} shell: bash - run: exit 1 + run: exit 0 - name: Run prototype models tests if: ${{ success() || steps.transforms.conclusion == 'failure' }} id: models shell: bash - run: exit 1 + run: exit 0 From 5626801050aea0ca4cfe2d9244d46f59dc7a8b6e Mon Sep 17 00:00:00 2001 From: Philip Meier Date: Fri, 23 Sep 2022 13:48:29 +0200 Subject: [PATCH 12/19] Revert "[NEEDS REVERT] proof of concept" This reverts commit 0617a41bced5a1aaf2f38e25c9775f7fa7d4c47f. --- .github/workflows/prototype-tests.yml | 55 +++++++++++++-------------- 1 file changed, 26 insertions(+), 29 deletions(-) diff --git a/.github/workflows/prototype-tests.yml b/.github/workflows/prototype-tests.yml index 41a8b1d9fa1..b4e25294be1 100644 --- a/.github/workflows/prototype-tests.yml +++ b/.github/workflows/prototype-tests.yml @@ -16,45 +16,42 @@ jobs: runs-on: ${{ matrix.os }} steps: -# - name: Set up python -# uses: actions/setup-python@v3 -# with: -# python-version: 3.7 -# -# - name: Upgrade system packages -# run: python -m pip install --upgrade pip setuptools wheel -# -# - name: Checkout repository -# uses: actions/checkout@v3 -# -# - name: Install PyTorch nightly builds -# run: pip install --progress-bar=off --pre torch torchdata --extra-index-url https://download.pytorch.org/whl/nightly/cpu/ -# -# - name: Install torchvision -# run: pip install --progress-bar=off --no-build-isolation --editable . -# -# - name: Install other prototype dependencies -# run: pip install --progress-bar=off scipy pycocotools h5py iopath -# -# - name: Install test requirements -# run: pip install --progress-bar=off pytest pytest-mock - - - name: Dummy succeeding setup - run: exit 0 + - name: Set up python + uses: actions/setup-python@v3 + with: + python-version: 3.7 + + - name: Upgrade system packages + run: python -m pip install --upgrade pip setuptools wheel + + - name: Checkout repository + uses: actions/checkout@v3 + + - name: Install PyTorch nightly builds + run: pip install --progress-bar=off --pre torch torchdata --extra-index-url https://download.pytorch.org/whl/nightly/cpu/ + + - name: Install torchvision + run: pip install --progress-bar=off --no-build-isolation --editable . + + - name: Install other prototype dependencies + run: pip install --progress-bar=off scipy pycocotools h5py iopath + + - name: Install test requirements + run: pip install --progress-bar=off pytest pytest-mock - name: Run prototype datasets tests id: datasets shell: bash - run: exit 0 + run: pytest --durations=20 test/test_prototype_datasets*.py - name: Run prototype transforms tests id: transforms if: ${{ success() || steps.datasets.conclusion == 'failure' }} shell: bash - run: exit 0 + run: pytest --durations=20 test/test_prototype_transforms*.py - name: Run prototype models tests - if: ${{ success() || steps.transforms.conclusion == 'failure' }} + if: ${{ success() || steps.datasets.conclusion == 'failure' || steps.transforms.conclusion == 'failure' }} id: models shell: bash - run: exit 0 + run: pytest --durations=20 test/test_prototype_models*.py From 7e86f2ed606b9e6a2f369afbd76c93903fa5b300 Mon Sep 17 00:00:00 2001 From: Philip Meier Date: Fri, 23 Sep 2022 13:49:07 +0200 Subject: [PATCH 13/19] simplify condition --- .github/workflows/prototype-tests.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/prototype-tests.yml b/.github/workflows/prototype-tests.yml index b4e25294be1..749fdf92578 100644 --- a/.github/workflows/prototype-tests.yml +++ b/.github/workflows/prototype-tests.yml @@ -39,6 +39,10 @@ jobs: - name: Install test requirements run: pip install --progress-bar=off pytest pytest-mock + - name: Mark setup as complete + id: setup + run: exit 0 + - name: Run prototype datasets tests id: datasets shell: bash @@ -46,12 +50,12 @@ jobs: - name: Run prototype transforms tests id: transforms - if: ${{ success() || steps.datasets.conclusion == 'failure' }} + if: ${{ steps.setup.conclusion == 'success' }} shell: bash run: pytest --durations=20 test/test_prototype_transforms*.py - name: Run prototype models tests - if: ${{ success() || steps.datasets.conclusion == 'failure' || steps.transforms.conclusion == 'failure' }} + if: ${{ steps.setup.conclusion == 'success' }} id: models shell: bash run: pytest --durations=20 test/test_prototype_models*.py From 9be34bc1bbf78d27567bca8a693904379dc164f8 Mon Sep 17 00:00:00 2001 From: Philip Meier Date: Fri, 23 Sep 2022 14:20:22 +0200 Subject: [PATCH 14/19] [SKIP CI] debug --- .github/workflows/prototype-tests.yml | 74 ++++++++++++++------------- 1 file changed, 39 insertions(+), 35 deletions(-) diff --git a/.github/workflows/prototype-tests.yml b/.github/workflows/prototype-tests.yml index 749fdf92578..5ac57db4149 100644 --- a/.github/workflows/prototype-tests.yml +++ b/.github/workflows/prototype-tests.yml @@ -16,46 +16,50 @@ jobs: runs-on: ${{ matrix.os }} steps: - - name: Set up python - uses: actions/setup-python@v3 - with: - python-version: 3.7 - - - name: Upgrade system packages - run: python -m pip install --upgrade pip setuptools wheel - - - name: Checkout repository - uses: actions/checkout@v3 - - - name: Install PyTorch nightly builds - run: pip install --progress-bar=off --pre torch torchdata --extra-index-url https://download.pytorch.org/whl/nightly/cpu/ - - - name: Install torchvision - run: pip install --progress-bar=off --no-build-isolation --editable . - - - name: Install other prototype dependencies - run: pip install --progress-bar=off scipy pycocotools h5py iopath - - - name: Install test requirements - run: pip install --progress-bar=off pytest pytest-mock +# - name: Set up python +# uses: actions/setup-python@v3 +# with: +# python-version: 3.7 +# +# - name: Upgrade system packages +# run: python -m pip install --upgrade pip setuptools wheel +# +# - name: Checkout repository +# uses: actions/checkout@v3 +# +# - name: Install PyTorch nightly builds +# run: pip install --progress-bar=off --pre torch torchdata --extra-index-url https://download.pytorch.org/whl/nightly/cpu/ +# +# - name: Install torchvision +# run: pip install --progress-bar=off --no-build-isolation --editable . +# +# - name: Install other prototype dependencies +# run: pip install --progress-bar=off scipy pycocotools h5py iopath +# +# - name: Install test requirements +# run: pip install --progress-bar=off pytest pytest-mock - name: Mark setup as complete id: setup run: exit 0 - - name: Run prototype datasets tests - id: datasets - shell: bash - run: pytest --durations=20 test/test_prototype_datasets*.py + - name: Check conclusion + run: echo ${{ steps.setup.conclusion }} - - name: Run prototype transforms tests - id: transforms + - name: Use in condition if: ${{ steps.setup.conclusion == 'success' }} - shell: bash - run: pytest --durations=20 test/test_prototype_transforms*.py + run: echo WOOHOO - - name: Run prototype models tests - if: ${{ steps.setup.conclusion == 'success' }} - id: models - shell: bash - run: pytest --durations=20 test/test_prototype_models*.py +# - name: Run prototype datasets tests +# shell: bash +# run: pytest --durations=20 test/test_prototype_datasets*.py +# +# - name: Run prototype transforms tests +# if: ${{ steps.setup.conclusion == 'success' }} +# shell: bash +# run: pytest --durations=20 test/test_prototype_transforms*.py +# +# - name: Run prototype models tests +# if: ${{ steps.setup.conclusion == 'success' }} +# shell: bash +# run: pytest --durations=20 test/test_prototype_models*.py From 40c281c80274c7b35952d4db299952f4cc4d374c Mon Sep 17 00:00:00 2001 From: Philip Meier Date: Fri, 23 Sep 2022 14:23:13 +0200 Subject: [PATCH 15/19] [SKIP CI] debug with failure --- .github/workflows/prototype-tests.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/prototype-tests.yml b/.github/workflows/prototype-tests.yml index 1a811661948..ed99d01bfdb 100644 --- a/.github/workflows/prototype-tests.yml +++ b/.github/workflows/prototype-tests.yml @@ -46,6 +46,9 @@ jobs: - name: Check conclusion run: echo ${{ steps.setup.conclusion }} + - name: Failure + run: exit 1 + - name: Use in condition if: ${{ steps.setup.conclusion == 'success' }} run: echo WOOHOO From 6957e45324f514c98e2cc251811e600c891fc360 Mon Sep 17 00:00:00 2001 From: Philip Meier Date: Fri, 23 Sep 2022 14:26:30 +0200 Subject: [PATCH 16/19] [SKIP CI] debug other condition --- .github/workflows/prototype-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/prototype-tests.yml b/.github/workflows/prototype-tests.yml index ed99d01bfdb..8d9c5c4d99e 100644 --- a/.github/workflows/prototype-tests.yml +++ b/.github/workflows/prototype-tests.yml @@ -50,7 +50,7 @@ jobs: run: exit 1 - name: Use in condition - if: ${{ steps.setup.conclusion == 'success' }} + if: ${{ success() || ( failure() && steps.setup.conclusion == 'success' ) }} run: echo WOOHOO # - name: Run prototype datasets tests From 8a8961da9546e9d2dcf87442b6a05cc882036911 Mon Sep 17 00:00:00 2001 From: Philip Meier Date: Fri, 23 Sep 2022 14:28:04 +0200 Subject: [PATCH 17/19] [SKIP CI] debug try without moustache --- .github/workflows/prototype-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/prototype-tests.yml b/.github/workflows/prototype-tests.yml index 8d9c5c4d99e..007758aba29 100644 --- a/.github/workflows/prototype-tests.yml +++ b/.github/workflows/prototype-tests.yml @@ -50,7 +50,7 @@ jobs: run: exit 1 - name: Use in condition - if: ${{ success() || ( failure() && steps.setup.conclusion == 'success' ) }} + if: success() || ( failure() && steps.setup.conclusion == 'success' ) run: echo WOOHOO # - name: Run prototype datasets tests From 515868b86a06bfb26d04ea7ceb1e1d251ee100d3 Mon Sep 17 00:00:00 2001 From: Philip Meier Date: Fri, 23 Sep 2022 14:30:46 +0200 Subject: [PATCH 18/19] revert debug --- .github/workflows/prototype-tests.yml | 104 ++++++++++++-------------- 1 file changed, 48 insertions(+), 56 deletions(-) diff --git a/.github/workflows/prototype-tests.yml b/.github/workflows/prototype-tests.yml index 007758aba29..2a3a409896c 100644 --- a/.github/workflows/prototype-tests.yml +++ b/.github/workflows/prototype-tests.yml @@ -16,67 +16,59 @@ jobs: runs-on: ${{ matrix.os }} steps: -# - name: Set up python -# uses: actions/setup-python@v3 -# with: -# python-version: 3.7 -# -# - name: Upgrade system packages -# run: python -m pip install --upgrade pip setuptools wheel -# -# - name: Checkout repository -# uses: actions/checkout@v3 -# -# - name: Install PyTorch nightly builds -# run: pip install --progress-bar=off --pre torch torchdata --extra-index-url https://download.pytorch.org/whl/nightly/cpu/ -# -# - name: Install torchvision -# run: pip install --progress-bar=off --no-build-isolation --editable . -# -# - name: Install other prototype dependencies -# run: pip install --progress-bar=off scipy pycocotools h5py iopath -# -# - name: Install test requirements -# run: pip install --progress-bar=off pytest pytest-mock + - name: Set up python + uses: actions/setup-python@v3 + with: + python-version: 3.7 + + - name: Upgrade system packages + run: python -m pip install --upgrade pip setuptools wheel + + - name: Checkout repository + uses: actions/checkout@v3 + + - name: Install PyTorch nightly builds + run: pip install --progress-bar=off --pre torch torchdata --extra-index-url https://download.pytorch.org/whl/nightly/cpu/ + + - name: Install torchvision + run: pip install --progress-bar=off --no-build-isolation --editable . + + - name: Install other prototype dependencies + run: pip install --progress-bar=off scipy pycocotools h5py iopath + + - name: Install test requirements + run: pip install --progress-bar=off pytest pytest-mock - name: Mark setup as complete id: setup run: exit 0 - - name: Check conclusion - run: echo ${{ steps.setup.conclusion }} - - - name: Failure - run: exit 1 + - name: Run prototype datasets tests + if: success() || ( failure() && steps.setup.conclusion == 'success' ) + shell: bash + run: | + pytest \ + --durations=20 \ + --cov=torchvision/prototype/datasets \ + --cov-report=term-missing \ + test/test_prototype_datasets*.py - - name: Use in condition + - name: Run prototype transforms tests if: success() || ( failure() && steps.setup.conclusion == 'success' ) - run: echo WOOHOO + shell: bash + run: | + pytest \ + --durations=20 \ + --cov=torchvision/prototype/transforms \ + --cov-report=term-missing \ + test/test_prototype_transforms*.py -# - name: Run prototype datasets tests -# shell: bash -# run: | -# pytest \ -# --durations=20 \ -# --cov=torchvision/prototype/datasets \ -# --cov-report=term-missing \ -# test/test_prototype_datasets*.py -# -# - name: Run prototype transforms tests -# shell: bash -# run: | -# pytest \ -# --durations=20 \ -# --cov=torchvision/prototype/transforms \ -# --cov-report=term-missing \ -# test/test_prototype_transforms*.py -# -# - name: Run prototype models tests -# if: ${{ steps.setup.conclusion == 'success' }} -# shell: bash -# run: | -# pytest \ -# --durations=20 \ -# --cov=torchvision/prototype/models \ -# --cov-report=term-missing \ -# test/test_prototype_models*.py + - name: Run prototype models tests + if: success() || ( failure() && steps.setup.conclusion == 'success' ) + shell: bash + run: | + pytest \ + --durations=20 \ + --cov=torchvision/prototype/models \ + --cov-report=term-missing \ + test/test_prototype_models*.py From 2cee66cabe3d4916326f9dbf62faec357caeeff8 Mon Sep 17 00:00:00 2001 From: Philip Meier Date: Fri, 23 Sep 2022 14:31:44 +0200 Subject: [PATCH 19/19] readd test dependency --- .github/workflows/prototype-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/prototype-tests.yml b/.github/workflows/prototype-tests.yml index 2a3a409896c..e9832860c40 100644 --- a/.github/workflows/prototype-tests.yml +++ b/.github/workflows/prototype-tests.yml @@ -37,7 +37,7 @@ jobs: run: pip install --progress-bar=off scipy pycocotools h5py iopath - name: Install test requirements - run: pip install --progress-bar=off pytest pytest-mock + run: pip install --progress-bar=off pytest pytest-mock pytest-cov - name: Mark setup as complete id: setup