Skip to content

add test split for imagenet #4866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 8, 2021
Merged

add test split for imagenet #4866

merged 3 commits into from
Nov 8, 2021

Conversation

@pmeier
Copy link
Contributor

@pmeier pmeier commented Nov 5, 2021 •
edited by pytorch-probot bot
Loading

Closes #4855.

cc @pmeier @bjuncek

@pmeier pmeier requested a review from datumbox November 5, 2021 08:15
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 5, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit ebecc93 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

1 failure not recognized by patterns:

Job Step Action
CircleCI binary_libtorchvision_ops_android Build 🔁 rerun
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

datumbox
datumbox approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmeier Looks good to me. Just 2 questions, see below:

@pmeier pmeier merged commit 6d9a42c into pytorch:main Nov 8, 2021
@pmeier pmeier deleted the datasets/imagenet-test branch November 8, 2021 08:04
facebook-github-bot pushed a commit that referenced this pull request Nov 15, 2021
@kazhang @facebook-github-bot
[fbsync] add test split for imagenet (#4866)
8a674da 
Summary:
* add test split for imagenet

* add infinite buffer size to shuffler

Reviewed By: datumbox

Differential Revision: D32298970

fbshipit-source-id: 3566398a571df2469c597fcdf93af124ef99e9c9
cyyever pushed a commit to cyyever/vision that referenced this pull request Nov 16, 2021
@pmeier @cyyever
add test split for imagenet (pytorch#4866)
45ae625 
* add test split for imagenet

* add infinite buffer size to shuffler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@datumbox datumbox datumbox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/default cla signed module: datasets new feature prototype

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support of the test split on ImageNet

3 participants

@pmeier @facebook-github-bot @datumbox