From a2a1b5ca4fe42acd80ffb75aef6183bcab3b2e5d Mon Sep 17 00:00:00 2001 From: Vasilis Vryniotis Date: Tue, 14 Sep 2021 09:03:00 +0100 Subject: [PATCH 1/4] Disabling tests. --- test/test_io.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/test_io.py b/test/test_io.py index 150d66f0814..cd86630eccd 100644 --- a/test/test_io.py +++ b/test/test_io.py @@ -77,6 +77,10 @@ def test_write_read_video(self): assert_equal(data, lv) assert info["video_fps"] == 5 + # Rollback once #4402 is fixed + @pytest.mark.skipif(sys.platform == "darwin", reason=( + 'This test segfaults on MacOS; temporarily disabling to enable test execution.' + )) @pytest.mark.skipif(not io._HAS_VIDEO_OPT, reason="video_reader backend is not chosen") def test_probe_video_from_file(self): with temp_video(10, 300, 300, 5) as (f_name, data): From c6800f7a15928dd39a92561f287417c0d7b8cac0 Mon Sep 17 00:00:00 2001 From: Vasilis Vryniotis Date: Tue, 14 Sep 2021 09:37:34 +0100 Subject: [PATCH 2/4] Disabling the whole class. --- test/test_io.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/test_io.py b/test/test_io.py index cd86630eccd..9f5aaa69f01 100644 --- a/test/test_io.py +++ b/test/test_io.py @@ -63,6 +63,10 @@ def temp_video(num_frames, height, width, fps, lossless=False, video_codec=None, os.unlink(f.name) +# Rollback once #4402 is fixed +@pytest.mark.skipif(sys.platform == "darwin", reason=( + 'These tests segfault on MacOS; temporarily disabling.' +)) @pytest.mark.skipif(get_video_backend() != "pyav" and not io._HAS_VIDEO_OPT, reason="video_reader backend not available") @pytest.mark.skipif(av is None, reason="PyAV unavailable") @@ -77,10 +81,6 @@ def test_write_read_video(self): assert_equal(data, lv) assert info["video_fps"] == 5 - # Rollback once #4402 is fixed - @pytest.mark.skipif(sys.platform == "darwin", reason=( - 'This test segfaults on MacOS; temporarily disabling to enable test execution.' - )) @pytest.mark.skipif(not io._HAS_VIDEO_OPT, reason="video_reader backend is not chosen") def test_probe_video_from_file(self): with temp_video(10, 300, 300, 5) as (f_name, data): From 136d6dccbaecaa80df4e6805a9c6af3c450f50bb Mon Sep 17 00:00:00 2001 From: Vasilis Vryniotis Date: Tue, 14 Sep 2021 10:25:24 +0100 Subject: [PATCH 3/4] Disabling tests of TestVideoReader. --- test/test_video_reader.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/test/test_video_reader.py b/test/test_video_reader.py index 66e92d88dba..0b22b8cc97b 100644 --- a/test/test_video_reader.py +++ b/test/test_video_reader.py @@ -2,6 +2,7 @@ import itertools import math import os +import sys import pytest from pytest import approx from fractions import Fraction @@ -269,6 +270,10 @@ def _get_video_tensor(video_dir, video_file): return full_path, video_tensor +# Rollback once #4402 is fixed +@pytest.mark.skipif(sys.platform == "darwin", reason=( + 'These tests segfault on MacOS; temporarily disabling.' +)) @pytest.mark.skipif(av is None, reason="PyAV unavailable") @pytest.mark.skipif(_HAS_VIDEO_OPT is False, reason="Didn't compile with ffmpeg") class TestVideoReader: From 5d7bfe4487d56a5002ce79a855da6a2276fdd582 Mon Sep 17 00:00:00 2001 From: Vasilis Vryniotis Date: Tue, 14 Sep 2021 11:04:39 +0100 Subject: [PATCH 4/4] Disabling TestVideoApi. --- test/test_videoapi.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/test/test_videoapi.py b/test/test_videoapi.py index 734620e8f74..154c0669842 100644 --- a/test/test_videoapi.py +++ b/test/test_videoapi.py @@ -1,5 +1,6 @@ import collections import os +import sys import pytest from pytest import approx import urllib @@ -64,6 +65,10 @@ def fate(name, path="."): } +# Rollback once #4402 is fixed +@pytest.mark.skipif(sys.platform == "darwin", reason=( + 'These tests segfault on MacOS; temporarily disabling.' +)) @pytest.mark.skipif(_HAS_VIDEO_OPT is False, reason="Didn't compile with ffmpeg") @PY39_SKIP class TestVideoApi: