fix dependency table #4308
Merged
fix dependency table #4308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
approved these changes
Aug 23, 2021
Member
NicolasHug
left a comment
NicolasHug
left a comment
There was a problem hiding this comment.
Thanks Philip, LGTM
I'm wondering what the reason is for specifying upper bounds on the Python version: aren't all 3.X versions backward-compatible anyway?
Contributor
Author
|
We only build binaries for the versions I've given in the table. So if you are on Python 3.9, you cannot |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 26, 2021
Reviewed By: fmassa Differential Revision: D30525889 fbshipit-source-id: 241bb5d2cc6dc82c395ef2b3d8956049db849baa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4306 broke the dependency table in our README. This fixes that and adds some more constraints that weren't being tracked properly.